From: Alex Elder <aelder@sgi.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: <linux-ext4@vger.kernel.org>,
Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
<xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Assume yes when test device is not partitioned
Date: Thu, 22 Sep 2011 17:02:49 -0500 [thread overview]
Message-ID: <1316728969.2009.95.camel@doink> (raw)
In-Reply-To: <1316726084.2009.85.camel@doink>
On Thu, 2011-09-22 at 16:14 -0500, Alex Elder wrote:
> On Sat, 2011-09-03 at 14:03 +0530, Prasad Joshi wrote:
> > If an entire device used for file system creation, the mkfs.ext2/3/4
> > asks for confirmation before proceeding. Since the device is
> > configured for testing it is safe to assume positive response
> > during mkfs.
> >
> > The patch also replaces hard coded mkfs path with MKFS_PROG variable.
> >
> > Signed-off-by: Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>
> > Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
>
> Thanks for submitting a patch, Prasad (and Chaitanya).
>
> Can you please re-submit this? Based on feedback what
> we're looking for would be:
> [PATCH 0/2] description e-mail
> [PATCH 1/2] patch that substitutes /sbin/mkfs with ${MKFS_PROG}
> [PATCH 2/2] patch that adds a '-f' flag to ${MKFS_PROG}.${FSTYP}
> for all ext* filesystem types.
Oh, and while I'm thinking about it...
/sbin/mkfs.${FSTYP} and ${MKFS_PROG}.${FSTYP} are most likely
incorrect. The switch to MKFS_PROG at least finds where the
mkfs executable lies, but in theory anyway there is no guarantee
that, for example, the mkfs.xfs program lies in the same directory.
The mkfs executable uses the PATH (via execvp()) to find the
filesystem-specific mkfs program to use, and I expect we should
work the same way.
-Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Elder <aelder@sgi.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: linux-ext4@vger.kernel.org,
Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Assume yes when test device is not partitioned
Date: Thu, 22 Sep 2011 17:02:49 -0500 [thread overview]
Message-ID: <1316728969.2009.95.camel@doink> (raw)
In-Reply-To: <1316726084.2009.85.camel@doink>
On Thu, 2011-09-22 at 16:14 -0500, Alex Elder wrote:
> On Sat, 2011-09-03 at 14:03 +0530, Prasad Joshi wrote:
> > If an entire device used for file system creation, the mkfs.ext2/3/4
> > asks for confirmation before proceeding. Since the device is
> > configured for testing it is safe to assume positive response
> > during mkfs.
> >
> > The patch also replaces hard coded mkfs path with MKFS_PROG variable.
> >
> > Signed-off-by: Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>
> > Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
>
> Thanks for submitting a patch, Prasad (and Chaitanya).
>
> Can you please re-submit this? Based on feedback what
> we're looking for would be:
> [PATCH 0/2] description e-mail
> [PATCH 1/2] patch that substitutes /sbin/mkfs with ${MKFS_PROG}
> [PATCH 2/2] patch that adds a '-f' flag to ${MKFS_PROG}.${FSTYP}
> for all ext* filesystem types.
Oh, and while I'm thinking about it...
/sbin/mkfs.${FSTYP} and ${MKFS_PROG}.${FSTYP} are most likely
incorrect. The switch to MKFS_PROG at least finds where the
mkfs executable lies, but in theory anyway there is no guarantee
that, for example, the mkfs.xfs program lies in the same directory.
The mkfs executable uses the PATH (via execvp()) to find the
filesystem-specific mkfs program to use, and I expect we should
work the same way.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-22 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 8:33 [PATCH] xfstests: Assume yes when test device is not partitioned Prasad Joshi
2011-09-03 8:33 ` Prasad Joshi
2011-09-22 21:14 ` Alex Elder
2011-09-22 21:14 ` Alex Elder
2011-09-22 22:02 ` Alex Elder [this message]
2011-09-22 22:02 ` Alex Elder
2012-10-26 15:54 ` Rich Johnston
2012-10-26 15:54 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316728969.2009.95.camel@doink \
--to=aelder@sgi.com \
--cc=chaitanyakulkarni15@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=prasadjoshi.linux@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.