[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Rico Bachmann]

added the patches, still not working
could be a problem with the filepath in the patch?

Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
 package/libfcgi/Config.in               |    3 ++-
 package/libfcgi/libfcgi.mk              |    2 --
 package/libfcgi/link_math_cgifcgi.patch |   11 +++++++++++
 package/libfcgi/link_math_example.patch |   11 +++++++++++
 4 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100755 package/libfcgi/link_math_cgifcgi.patch
 create mode 100755 package/libfcgi/link_math_example.patch

diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
index 169c6f2..a2f448b 100755
--- a/package/libfcgi/Config.in
+++ b/package/libfcgi/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFCGI
     bool "libfcgi"
     help
-        fastcgi developerslibrary
+        This is a fastcgi developer library for C/C++
         http://www.fastcgi.com/
+
diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
index e338f29..04c9996 100755
--- a/package/libfcgi/libfcgi.mk
+++ b/package/libfcgi/libfcgi.mk
@@ -7,7 +7,5 @@ LIBFCGI_VERSION = 2.4.0
 LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
 LIBFCGI_SITE = http://www.fastcgi.com/dist
 LIBFCGI_INSTALL_STAGING = YES
-LIBFCGI_INSTALL_TARGET = YES
-LIBFCGI_CONF_OPT = --enable-shared
 
 $(eval $(call AUTOTARGETS,package,libfcgi))
diff --git a/package/libfcgi/link_math_cgifcgi.patch b/package/libfcgi/link_math_cgifcgi.patch
new file mode 100755
index 0000000..add425a
--- /dev/null
+++ b/package/libfcgi/link_math_cgifcgi.patch
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:05:06.000000000 +0200
+@@ -119,7 +119,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/cgi-fcgi.Po
diff --git a/package/libfcgi/link_math_example.patch b/package/libfcgi/link_math_example.patch
new file mode 100755
index 0000000..fff2595
--- /dev/null
+++ b/package/libfcgi/link_math_example.patch
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:04:37.000000000 +0200
+@@ -171,7 +171,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/authorizer.Po $(DEPDIR)/echo-cpp.Po \
-- 
1.7.2.5

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Rico Bachmann]

added the patches, still not working
could be a problem with the filepath in the patch?

Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
 package/libfcgi/Config.in               |    3 ++-
 package/libfcgi/libfcgi.mk              |    2 --
 package/libfcgi/link_math_cgifcgi.patch |   11 +++++++++++
 package/libfcgi/link_math_example.patch |   11 +++++++++++
 4 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100755 package/libfcgi/link_math_cgifcgi.patch
 create mode 100755 package/libfcgi/link_math_example.patch

diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
index 169c6f2..a2f448b 100755
--- a/package/libfcgi/Config.in
+++ b/package/libfcgi/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFCGI
     bool "libfcgi"
     help
-        fastcgi developerslibrary
+        This is a fastcgi developer library for C/C++
         http://www.fastcgi.com/
+
diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
index e338f29..04c9996 100755
--- a/package/libfcgi/libfcgi.mk
+++ b/package/libfcgi/libfcgi.mk
@@ -7,7 +7,5 @@ LIBFCGI_VERSION = 2.4.0
 LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
 LIBFCGI_SITE = http://www.fastcgi.com/dist
 LIBFCGI_INSTALL_STAGING = YES
-LIBFCGI_INSTALL_TARGET = YES
-LIBFCGI_CONF_OPT = --enable-shared
 
 $(eval $(call AUTOTARGETS,package,libfcgi))
diff --git a/package/libfcgi/link_math_cgifcgi.patch b/package/libfcgi/link_math_cgifcgi.patch
new file mode 100755
index 0000000..add425a
--- /dev/null
+++ b/package/libfcgi/link_math_cgifcgi.patch
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:05:06.000000000 +0200
+@@ -119,7 +119,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/cgi-fcgi.Po
diff --git a/package/libfcgi/link_math_example.patch b/package/libfcgi/link_math_example.patch
new file mode 100755
index 0000000..fff2595
--- /dev/null
+++ b/package/libfcgi/link_math_example.patch
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:04:37.000000000 +0200
+@@ -171,7 +171,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/authorizer.Po $(DEPDIR)/echo-cpp.Po \
-- 
1.7.2.5

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Thomas Petazzoni]

Le Thu, 29 Sep 2011 10:45:17 +0200,
Rico Bachmann <bachmann@tofwerk.com> a ?crit :

> added the patches, still not working
> could be a problem with the filepath in the patch?

I'm sorry to say so, but: please read my e-mails. I said:

"""
Simply add them in package/fcgi/, under a name like
fcgi-2.4.0-some-useful-description.patch.
"""

So link_math_cgifcgi.patch should be fcgi-2.0.4-link_math_cgifcgi.patch
if you want the patch to be applied.

Also, here you have only sent PATCH 2/2, and this patch should be
merged into the previous one to create a single patch that adds the
package and its associated patches. To do so, you can do:

 git rebase -i master

When the editor pops up, on the second line that corresponds to the
second commit, replace "pick" by "fixup", and exit your editor. This
will instruct git to merge your second commit into your first commit.

Also:

 * Your two patches link_math_cgifcgi.patch and link_math_example.patch
   should be just one patch.

 * This patch should have a description and a Signed-off-by line.

 * Patching the Makefiles in an autotools-based package is really
   wrong, it's the Makefile.am that should be patched. I think your
   LDFLAGS = -lm is more a workaround than a correct fix.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Arnout Vandecappelle]

[I put Rico back in CC]
On Thursday 29 September 2011 11:58:49, Thomas Petazzoni wrote:
> Le Thu, 29 Sep 2011 10:45:17 +0200,
> 
> Rico Bachmann <bachmann@tofwerk.com> a ?crit :
> > added the patches, still not working
> > could be a problem with the filepath in the patch?
[snip]
> Also:
> 
>  * Your two patches link_math_cgifcgi.patch and link_math_example.patch
>    should be just one patch.

 You typically generate the patch like this:

1. Make a copy of the unmodified source tree:
cp -a output/build/fcgi-2.4.0 output/build/fcgi-2.4.0.orig

2. Hack away in output/build/fcgi-2.4.0 until it works.

3. Create the patch relative to the build directory:
cd output/build
diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
  ../../package/fcgi/fcgi-2.4.0-add-lm.patch

4. Verify that it works by doing a clean build:
make fcgi-dirclean; make fcgi

5.
>  * This patch should have a description and a Signed-off-by line.

 Edit package/fcgi/fcgi-2.4.0-add-lm.patch to add these things.

 The description goes in the beginning of the patch, before the first 'diff', 
and explains why the patch is necessary.

 The Signed-off-by line comes at the end of this patch comment.  It shows that 
you are the author of the patch and that you agree to distribute it under GPL.  
See http://kerneltrap.org/files/Jeremy/DCO.txt

 Terminate the description with a line containing three dashes: ---

 And look at some of the existing patches for inspiration :-)

>  * Patching the Makefiles in an autotools-based package is really
>    wrong, it's the Makefile.am that should be patched. I think your
>    LDFLAGS = -lm is more a workaround than a correct fix.

 The Makefile will be overwritten next time you configure the package.  You'll 
notice that in step 4 :-).  Instead, you have to modify Makefile.am.  
Autotools uses Makefile.am to generate Makefile.in, and configure uses 
Makefile.in to generate Makefile.  However, buildroot normally doesn't run 
autotools but uses the distributed Makefile.in instead.  So, you should patch 
both Makefile.am and Makefile.in.


 6. Send your patch to the upstream project.  And be prepared to get 
completely different feedback from them than what you got here :-)


 Good luck!
 
 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Rico Bachmann]

> -----Urspr?ngliche Nachricht-----
> Von: Arnout Vandecappelle [mailto:arnout at mind.be]
> Gesendet: Samstag, 1. Oktober 2011 22:59
> An: buildroot at busybox.net
> Cc: Thomas Petazzoni; Rico Bachmann
> Betreff: Re: [Buildroot] [PATCH 2/2] add libfcgi to buildroot
> 
> [I put Rico back in CC]
> On Thursday 29 September 2011 11:58:49, Thomas Petazzoni wrote:
> > Le Thu, 29 Sep 2011 10:45:17 +0200,
> >
> > Rico Bachmann <bachmann@tofwerk.com> a ?crit :
> > > added the patches, still not working
> > > could be a problem with the filepath in the patch?
> [snip]
> > Also:
> >
> >  * Your two patches link_math_cgifcgi.patch and
> link_math_example.patch
> >    should be just one patch.
> 
>  You typically generate the patch like this:
> 
> 1. Make a copy of the unmodified source tree:
> cp -a output/build/fcgi-2.4.0 output/build/fcgi-2.4.0.orig
> 
> 2. Hack away in output/build/fcgi-2.4.0 until it works.
> 
> 3. Create the patch relative to the build directory:
> cd output/build
> diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
>   ../../package/fcgi/fcgi-2.4.0-add-lm.patch
> 
> 4. Verify that it works by doing a clean build:
> make fcgi-dirclean; make fcgi
> 
> 5.
> >  * This patch should have a description and a Signed-off-by line.
> 
>  Edit package/fcgi/fcgi-2.4.0-add-lm.patch to add these things.
> 
>  The description goes in the beginning of the patch, before the first
> 'diff',
> and explains why the patch is necessary.
> 
>  The Signed-off-by line comes at the end of this patch comment.  It
> shows that
> you are the author of the patch and that you agree to distribute it
> under GPL.
> See http://kerneltrap.org/files/Jeremy/DCO.txt
> 
>  Terminate the description with a line containing three dashes: ---
> 
>  And look at some of the existing patches for inspiration :-)
> 
> >  * Patching the Makefiles in an autotools-based package is really
> >    wrong, it's the Makefile.am that should be patched. I think your
> >    LDFLAGS = -lm is more a workaround than a correct fix.
> 
>  The Makefile will be overwritten next time you configure the package.
> You'll
> notice that in step 4 :-).  Instead, you have to modify Makefile.am.
> Autotools uses Makefile.am to generate Makefile.in, and configure uses
> Makefile.in to generate Makefile.  However, buildroot normally doesn't
> run
> autotools but uses the distributed Makefile.in instead.  So, you should
> patch
> both Makefile.am and Makefile.in.
> 
> 
>  6. Send your patch to the upstream project.  And be prepared to get
> completely different feedback from them than what you got here :-)
> 
> 
>  Good luck!
> 
>  Regards,
>  Arnout
> --
> Arnout Vandecappelle                               arnout at mind be
> Senior Embedded Software Architect                 +32-16-286540
> Essensium/Mind                                     http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

Thanks for this nice explanation.
I will fix the package in the Makefile.in and in the Makefile.am
And add i nice patch with all necessary comments and signed-off-by line etc.

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Rico Bachmann]

Am 01.10.2011, 22:59 Uhr, schrieb Arnout Vandecappelle
<arnout@mind.be>:

> 3. Create the patch relative to the build directory:
> cd output/build
> diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
>   ../../package/fcgi/fcgi-2.4.0-add-lm.patch
>

When I try to create my patch with this command I got a fault, file or
folder not found, when I
delete the backslash after the '>' it works fine. But my patch still have
no effect if i try to build the
package with buildroot and use the patch automatically.

If I use my patch manual it works fine:

       commands:
       cd /buildroot/output/build
       patch -p0 < ../../package/fcgi/fcgi-2.4.0-add-lm.patch

       output:
       patching file fcgi-2.4.0/cgi-fcgi/Makefile.in
       patching file fcgi-2.4.0/examples/Makefile.in

After that I can build the package (of course only without a make
fcgi-dirclean)

Here is the output form buildroot while using the patch:

       >>> fcgi 2.4.0 Patching packages/fcgi
       for file in config.guess config.cub; do for i $(find
/buildroot/output/build/fcgi-2.4.0 -name $file);
       do cp package/gnuconfig/$file $i;
       done; done

After that, the build still failed.

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Arnout Vandecappelle]

On Tuesday 11 October 2011 16:29:42, Rico Bachmann wrote:
> Here is the output form buildroot while using the patch:
> 
>        >>> fcgi 2.4.0 Patching packages/fcgi
>        for file in config.guess config.cub; do for i $(find
> /buildroot/output/build/fcgi-2.4.0 -name $file);
>        do cp package/gnuconfig/$file $i;
>        done; done

 Weird, you should get
>>> fcgi 2.4.0  Updating config.sub and config.guess
before the 'for'.

 And of course, you should get 
Applying fcgi-2.4.0-add-lm.patch using plaintext: 
before that one.

 That file does exist in the package/fcgi directory, right?  It's not that the 
patch ended up in a completely different place?


 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111011/f2cde576/attachment.html>

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Rico Bachmann]

Am 11.10.2011, 18:06 Uhr, schrieb Arnout Vandecappelle  
<arnout@mind.be>:

>
> On Tuesday 11 October 2011 16:29:42, Rico Bachmann wrote:
>> Here is the output form buildroot while using the patch:
>>
>>        >>> fcgi 2.4.0 Patching packages/fcgi
>>        for file in config.guess config.cub; do for i $(find
>> /buildroot/output/build/fcgi-2.4.0 -name $file);
>>        do cp package/gnuconfig/$file $i;
>>        done; done
>
>  Weird, you should get
>>>> fcgi 2.4.0  Updating config.sub and config.guess
> before the 'for'.
>
>  And of course, you should get
> Applying fcgi-2.4.0-add-lm.patch using plaintext:
> before that one.
>
>  That file does exist in the package/fcgi directory, right?  It's not  
> that the
> patch ended up in a completely different place?

yes the file exists in package/fcgi and has 777 rights

>
>
>  Regards,
>  Arnout

[Buildroot] [PATCH 2/2] add libfcgi to buildroot

[Arnout Vandecappelle]

On Wednesday 12 October 2011 12:12:29, Rico Bachmann wrote:
> yes the file exists in package/fcgi and has 777 rights

 Silly me, I just now saw that the package is called libfcgi, not fcgi.  So it should of course be in the package/libfcgi directory and it should be called libfcgi-....patch.

 Anyway, there's a better solution: add -lm in the LDFLAGS of the configure environment.

 I'll just send a patch with the complete libfcgi support as a follow-up of this mail.

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/608b7d0d/attachment.html>

[Buildroot] [PATCH] package: add libfcgi fast cgi library.

[Arnout Vandecappelle]

From: Rico Bachmann <bachmann@tofwerk.com>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    6 ++++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk

diff --git a/package/Config.in b/package/Config.in
index 7dc8887..76c89c7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
new file mode 100644
index 0000000..a2f448b
--- /dev/null
+++ b/package/libfcgi/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBFCGI
+    bool "libfcgi"
+    help
+        This is a fastcgi developer library for C/C++
+        http://www.fastcgi.com/
+
diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
new file mode 100644
index 0000000..72bbf9a
--- /dev/null
+++ b/package/libfcgi/libfcgi.mk
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS,package,libfcgi))
-- 
1.7.7

[Buildroot] [PATCH] package: add libfcgi fast cgi library.

[Thomas Petazzoni]

Le Fri, 14 Oct 2011 00:46:59 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :

> +config BR2_PACKAGE_LIBFCGI
> +    bool "libfcgi"
> +    help

One tab.

> +        This is a fastcgi developer library for C/C++
> +        http://www.fastcgi.com/

One tab + two spaces.

> diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
> new file mode 100644
> index 0000000..72bbf9a
> --- /dev/null
> +++ b/package/libfcgi/libfcgi.mk
> @@ -0,0 +1,12 @@
> +##############################################################################
> +#
> +# libfcgi
> +#
> +##############################################################################
> +LIBFCGI_VERSION = 2.4.0
> +LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
> +LIBFCGI_SITE = http://www.fastcgi.com/dist
> +LIBFCGI_INSTALL_STAGING = YES
> +LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
> +
> +$(eval $(call AUTOTARGETS,package,libfcgi))

$(eval $(call AUTOTARGETS))

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2] package: add libfcgi fast cgi library.

[Arnout Vandecappelle]

From: Rico Bachmann <bachmann@tofwerk.com>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
Changes v2: corrected indentation of Config.in, removed redundant
arguments of AUTOTARGETS.
---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    6 ++++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk

diff --git a/package/Config.in b/package/Config.in
index 7dc8887..76c89c7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
new file mode 100644
index 0000000..a2f448b
--- /dev/null
+++ b/package/libfcgi/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBFCGI
+    bool "libfcgi"
+    help
+        This is a fastcgi developer library for C/C++
+        http://www.fastcgi.com/
+
diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
new file mode 100644
index 0000000..72bbf9a
--- /dev/null
+++ b/package/libfcgi/libfcgi.mk
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS,package,libfcgi))
-- 
1.7.7

[Buildroot] [PATCH v2] package: add libfcgi fast cgi library.

[Thomas Petazzoni]

Hello,

Le Fri, 14 Oct 2011 09:59:51 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :

> From: Rico Bachmann <bachmann@tofwerk.com>
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> ---
> Changes v2: corrected indentation of Config.in, removed redundant
> arguments of AUTOTARGETS.

I guess you did something wrong, because none of these things are part
of this new patch :-)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Arnout Vandecappelle]

From: Rico Bachmann <bachmann@tofwerk.com>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
---
Changes v3: now actually included the changes v2 (forgot the
-a to git commit :-)

Changes v2: corrected indentation of Config.in, removed redundant
arguments of AUTOTARGETS.
---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    5 +++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk

diff --git a/package/Config.in b/package/Config.in
index 7dc8887..76c89c7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
new file mode 100644
index 0000000..b31f06b
--- /dev/null
+++ b/package/libfcgi/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBFCGI
+	bool "libfcgi"
+	help
+	  FCGI, a fastcgi developer library for C/C++
+	  http://www.fastcgi.com/
diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
new file mode 100644
index 0000000..4625165
--- /dev/null
+++ b/package/libfcgi/libfcgi.mk
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS))
-- 
1.7.7

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Rico Bachmann]

Ping

Can this patch be commited?
Or is there something to do first?

e.g. rename to fcgi to avoid the LIBFCGI_SOURCE makro?

Am 14.10.2011, 11:16 Uhr, schrieb Arnout Vandecappelle (Essensium/Mind)  
<arnout@mind.be>:

> From: Rico Bachmann <bachmann@tofwerk.com>
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)  
> <arnout@mind.be>
> Signed-off-by: Rico Bachmann  
> <bachmann@tofwerk.com>
> ---
> Changes v3: now actually included the changes v2 (forgot the
> -a to git commit :-)
>
> Changes v2: corrected indentation of Config.in, removed redundant
> arguments of AUTOTARGETS.
> ---
>  package/Config.in          |    1 +
>  package/libfcgi/Config.in  |    5 +++++
>  package/libfcgi/libfcgi.mk |   12 ++++++++++++
>  3 files changed, 18 insertions(+), 0 deletions(-)
>  create mode 100644 package/libfcgi/Config.in
>  create mode 100644 package/libfcgi/libfcgi.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 7dc8887..76c89c7 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
>  source "package/libcurl/Config.in"
>  source "package/libdnet/Config.in"
>  source "package/libeXosip2/Config.in"
> +source "package/libfcgi/Config.in"
>  source "package/libidn/Config.in"
>  source "package/libmicrohttpd/Config.in"
>  source "package/neon/Config.in"
> diff --git a/package/libfcgi/Config.in b/package/libfcgi/Config.in
> new file mode 100644
> index 0000000..b31f06b
> --- /dev/null
> +++ b/package/libfcgi/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_LIBFCGI
> +	bool "libfcgi"
> +	help
> +	  FCGI, a fastcgi developer library for C/C++
> +	  http://www.fastcgi.com/
> diff --git a/package/libfcgi/libfcgi.mk b/package/libfcgi/libfcgi.mk
> new file mode 100644
> index 0000000..4625165
> --- /dev/null
> +++ b/package/libfcgi/libfcgi.mk
> @@ -0,0 +1,12 @@
> +##############################################################################
> +#
> +# libfcgi
> +#
> +##############################################################################
> +LIBFCGI_VERSION = 2.4.0
> +LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
> +LIBFCGI_SITE = http://www.fastcgi.com/dist
> +LIBFCGI_INSTALL_STAGING = YES
> +LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
> +
> +$(eval $(call AUTOTARGETS))

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Arnout Vandecappelle]

On Wednesday 25 April 2012 12:24:04 Rico Bachmann wrote:
> Ping
> 
> Can this patch be commited?
> Or is there something to do first?
> 
> e.g. rename to fcgi to avoid the LIBFCGI_SOURCE makro?
> 
> Am 14.10.2011, 11:16 Uhr, schrieb Arnout Vandecappelle (Essensium/Mind)  

 Since this is so long ago, it's better to repost the patch.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> From: Rico Bachmann <bachmann@tofwerk.com>
 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Arnout> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>

Committed, thanks both.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Rico Bachmann]

Hi together

I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3
I had some problems while building libfcgi with gcc 4.5.3!
There was an error: EOF is undefined.

This issue is already known on the libfcgi mailinglist:
http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

I will add this patch to buildroot asap.

Is there in BR a nice possibility to use a patch from a package only
when gcc >=4.4.X?

And how do I have to handle the patch because its written by Markus from
the libfcgi mailing list and not by myself?

Regards Rico

> -----Urspr?ngliche Nachricht-----
> Von: Peter Korsgaard [mailto:jacmet at gmail.com] Im Auftrag von Peter
> Korsgaard
> Gesendet: Sonntag, 29. April 2012 20:38
> An: Arnout Vandecappelle (Essensium/Mind)
> Cc: buildroot at busybox.net; Rico Bachmann
> Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.
> 
> >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)
> <arnout@mind.be> writes:
> 
>  Arnout> From: Rico Bachmann <bachmann@tofwerk.com>  Arnout> Signed-
> off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>  Arnout>
> Signed-off-by: Rico Bachmann <bachmann@tofwerk.com>
> 
> Committed, thanks both.
> 
> --
> Bye, Peter Korsgaard

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Rico Bachmann]

Am 30.04.2012, 16:13 Uhr, schrieb Rico Bachmann  
<bachmann@tofwerk.com>:

> Hi together
>
> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3
> I had some problems while building libfcgi with gcc 4.5.3!
> There was an error: EOF is undefined.
>
> This issue is already known on the libfcgi mailinglist:
> http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof
>
> I will add this patch to buildroot asap.
>
> Is there in BR a nice possibility to use a patch from a package only
> when gcc >=4.4.X?

if BR2_GCC_VERSION_4_4_X | BR2_GCC_VERSION_4_3_X
	LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
endif

maybe something like that?

>
> And how do I have to handle the patch because its written by Markus from
> the libfcgi mailing list and not by myself?
>
> Regards Rico
>
>> -----Urspr?ngliche Nachricht-----
>> Von: Peter Korsgaard  
>> [mailto:jacmet at gmail.com] Im Auftrag von  
>> Peter
>> Korsgaard
>> Gesendet: Sonntag, 29. April 2012 20:38
>> An: Arnout Vandecappelle (Essensium/Mind)
>> Cc: buildroot at busybox.net; Rico Bachmann
>> Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.
>>
>> >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)
>> <arnout@mind.be> writes:
>>
>>  Arnout> From: Rico Bachmann  
>> <bachmann@tofwerk.com>  Arnout> Signed-
>> off-by: Arnout Vandecappelle (Essensium/Mind)  
>> <arnout@mind.be>  Arnout>
>> Signed-off-by: Rico Bachmann  
>> <bachmann@tofwerk.com>
>>
>> Committed, thanks both.
>>
>> --
>> Bye, Peter Korsgaard
>
> Mit freundlichen Gr?ssen
>
> Tofwerk AG, Rico Bachmann
>
> +41 33 511 11 69
> bachmann at tofwerk.com
> http://www.tofwerk.com
> Uttigenstrasse 22
> CH - 3600 Thun

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Rico Bachmann]

Am 30.04.2012, 16:23 Uhr, schrieb Rico Bachmann  
<bachmann@tofwerk.com>:

> Am 30.04.2012, 16:13 Uhr, schrieb Rico Bachmann  
> <bachmann@tofwerk.com>:
>
>> Hi together
>>
>> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3
>> I had some problems while building libfcgi with gcc 4.5.3!
>> There was an error: EOF is undefined.
>>
>> This issue is already known on the libfcgi mailinglist:
>> http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof
>>
>> I will add this patch to buildroot asap.
>>
>> Is there in BR a nice possibility to use a patch from a package only
>> when gcc >=4.4.X?
>
> if BR2_GCC_VERSION_4_4_X | BR2_GCC_VERSION_4_3_X
> 	LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
> endif

I made some mistakes while thinking about this problem...
if it is possible that way then it should be something like this:

if !BR2_GCC_VERSION_4_3_X
  	LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
endif

>
> maybe something like that?
>
>>
>> And how do I have to handle the patch because its written by Markus from
>> the libfcgi mailing list and not by myself?
>>
>> Regards Rico
>>
>>> -----Urspr?ngliche Nachricht-----
>>> Von: Peter Korsgaard  
>>> [mailto:jacmet at gmail.com] Im Auftrag von  
>>> Peter
>>> Korsgaard
>>> Gesendet: Sonntag, 29. April 2012 20:38
>>> An: Arnout Vandecappelle (Essensium/Mind)
>>> Cc: buildroot at busybox.net; Rico Bachmann
>>> Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.
>>>
>>> >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)
>>> <arnout@mind.be> writes:
>>>
>>>  Arnout> From: Rico Bachmann  
>>> <bachmann@tofwerk.com>  Arnout> Signed-
>>> off-by: Arnout Vandecappelle (Essensium/Mind)  
>>> <arnout@mind.be>  Arnout>
>>> Signed-off-by: Rico Bachmann  
>>> <bachmann@tofwerk.com>
>>>
>>> Committed, thanks both.
>>>
>>> --
>>> Bye, Peter Korsgaard
>>
>> Mit freundlichen Gr?ssen
>>
>> Tofwerk AG, Rico Bachmann
>>
>> +41 33 511 11 69
>> bachmann at tofwerk.com
>> http://www.tofwerk.com
>> Uttigenstrasse 22
>> CH - 3600 Thun
>
> Mit freundlichen Gr?ssen
>
> Tofwerk AG, Rico Bachmann
>
> +41 33 511 11 69
> bachmann at tofwerk.com
> http://www.tofwerk.com
> Uttigenstrasse 22
> CH - 3600 Thun

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Peter Korsgaard]

>>>>> "Rico" == Rico Bachmann <bachmann@tofwerk.com> writes:

 Rico> Hi together
 Rico> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3
 Rico> I had some problems while building libfcgi with gcc 4.5.3!
 Rico> There was an error: EOF is undefined.

Ahh, yes - I only tested with a precompiled 4.3.x toolchain.

 Rico> This issue is already known on the libfcgi mailinglist:
 Rico> http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

 Rico> I will add this patch to buildroot asap.

 Rico> Is there in BR a nice possibility to use a patch from a package only
 Rico> when gcc >=4.4.X?

No, but there's no reason to not add it for older toolchains as well.

 Rico> And how do I have to handle the patch because its written by
 Rico> Markus from the libfcgi mailing list and not by myself?

Keep his authorship (git-style patch has this in the header), but with
your signed-off-by.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] package: add libfcgi fast cgi library.

[Rico Bachmann]

Am 30.04.2012, 19:11 Uhr, schrieb Peter Korsgaard  
<jacmet@uclibc.org>:

>>>>>> "Rico" == Rico Bachmann  
>>>>>> <bachmann@tofwerk.com> writes:
>
>  Rico> Hi together
>  Rico> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3
>  Rico> I had some problems while building libfcgi with gcc 4.5.3!
>  Rico> There was an error: EOF is undefined.
>
> Ahh, yes - I only tested with a precompiled 4.3.x toolchain.

I've got the same situation, first I've just tested with the precompiled  
toolchain.

>
>  Rico> This issue is already known on the libfcgi mailinglist:
>  Rico>  
> http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof
>
>  Rico> I will add this patch to buildroot asap.
>
>  Rico> Is there in BR a nice possibility to use a patch from a package  
> only
>  Rico> when gcc >=4.4.X?
>
> No, but there's no reason to not add it for older toolchains as well.
>
>  Rico> And how do I have to handle the patch because its written by
>  Rico> Markus from the libfcgi mailing list and not by myself?
>
> Keep his authorship (git-style patch has this in the header), but with
> your signed-off-by.
>

Thanks for the information.
I will add the patch this way.

Regards
Rico