[PATCH] netfilter: nf_conntrack_proto_gre: only create ct assured event once

[PATCH] netfilter: nf_conntrack_proto_gre: only create ct assured event once

[Florian Westphal]

GRE connections cause ctnetlink event flood due to ASSURED event
being created for every packet received.

Reported-and-tested-by: Denys Fedoryshchenko <denys@visp.net.lb>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/netfilter/nf_conntrack_proto_gre.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netfilter/nf_conntrack_proto_gre.c b/net/netfilter/nf_conntrack_proto_gre.c
index cf616e5..d69facd 100644
--- a/net/netfilter/nf_conntrack_proto_gre.c
+++ b/net/netfilter/nf_conntrack_proto_gre.c
@@ -241,8 +241,8 @@ static int gre_packet(struct nf_conn *ct,
 		nf_ct_refresh_acct(ct, ctinfo, skb,
 				   ct->proto.gre.stream_timeout);
 		/* Also, more likely to be important, and not a probe. */
-		set_bit(IPS_ASSURED_BIT, &ct->status);
-		nf_conntrack_event_cache(IPCT_ASSURED, ct);
+		if (!test_and_set_bit(IPS_ASSURED_BIT, &ct->status))
+			nf_conntrack_event_cache(IPCT_ASSURED, ct);
 	} else
 		nf_ct_refresh_acct(ct, ctinfo, skb,
 				   ct->proto.gre.timeout);
-- 
1.7.3.4

Re: [PATCH] netfilter: nf_conntrack_proto_gre: only create ct assured event once

[Pablo Neira Ayuso]

On Fri, Sep 30, 2011 at 04:38:29PM +0200, Florian Westphal wrote:
> GRE connections cause ctnetlink event flood due to ASSURED event
> being created for every packet received.
> 
> Reported-and-tested-by: Denys Fedoryshchenko <denys@visp.net.lb>
> Signed-off-by: Florian Westphal <fw@strlen.de>

http://1984.lsi.us.es/git/?p=net/.git;a=shortlog;h=refs/heads/nf

Applied to my nf branch, thanks.