All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: quilt-dev@nongnu.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, John Kacur <jkacur@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail
Date: Wed, 05 Oct 2011 03:48:26 +0200	[thread overview]
Message-ID: <1317779312.1662.37.camel@schurl.linbit> (raw)
In-Reply-To: <1317753468.18063.19.camel@gandalf.stny.rr.com>

On Tue, 2011-10-04 at 14:37 -0400, Steven Rostedt wrote:
> On Tue, 2011-10-04 at 11:26 -0700, Greg KH wrote:
> 
> > > What are git's "split" subject: lines?
> > 
> > Do the following:
> >  $ git show --pretty=email 21d17dd2a377ba894f26989915eb3c6e427a3656
> > 
> > and look at how the Subject line is formatted:
> > 	Subject: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and
> > 	 WM8753_RADC
> > 
> > Which is legal for email subject lines.  But quilt can't handle this and
> > ends up thinking the data after the Subject: line is part of the patch
> > text body and messes stuff up when doing 'quilt mail' later.

Aah, all this email parsing code is so ugly.  I think it works now
though.

> > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > line as a valid email address name, but I've been living with that one
> > for years...

That's not even valid in email addresses.  The proper way would be to
double-quote the "display name" which probably contains the comma, but
then quilt's edmail script still won't understand it.  Is this a real
problem?

Andreas


  reply	other threads:[~2011-10-05  1:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 17:46 [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail Steven Rostedt
2011-10-04 18:02 ` Greg KH
2011-10-04 18:09   ` H. Peter Anvin
2011-10-04 18:18     ` Steven Rostedt
2011-10-04 18:18     ` Greg KH
2011-10-04 19:38     ` Steven Rostedt
2011-10-04 19:41       ` H. Peter Anvin
2011-10-04 19:48         ` Steven Rostedt
     [not found]           ` <1317769149.1662.28.camel@schurl.linbit>
2011-10-10 15:35             ` Steven Rostedt
2011-10-10 15:37               ` [Quilt-dev] " Josh Boyer
2011-10-11  2:39               ` Andreas Gruenbacher
2011-10-04 18:15   ` Steven Rostedt
2011-10-04 18:26     ` Greg KH
2011-10-04 18:37       ` Steven Rostedt
2011-10-05  1:48         ` Andreas Gruenbacher [this message]
2011-10-05  6:53           ` [Quilt-dev] " Greg KH
2011-10-05  8:23             ` Andreas Gruenbacher
2011-10-05 11:21             ` Andreas Gruenbacher
2011-10-05 20:12               ` Greg KH
2011-10-05 20:18                 ` Josh Boyer
2011-10-04 18:59 ` Peter Zijlstra
2011-10-04 19:11   ` Steven Rostedt
2011-10-04 19:20   ` Valdis.Kletnieks
2011-10-04 19:35     ` Steven Rostedt
2011-10-06 10:27 ` [RFC][PATCH v2][QUILT] Add Peter Zijlstra
2011-10-06 17:26   ` Andrew Morton
2011-10-06 17:57     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317779312.1662.37.camel@schurl.linbit \
    --to=andreas.gruenbacher@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quilt-dev@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.