From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: quilt-dev@nongnu.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>, John Kacur <jkacur@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail
Date: Wed, 05 Oct 2011 10:23:49 +0200 [thread overview]
Message-ID: <1317803067.1623.4.camel@schurl.linbit> (raw)
In-Reply-To: <20111005065309.GA6676@suse.de>
On Tue, 2011-10-04 at 23:53 -0700, Greg KH wrote:
> "now" meaning which version of quilt? I still see this on 0.48 if that
> matters.
In the repository (master branch).
> > > > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > > > line as a valid email address name, but I've been living with that one
> > > > for years...
> >
> > That's not even valid in email addresses. The proper way would be to
> > double-quote the "display name" which probably contains the comma, but
> > then quilt's edmail script still won't understand it. Is this a real
> > problem?
>
> Yes, quoting is the correct thing to do, but that does not usually
> happen in "Signed-off-by:" lines in kernel patches.
>
> Actually, I think this is even a problem when the name is quoted
> properly, I've had to fix that up in patches by hand.
Yes, proper quoting currently isn't enough.
> And yes, this is a problem, I run into at least 1-2 patches per stable
> kernel release with this issue. I looked into fixing it and somehow the
> email parsing logic was wierd and I couldn't figure out how to resolve
> it.
Okay, I'll have another look ...
Andreas
next prev parent reply other threads:[~2011-10-05 8:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 17:46 [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail Steven Rostedt
2011-10-04 18:02 ` Greg KH
2011-10-04 18:09 ` H. Peter Anvin
2011-10-04 18:18 ` Steven Rostedt
2011-10-04 18:18 ` Greg KH
2011-10-04 19:38 ` Steven Rostedt
2011-10-04 19:41 ` H. Peter Anvin
2011-10-04 19:48 ` Steven Rostedt
[not found] ` <1317769149.1662.28.camel@schurl.linbit>
2011-10-10 15:35 ` Steven Rostedt
2011-10-10 15:37 ` [Quilt-dev] " Josh Boyer
2011-10-11 2:39 ` Andreas Gruenbacher
2011-10-04 18:15 ` Steven Rostedt
2011-10-04 18:26 ` Greg KH
2011-10-04 18:37 ` Steven Rostedt
2011-10-05 1:48 ` [Quilt-dev] " Andreas Gruenbacher
2011-10-05 6:53 ` Greg KH
2011-10-05 8:23 ` Andreas Gruenbacher [this message]
2011-10-05 11:21 ` Andreas Gruenbacher
2011-10-05 20:12 ` Greg KH
2011-10-05 20:18 ` Josh Boyer
2011-10-04 18:59 ` Peter Zijlstra
2011-10-04 19:11 ` Steven Rostedt
2011-10-04 19:20 ` Valdis.Kletnieks
2011-10-04 19:35 ` Steven Rostedt
2011-10-06 10:27 ` [RFC][PATCH v2][QUILT] Add Peter Zijlstra
2011-10-06 17:26 ` Andrew Morton
2011-10-06 17:57 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317803067.1623.4.camel@schurl.linbit \
--to=andreas.gruenbacher@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quilt-dev@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.