Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

[Thomas Meyer]

Hi,

as far as I understand everything under os-Linux should be OS specific 
and shouldn't rely on kernel functions.

@Richard: What do you think about this patch?

See: https://marc.info/?l=linux-kernel&m=149337493432407&w=2

with kind regards
thomas

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

[Thomas Meyer]

[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]


> Am 17.05.2017 um 03:52 schrieb Masami Hiramatsu <mhiramat@kernel.org>:
> 
> Hi Thomas,

Hi,

> 
> On Tue, 16 May 2017 17:46:47 +0200
> Thomas Meyer <thomas@m3y3r.de> wrote:
> 
>> Hi,
>> 
>> as far as I understand everything under os-Linux should be OS specific 
>> and shouldn't rely on kernel functions.
> 
> I see, but umid.c already uses many printk()s. So that policy
> is not so clear now. For example, without this series,

Yes you are right. I did write nonsense!

I'm fine with all patches in series. Looks good to me!

> 
> $ grep printk -rw arch/um/os-Linux/ | wc -l
> 159
> 
> Thank you,
> 
>> 
>> @Richard: What do you think about this patch?
>> 
>> See: https://marc.info/?l=linux-kernel&m=149337493432407&w=2
>> 
>> with kind regards
>> thomas
> 
> 
> -- 
> Masami Hiramatsu <mhiramat@kernel.org>

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5334 bytes --]

[-- Attachment #2: Type: text/plain, Size: 202 bytes --]

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

[-- Attachment #3: Type: text/plain, Size: 194 bytes --]

_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [RFC PATCH 1/7] um: Use printk instead of printf in make_uml_dir

[Richard Weinberger]

On Wed, May 17, 2017 at 10:35 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
>> On Tue, 16 May 2017 17:46:47 +0200
>> Thomas Meyer <thomas@m3y3r.de> wrote:
>>
>>> Hi,
>>>
>>> as far as I understand everything under os-Linux should be OS specific
>>> and shouldn't rely on kernel functions.
>>
>> I see, but umid.c already uses many printk()s. So that policy
>> is not so clear now. For example, without this series,
>
> Yes you are right. I did write nonsense!
>
> I'm fine with all patches in series. Looks good to me!

Yeah, the policy is not so clear.
In theory os-Linux should contain no kernel stuff, but the printk()s do not
hurt, in most cases.

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel