All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins
@ 2011-10-19 16:46 ` Igor Grinberg
  0 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-10-19 16:46 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel, Igor Grinberg

OMAP pin mux configuration API has been used incorrectly resulting
in wrong mux mode set for several DSS pins.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
 arch/arm/mach-omap2/board-cm-t35.c |   32 ++++++++++++++++++--------------
 1 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index 3201c9e..023b768 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -600,24 +600,28 @@ static void __init cm_t3x_common_dss_mux_init(int mux_mode)
 
 static void __init cm_t35_init_mux(void)
 {
-	omap_mux_init_signal("gpio_70", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_71", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_72", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_73", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_74", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_75", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
+	int mux_mode = OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT;
+
+	omap_mux_init_signal("dss_data0.dss_data0", mux_mode);
+	omap_mux_init_signal("dss_data1.dss_data1", mux_mode);
+	omap_mux_init_signal("dss_data2.dss_data2", mux_mode);
+	omap_mux_init_signal("dss_data3.dss_data3", mux_mode);
+	omap_mux_init_signal("dss_data4.dss_data4", mux_mode);
+	omap_mux_init_signal("dss_data5.dss_data5", mux_mode);
+	cm_t3x_common_dss_mux_init(mux_mode);
 }
 
 static void __init cm_t3730_init_mux(void)
 {
-	omap_mux_init_signal("sys_boot0", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot1", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot3", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot4", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot5", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot6", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
+	int mux_mode = OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT;
+
+	omap_mux_init_signal("sys_boot0", mux_mode);
+	omap_mux_init_signal("sys_boot1", mux_mode);
+	omap_mux_init_signal("sys_boot3", mux_mode);
+	omap_mux_init_signal("sys_boot4", mux_mode);
+	omap_mux_init_signal("sys_boot5", mux_mode);
+	omap_mux_init_signal("sys_boot6", mux_mode);
+	cm_t3x_common_dss_mux_init(mux_mode);
 }
 #else
 static inline void cm_t35_init_mux(void) {}
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins
@ 2011-10-19 16:46 ` Igor Grinberg
  0 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-10-19 16:46 UTC (permalink / raw)
  To: linux-arm-kernel

OMAP pin mux configuration API has been used incorrectly resulting
in wrong mux mode set for several DSS pins.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
 arch/arm/mach-omap2/board-cm-t35.c |   32 ++++++++++++++++++--------------
 1 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
index 3201c9e..023b768 100644
--- a/arch/arm/mach-omap2/board-cm-t35.c
+++ b/arch/arm/mach-omap2/board-cm-t35.c
@@ -600,24 +600,28 @@ static void __init cm_t3x_common_dss_mux_init(int mux_mode)
 
 static void __init cm_t35_init_mux(void)
 {
-	omap_mux_init_signal("gpio_70", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_71", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_72", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_73", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_74", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("gpio_75", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
-	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
+	int mux_mode = OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT;
+
+	omap_mux_init_signal("dss_data0.dss_data0", mux_mode);
+	omap_mux_init_signal("dss_data1.dss_data1", mux_mode);
+	omap_mux_init_signal("dss_data2.dss_data2", mux_mode);
+	omap_mux_init_signal("dss_data3.dss_data3", mux_mode);
+	omap_mux_init_signal("dss_data4.dss_data4", mux_mode);
+	omap_mux_init_signal("dss_data5.dss_data5", mux_mode);
+	cm_t3x_common_dss_mux_init(mux_mode);
 }
 
 static void __init cm_t3730_init_mux(void)
 {
-	omap_mux_init_signal("sys_boot0", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot1", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot3", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot4", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot5", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	omap_mux_init_signal("sys_boot6", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
-	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
+	int mux_mode = OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT;
+
+	omap_mux_init_signal("sys_boot0", mux_mode);
+	omap_mux_init_signal("sys_boot1", mux_mode);
+	omap_mux_init_signal("sys_boot3", mux_mode);
+	omap_mux_init_signal("sys_boot4", mux_mode);
+	omap_mux_init_signal("sys_boot5", mux_mode);
+	omap_mux_init_signal("sys_boot6", mux_mode);
+	cm_t3x_common_dss_mux_init(mux_mode);
 }
 #else
 static inline void cm_t35_init_mux(void) {}
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins
  2011-10-19 16:46 ` Igor Grinberg
@ 2011-11-06  9:25   ` Igor Grinberg
  -1 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-11-06  9:25 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Igor Grinberg, linux-omap, linux-arm-kernel

Hi Tony,

This one is stand alone and can be applied to fixes.
I will re spin the rest in a couple of hours.

Thanks

On 10/19/11 18:46, Igor Grinberg wrote:
> OMAP pin mux configuration API has been used incorrectly resulting
> in wrong mux mode set for several DSS pins.
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>  arch/arm/mach-omap2/board-cm-t35.c |   32 ++++++++++++++++++--------------
>  1 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
> index 3201c9e..023b768 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -600,24 +600,28 @@ static void __init cm_t3x_common_dss_mux_init(int mux_mode)
>  
>  static void __init cm_t35_init_mux(void)
>  {
> -	omap_mux_init_signal("gpio_70", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_71", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_72", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_73", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_74", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_75", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> +	int mux_mode = OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT;
> +
> +	omap_mux_init_signal("dss_data0.dss_data0", mux_mode);
> +	omap_mux_init_signal("dss_data1.dss_data1", mux_mode);
> +	omap_mux_init_signal("dss_data2.dss_data2", mux_mode);
> +	omap_mux_init_signal("dss_data3.dss_data3", mux_mode);
> +	omap_mux_init_signal("dss_data4.dss_data4", mux_mode);
> +	omap_mux_init_signal("dss_data5.dss_data5", mux_mode);
> +	cm_t3x_common_dss_mux_init(mux_mode);
>  }
>  
>  static void __init cm_t3730_init_mux(void)
>  {
> -	omap_mux_init_signal("sys_boot0", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot1", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot3", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot4", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot5", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot6", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> +	int mux_mode = OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT;
> +
> +	omap_mux_init_signal("sys_boot0", mux_mode);
> +	omap_mux_init_signal("sys_boot1", mux_mode);
> +	omap_mux_init_signal("sys_boot3", mux_mode);
> +	omap_mux_init_signal("sys_boot4", mux_mode);
> +	omap_mux_init_signal("sys_boot5", mux_mode);
> +	omap_mux_init_signal("sys_boot6", mux_mode);
> +	cm_t3x_common_dss_mux_init(mux_mode);
>  }
>  #else
>  static inline void cm_t35_init_mux(void) {}

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins
@ 2011-11-06  9:25   ` Igor Grinberg
  0 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2011-11-06  9:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Tony,

This one is stand alone and can be applied to fixes.
I will re spin the rest in a couple of hours.

Thanks

On 10/19/11 18:46, Igor Grinberg wrote:
> OMAP pin mux configuration API has been used incorrectly resulting
> in wrong mux mode set for several DSS pins.
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>  arch/arm/mach-omap2/board-cm-t35.c |   32 ++++++++++++++++++--------------
>  1 files changed, 18 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
> index 3201c9e..023b768 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -600,24 +600,28 @@ static void __init cm_t3x_common_dss_mux_init(int mux_mode)
>  
>  static void __init cm_t35_init_mux(void)
>  {
> -	omap_mux_init_signal("gpio_70", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_71", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_72", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_73", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_74", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("gpio_75", OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> -	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT);
> +	int mux_mode = OMAP_MUX_MODE0 | OMAP_PIN_OUTPUT;
> +
> +	omap_mux_init_signal("dss_data0.dss_data0", mux_mode);
> +	omap_mux_init_signal("dss_data1.dss_data1", mux_mode);
> +	omap_mux_init_signal("dss_data2.dss_data2", mux_mode);
> +	omap_mux_init_signal("dss_data3.dss_data3", mux_mode);
> +	omap_mux_init_signal("dss_data4.dss_data4", mux_mode);
> +	omap_mux_init_signal("dss_data5.dss_data5", mux_mode);
> +	cm_t3x_common_dss_mux_init(mux_mode);
>  }
>  
>  static void __init cm_t3730_init_mux(void)
>  {
> -	omap_mux_init_signal("sys_boot0", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot1", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot3", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot4", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot5", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	omap_mux_init_signal("sys_boot6", OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> -	cm_t3x_common_dss_mux_init(OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT);
> +	int mux_mode = OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT;
> +
> +	omap_mux_init_signal("sys_boot0", mux_mode);
> +	omap_mux_init_signal("sys_boot1", mux_mode);
> +	omap_mux_init_signal("sys_boot3", mux_mode);
> +	omap_mux_init_signal("sys_boot4", mux_mode);
> +	omap_mux_init_signal("sys_boot5", mux_mode);
> +	omap_mux_init_signal("sys_boot6", mux_mode);
> +	cm_t3x_common_dss_mux_init(mux_mode);
>  }
>  #else
>  static inline void cm_t35_init_mux(void) {}

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-06  9:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-19 16:46 [PATCH] ARM: OMAP3: cm-t35: fix mux mode for DSS pins Igor Grinberg
2011-10-19 16:46 ` Igor Grinberg
2011-11-06  9:25 ` Igor Grinberg
2011-11-06  9:25   ` Igor Grinberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.