* [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
@ 2011-10-21 2:33 Shawn Guo
2011-10-21 7:22 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2011-10-21 2:33 UTC (permalink / raw)
To: linux-arm-kernel
It adds missing include of asm/exception.h for avic.c to fix the
compile error below.
arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
?asm? or ?__attribute__? before ?avic_handle_irq?
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
Arnd,
I hit this error when building imx6q on your for-next branch.
arch/arm/plat-mxc/avic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-mxc/avic.c b/arch/arm/plat-mxc/avic.c
index 8875fb4..3157691 100644
--- a/arch/arm/plat-mxc/avic.c
+++ b/arch/arm/plat-mxc/avic.c
@@ -21,6 +21,7 @@
#include <linux/irq.h>
#include <linux/io.h>
#include <mach/common.h>
+#include <asm/exception.h>
#include <asm/mach/irq.h>
#include <mach/hardware.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
2011-10-21 2:33 [PATCH] arm/imx: add missing include of asm/exception.h for avic.c Shawn Guo
@ 2011-10-21 7:22 ` Uwe Kleine-König
2011-10-21 16:38 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2011-10-21 7:22 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Fri, Oct 21, 2011 at 10:33:00AM +0800, Shawn Guo wrote:
> It adds missing include of asm/exception.h for avic.c to fix the
> compile error below.
>
> arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
> ?asm? or ?__attribute__? before ?avic_handle_irq?
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Arnd already posted a patch for that[1], but this one looks better.
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
[1] http://mid.gmane.org/1928841.IC5oQhqc6l at wuerfel
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
2011-10-21 7:22 ` Uwe Kleine-König
@ 2011-10-21 16:38 ` Arnd Bergmann
2011-10-21 18:07 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2011-10-21 16:38 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 21 October 2011 09:22:19 Uwe Kleine-K?nig wrote:
>
> On Fri, Oct 21, 2011 at 10:33:00AM +0800, Shawn Guo wrote:
> > It adds missing include of asm/exception.h for avic.c to fix the
> > compile error below.
> >
> > arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
> > ?asm? or ?__attribute__? before ?avic_handle_irq?
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Arnd already posted a patch for that[1], but this one looks better.
>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Ok, thanks!
I found the same problem in plat-mxc/tzic.c as well now.
Which branch should we apply the patch to? The header file was
introduced in rmk's smp branch, but the usage was introduced in
the imx/multi-irq branch.
Should I merge the smp branch into imx/multi-irq and fix up the
breakage in the merge commit?
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
2011-10-21 16:38 ` Arnd Bergmann
@ 2011-10-21 18:07 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2011-10-21 18:07 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 21, 2011 at 06:38:32PM +0200, Arnd Bergmann wrote:
> On Friday 21 October 2011 09:22:19 Uwe Kleine-K?nig wrote:
> >
> > On Fri, Oct 21, 2011 at 10:33:00AM +0800, Shawn Guo wrote:
> > > It adds missing include of asm/exception.h for avic.c to fix the
> > > compile error below.
> > >
> > > arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
> > > ?asm? or ?__attribute__? before ?avic_handle_irq?
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Arnd already posted a patch for that[1], but this one looks better.
> >
> > Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>
> Ok, thanks!
>
> I found the same problem in plat-mxc/tzic.c as well now.
>
> Which branch should we apply the patch to? The header file was
> introduced in rmk's smp branch, but the usage was introduced in
> the imx/multi-irq branch.
>
> Should I merge the smp branch into imx/multi-irq and fix up the
> breakage in the merge commit?
Ok, this one is already found. Putting it into the merge commit sounds
good.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-21 18:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-21 2:33 [PATCH] arm/imx: add missing include of asm/exception.h for avic.c Shawn Guo
2011-10-21 7:22 ` Uwe Kleine-König
2011-10-21 16:38 ` Arnd Bergmann
2011-10-21 18:07 ` Sascha Hauer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.