All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian
@ 2011-10-21  5:02 Khem Raj
  2011-10-21  5:02 ` [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location Khem Raj
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Khem Raj @ 2011-10-21  5:02 UTC (permalink / raw)
  To: openembedded-core

PN for binutils-cross-canadian is
binutils-cross-canadian-${TRANSLATED_TARGET_ARCH}
so thats what we should use for PREFERRED_VERSION

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/distro/include/tcmode-default.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index 86562be..2bf1beb 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -45,7 +45,7 @@ PREFERRED_VERSION_libgcc-nativesdk ?= "${SDKGCCVERSION}"
 PREFERRED_VERSION_binutils ?= "${BINUVERSION}"
 PREFERRED_VERSION_binutils-cross ?= "${BINUVERSION}"
 PREFERRED_VERSION_binutils-crosssdk ?= "${BINUVERSION}"
-PREFERRED_VERSION_binutils-cross-canadian ?= "${BINUVERSION}"
+PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${BINUVERSION}"
 PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
 PREFERRED_VERSION_linux-libc-headers-nativesdk ?= "${LINUXLIBCVERSION}"
 PREFERRED_VERSION_eglibc                   ?= "${EGLIBCVERSION}"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location
  2011-10-21  5:02 [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Khem Raj
@ 2011-10-21  5:02 ` Khem Raj
  2011-10-21  5:02 ` [PATCH 3/3] gcc-configure-sdk: " Khem Raj
  2011-10-26 20:19 ` [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Saul Wold
  2 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2011-10-21  5:02 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../binutils/binutils-cross-canadian.inc           |    2 +-
 .../binutils/binutils-cross-canadian_2.21.1a.bb    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
index 95e535a..b1cee67 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
@@ -5,7 +5,7 @@ PN = "binutils-cross-canadian-${TRANSLATED_TARGET_ARCH}"
 BPN = "binutils"
 
 DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk"
-EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
+EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                 --program-prefix=${TARGET_PREFIX} \
                 --disable-werror"
 
diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1a.bb b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1a.bb
index e91e7dc..a49aded 100644
--- a/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1a.bb
+++ b/meta/recipes-devtools/binutils/binutils-cross-canadian_2.21.1a.bb
@@ -1,3 +1,3 @@
 require binutils_${PV}.bb
 require binutils-cross-canadian.inc
-PR = "r1"
+PR = "r2"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-21  5:02 [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Khem Raj
  2011-10-21  5:02 ` [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location Khem Raj
@ 2011-10-21  5:02 ` Khem Raj
  2011-10-21  5:12   ` James Limbouris
  2011-10-26 20:19 ` [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Saul Wold
  2 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2011-10-21  5:02 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
index de80870..98fd4c1 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
@@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-uclibceabi", "no", "", d )}'
 EXTRA_OECONF_PATHS = "--with-local-prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
                       --with-gxx-include-dir=${target_includedir}/c++ \
                       --with-build-time-tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
-                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
+                      --with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
                       --with-build-sysroot=${STAGING_DIR_TARGET}"
 
 #
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-21  5:02 ` [PATCH 3/3] gcc-configure-sdk: " Khem Raj
@ 2011-10-21  5:12   ` James Limbouris
  2011-10-21  5:16     ` Khem Raj
  0 siblings, 1 reply; 10+ messages in thread
From: James Limbouris @ 2011-10-21  5:12 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: Friday, 21 October 2011 1:03 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> location
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-
> devtools/gcc/gcc-configure-sdk.inc
> index de80870..98fd4c1 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-
> uclibceabi", "no", "", d )}'
>  EXTRA_OECONF_PATHS = "--with-local-
> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
>                        --with-gxx-include-dir=${target_includedir}/c++ \
>                        --with-build-time-
> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
> +                      --with-
> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
> ${TARGET_OS} \
>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
> 
>  #
> --
> 1.7.5.4
> 

Shouldn't --with-local-prefix be changed too? I am testing with both ${TARGET_SYS}'s replaced. Will post results shortly.

James




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-21  5:12   ` James Limbouris
@ 2011-10-21  5:16     ` Khem Raj
  2011-10-21  5:23       ` James Limbouris
  0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2011-10-21  5:16 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
<james@digitalmatter.com.au> wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Khem Raj
>> Sent: Friday, 21 October 2011 1:03 PM
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
>> location
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-
>> devtools/gcc/gcc-configure-sdk.inc
>> index de80870..98fd4c1 100644
>> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
>> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-
>> uclibceabi", "no", "", d )}'
>>  EXTRA_OECONF_PATHS = "--with-local-
>> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
>>                        --with-gxx-include-dir=${target_includedir}/c++ \
>>                        --with-build-time-
>> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
>> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
>> +                      --with-
>> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
>> ${TARGET_OS} \
>>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
>>
>>  #
>> --
>> 1.7.5.4
>>
>
> Shouldn't --with-local-prefix be changed too? I am testing with both ${TARGET_SYS}'s replaced. Will post results shortly.

yes I think both places it should change

>
> James
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-21  5:16     ` Khem Raj
@ 2011-10-21  5:23       ` James Limbouris
  2011-10-26 20:54         ` Richard Purdie
  0 siblings, 1 reply; 10+ messages in thread
From: James Limbouris @ 2011-10-21  5:23 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: Friday, 21 October 2011 1:16 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> location
> 
> On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
> <james@digitalmatter.com.au> wrote:
> >> -----Original Message-----
> >> From: openembedded-core-bounces@lists.openembedded.org
> >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of
> >> Khem Raj
> >> Sent: Friday, 21 October 2011 1:03 PM
> >> To: openembedded-core@lists.openembedded.org
> >> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> >> location
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-
> >> devtools/gcc/gcc-configure-sdk.inc
> >> index de80870..98fd4c1 100644
> >> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> >> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> >> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-
> >> uclibceabi", "no", "", d )}'
> >>  EXTRA_OECONF_PATHS = "--with-local-
> >> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
> >>                        --with-gxx-include-dir=${target_includedir}/c++ \
> >>                        --with-build-time-
> >> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
> >> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
> >> +                      --with-
> >> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
> >> ${TARGET_OS} \
> >>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
> >>
> >>  #
> >> --
> >> 1.7.5.4
> >>
> >
> > Shouldn't --with-local-prefix be changed too? I am testing with both
> ${TARGET_SYS}'s replaced. Will post results shortly.
> 
> yes I think both places it should change
> 

Ok, I've tested with both changed, and the corresponding binutils patch, and both Qt and kernel compiles are working.

Thanks,
James


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian
  2011-10-21  5:02 [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Khem Raj
  2011-10-21  5:02 ` [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location Khem Raj
  2011-10-21  5:02 ` [PATCH 3/3] gcc-configure-sdk: " Khem Raj
@ 2011-10-26 20:19 ` Saul Wold
  2 siblings, 0 replies; 10+ messages in thread
From: Saul Wold @ 2011-10-26 20:19 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On 10/21/2011 07:02 AM, Khem Raj wrote:
> PN for binutils-cross-canadian is
> binutils-cross-canadian-${TRANSLATED_TARGET_ARCH}
> so thats what we should use for PREFERRED_VERSION
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
> ---
>   meta/conf/distro/include/tcmode-default.inc |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
> index 86562be..2bf1beb 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -45,7 +45,7 @@ PREFERRED_VERSION_libgcc-nativesdk ?= "${SDKGCCVERSION}"
>   PREFERRED_VERSION_binutils ?= "${BINUVERSION}"
>   PREFERRED_VERSION_binutils-cross ?= "${BINUVERSION}"
>   PREFERRED_VERSION_binutils-crosssdk ?= "${BINUVERSION}"
> -PREFERRED_VERSION_binutils-cross-canadian ?= "${BINUVERSION}"
> +PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${BINUVERSION}"
>   PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
>   PREFERRED_VERSION_linux-libc-headers-nativesdk ?= "${LINUXLIBCVERSION}"
>   PREFERRED_VERSION_eglibc                   ?= "${EGLIBCVERSION}"

Merged all 3 of these with the V2 of the GCC patch

Thanks
	Sau!



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-21  5:23       ` James Limbouris
@ 2011-10-26 20:54         ` Richard Purdie
  2011-10-27  3:52           ` James Limbouris
  0 siblings, 1 reply; 10+ messages in thread
From: Richard Purdie @ 2011-10-26 20:54 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Fri, 2011-10-21 at 05:23 +0000, James Limbouris wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Khem Raj
> > Sent: Friday, 21 October 2011 1:16 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> > location
> > 
> > On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
> > <james@digitalmatter.com.au> wrote:
> > >> -----Original Message-----
> > >> From: openembedded-core-bounces@lists.openembedded.org
> > >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of
> > >> Khem Raj
> > >> Sent: Friday, 21 October 2011 1:03 PM
> > >> To: openembedded-core@lists.openembedded.org
> > >> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> > >> location
> > >>
> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > >> ---
> > >>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
> > >>  1 files changed, 1 insertions(+), 1 deletions(-)
> > >>
> > >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-
> > >> devtools/gcc/gcc-configure-sdk.inc
> > >> index de80870..98fd4c1 100644
> > >> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > >> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > >> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-
> > >> uclibceabi", "no", "", d )}'
> > >>  EXTRA_OECONF_PATHS = "--with-local-
> > >> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
> > >>                        --with-gxx-include-dir=${target_includedir}/c++ \
> > >>                        --with-build-time-
> > >> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
> > >> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
> > >> +                      --with-
> > >> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
> > >> ${TARGET_OS} \
> > >>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
> > >>
> > >>  #
> > >> --
> > >> 1.7.5.4
> > >>
> > >
> > > Shouldn't --with-local-prefix be changed too? I am testing with both
> > ${TARGET_SYS}'s replaced. Will post results shortly.
> > 
> > yes I think both places it should change
> > 
> 
> Ok, I've tested with both changed, and the corresponding binutils patch, and both Qt and kernel compiles are working.

I took these patches but I would like to stress that we shouldn't need
to rely on the hardcoded path in the compiler, it should be picking up
any alternative sysroot paths from the environment. If this isn't
happening, we should be figuring out why not. This change therefore
hides issues and does not fix the problem entirely :(.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-26 20:54         ` Richard Purdie
@ 2011-10-27  3:52           ` James Limbouris
  2011-10-27  4:11             ` Tom Rini
  0 siblings, 1 reply; 10+ messages in thread
From: James Limbouris @ 2011-10-27  3:52 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Thursday, 27 October 2011 4:54 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> location
> 
> On Fri, 2011-10-21 at 05:23 +0000, James Limbouris wrote:
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org
> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of
> > > Khem Raj
> > > Sent: Friday, 21 October 2011 1:16 PM
> > > To: Patches and discussions about the oe-core layer
> > > Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to
> correct
> > > location
> > >
> > > On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
> > > <james@digitalmatter.com.au> wrote:
> > > >> -----Original Message-----
> > > >> From: openembedded-core-bounces@lists.openembedded.org
> > > >> [mailto:openembedded-core-bounces@lists.openembedded.org] On
> Behalf
> > > Of
> > > >> Khem Raj
> > > >> Sent: Friday, 21 October 2011 1:03 PM
> > > >> To: openembedded-core@lists.openembedded.org
> > > >> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to
> correct
> > > >> location
> > > >>
> > > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > >> ---
> > > >>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
> > > >>  1 files changed, 1 insertions(+), 1 deletions(-)
> > > >>
> > > >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> b/meta/recipes-
> > > >> devtools/gcc/gcc-configure-sdk.inc
> > > >> index de80870..98fd4c1 100644
> > > >> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > > >> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > > >> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS",
> "linux-
> > > >> uclibceabi", "no", "", d )}'
> > > >>  EXTRA_OECONF_PATHS = "--with-local-
> > > >> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
> > > >>                        --with-gxx-include-dir=${target_includedir}/c++ \
> > > >>                        --with-build-time-
> > > >> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
> > > >> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
> > > >> +                      --with-
> > > >> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
> > > >> ${TARGET_OS} \
> > > >>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
> > > >>
> > > >>  #
> > > >> --
> > > >> 1.7.5.4
> > > >>
> > > >
> > > > Shouldn't --with-local-prefix be changed too? I am testing with both
> > > ${TARGET_SYS}'s replaced. Will post results shortly.
> > >
> > > yes I think both places it should change
> > >
> >
> > Ok, I've tested with both changed, and the corresponding binutils patch, and
> both Qt and kernel compiles are working.
> 
> I took these patches but I would like to stress that we shouldn't need
> to rely on the hardcoded path in the compiler, it should be picking up
> any alternative sysroot paths from the environment. If this isn't
> happening, we should be figuring out why not. This change therefore
> hides issues and does not fix the problem entirely :(.
> 
> Cheers,
> 
> Richard

I'm not sure there was a problem apart from the hardcoded paths being wrong - in the use cases this fixed, the environment setup script was not being sourced.

James




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
  2011-10-27  3:52           ` James Limbouris
@ 2011-10-27  4:11             ` Tom Rini
  0 siblings, 0 replies; 10+ messages in thread
From: Tom Rini @ 2011-10-27  4:11 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, Oct 26, 2011 at 8:52 PM, James Limbouris
<james@digitalmatter.com.au> wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Richard Purdie
>> Sent: Thursday, 27 October 2011 4:54 AM
>> To: Patches and discussions about the oe-core layer
>> Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
>> location
>>
>> On Fri, 2011-10-21 at 05:23 +0000, James Limbouris wrote:
>> > > -----Original Message-----
>> > > From: openembedded-core-bounces@lists.openembedded.org
>> > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
>> Of
>> > > Khem Raj
>> > > Sent: Friday, 21 October 2011 1:16 PM
>> > > To: Patches and discussions about the oe-core layer
>> > > Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to
>> correct
>> > > location
>> > >
>> > > On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
>> > > <james@digitalmatter.com.au> wrote:
>> > > >> -----Original Message-----
>> > > >> From: openembedded-core-bounces@lists.openembedded.org
>> > > >> [mailto:openembedded-core-bounces@lists.openembedded.org] On
>> Behalf
>> > > Of
>> > > >> Khem Raj
>> > > >> Sent: Friday, 21 October 2011 1:03 PM
>> > > >> To: openembedded-core@lists.openembedded.org
>> > > >> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to
>> correct
>> > > >> location
>> > > >>
>> > > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > > >> ---
>> > > >>  meta/recipes-devtools/gcc/gcc-configure-sdk.inc |    2 +-
>> > > >>  1 files changed, 1 insertions(+), 1 deletions(-)
>> > > >>
>> > > >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
>> b/meta/recipes-
>> > > >> devtools/gcc/gcc-configure-sdk.inc
>> > > >> index de80870..98fd4c1 100644
>> > > >> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
>> > > >> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
>> > > >> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS",
>> "linux-
>> > > >> uclibceabi", "no", "", d )}'
>> > > >>  EXTRA_OECONF_PATHS = "--with-local-
>> > > >> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
>> > > >>                        --with-gxx-include-dir=${target_includedir}/c++ \
>> > > >>                        --with-build-time-
>> > > >> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
>> > > >> -                      --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
>> > > >> +                      --with-
>> > > >> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
>> > > >> ${TARGET_OS} \
>> > > >>                        --with-build-sysroot=${STAGING_DIR_TARGET}"
>> > > >>
>> > > >>  #
>> > > >> --
>> > > >> 1.7.5.4
>> > > >>
>> > > >
>> > > > Shouldn't --with-local-prefix be changed too? I am testing with both
>> > > ${TARGET_SYS}'s replaced. Will post results shortly.
>> > >
>> > > yes I think both places it should change
>> > >
>> >
>> > Ok, I've tested with both changed, and the corresponding binutils patch, and
>> both Qt and kernel compiles are working.
>>
>> I took these patches but I would like to stress that we shouldn't need
>> to rely on the hardcoded path in the compiler, it should be picking up
>> any alternative sysroot paths from the environment. If this isn't
>> happening, we should be figuring out why not. This change therefore
>> hides issues and does not fix the problem entirely :(.
>>
>> Cheers,
>>
>> Richard
>
> I'm not sure there was a problem apart from the hardcoded paths being wrong - in the use cases this fixed, the environment setup script was not being sourced.

... except for u-boot / kernel which ignore such advice from the
environment, often with reason.

-- 
Tom



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2011-10-27  4:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-21  5:02 [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Khem Raj
2011-10-21  5:02 ` [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location Khem Raj
2011-10-21  5:02 ` [PATCH 3/3] gcc-configure-sdk: " Khem Raj
2011-10-21  5:12   ` James Limbouris
2011-10-21  5:16     ` Khem Raj
2011-10-21  5:23       ` James Limbouris
2011-10-26 20:54         ` Richard Purdie
2011-10-27  3:52           ` James Limbouris
2011-10-27  4:11             ` Tom Rini
2011-10-26 20:19 ` [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Saul Wold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.