* [PATCH] Give coreutils a chance to build the df utility
@ 2011-10-25 1:18 Julian Pidancet
2011-10-26 1:59 ` McClintock Matthew-B29882
0 siblings, 1 reply; 4+ messages in thread
From: Julian Pidancet @ 2011-10-25 1:18 UTC (permalink / raw)
To: openembedded-core; +Cc: Julian Pidancet
The coreutils configure script is unable determine how to get free
space from the Operating System when cross-compiling. This patch
gives it some extra help by setting the fu_cv_sys_stat_statfs2_bsize
variable to yes before invoking the configure script.
Signed-off-by: Julian Pidancet <julian.pidancet@gmail.com>
---
meta/recipes-core/coreutils/coreutils_8.14.bb | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.14.bb b/meta/recipes-core/coreutils/coreutils_8.14.bb
index f3b7af7..3c75ddf 100644
--- a/meta/recipes-core/coreutils/coreutils_8.14.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.14.bb
@@ -27,7 +27,7 @@ bindir_progs = "base64 basename chcon cksum comm csplit cut dir dircolors dirnam
join link logname md5sum mkfifo mktemp nice nl nohup nproc od paste pathchk \
pinky pr printenv printf ptx readlink runcon seq sha1sum sha224sum sha256sum \
sha384sum sha512sum shred shuf sort split stat stdbuf sum tac tail tee test timeout\
- tr truncate tsort tty unexpand uniq unlink uptime users vdir wc who whoami yes"
+ tr truncate tsort tty unexpand uniq unlink uptime users vdir wc who whoami yes df"
# hostname gets a special treatment and is not included in this
base_bindir_progs = "cat chgrp chmod chown cp date dd echo false kill ln ls mkdir \
@@ -35,6 +35,10 @@ base_bindir_progs = "cat chgrp chmod chown cp date dd echo false kill ln ls mkdi
sbindir_progs= "chroot"
+do_configure_prepend () {
+ export fu_cv_sys_stat_statfs2_bsize=yes
+}
+
do_install_append() {
for i in ${bindir_progs}; do mv ${D}${bindir}/$i ${D}${bindir}/$i.${PN}; done
--
Julian Pidancet
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Give coreutils a chance to build the df utility
2011-10-25 1:18 [PATCH] Give coreutils a chance to build the df utility Julian Pidancet
@ 2011-10-26 1:59 ` McClintock Matthew-B29882
2011-10-26 13:58 ` Julian Pidancet
0 siblings, 1 reply; 4+ messages in thread
From: McClintock Matthew-B29882 @ 2011-10-26 1:59 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Julian Pidancet
On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet
<julian.pidancet@gmail.com> wrote:
> +do_configure_prepend () {
> + export fu_cv_sys_stat_statfs2_bsize=yes
I'm asking out of curiosity.. why don't these go in meta/site/common instead?
-M
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Give coreutils a chance to build the df utility
2011-10-26 1:59 ` McClintock Matthew-B29882
@ 2011-10-26 13:58 ` Julian Pidancet
2011-10-26 14:01 ` Phil Blundell
0 siblings, 1 reply; 4+ messages in thread
From: Julian Pidancet @ 2011-10-26 13:58 UTC (permalink / raw)
To: McClintock Matthew-B29882; +Cc: Patches and discussions about the oe-core layer
On Wed, Oct 26, 2011 at 2:59 AM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet
> <julian.pidancet@gmail.com> wrote:
>> +do_configure_prepend () {
>> + export fu_cv_sys_stat_statfs2_bsize=yes
>
> I'm asking out of curiosity.. why don't these go in meta/site/common instead?
To be honest, I ignored the very existence of this file. Is this
globally applied to all the recipes ? Isn't there a risk of breaking
other packages by doing this ?
--
Julian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Give coreutils a chance to build the df utility
2011-10-26 13:58 ` Julian Pidancet
@ 2011-10-26 14:01 ` Phil Blundell
0 siblings, 0 replies; 4+ messages in thread
From: Phil Blundell @ 2011-10-26 14:01 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: McClintock Matthew-B29882
On Wed, 2011-10-26 at 14:58 +0100, Julian Pidancet wrote:
> On Wed, Oct 26, 2011 at 2:59 AM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
> > On Mon, Oct 24, 2011 at 8:18 PM, Julian Pidancet
> > <julian.pidancet@gmail.com> wrote:
> >> +do_configure_prepend () {
> >> + export fu_cv_sys_stat_statfs2_bsize=yes
> >
> > I'm asking out of curiosity.. why don't these go in meta/site/common instead?
>
> To be honest, I ignored the very existence of this file. Is this
> globally applied to all the recipes ? Isn't there a risk of breaking
> other packages by doing this ?
A small risk, yes. On the other hand, by hardcoding one particular
value in the recipe, there is a risk that it might be the wrong answer
for some target systems. Whereas the site files are, intentionally,
target and OS specific.
p.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-26 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-25 1:18 [PATCH] Give coreutils a chance to build the df utility Julian Pidancet
2011-10-26 1:59 ` McClintock Matthew-B29882
2011-10-26 13:58 ` Julian Pidancet
2011-10-26 14:01 ` Phil Blundell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.