[RFC] ath9k: validate for non-zero BSSID

[RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>

before concluding that the recieved beacon is for us, let us make sure
that the BSSID is non-zero.

Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/recv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index 4c8e296..620230d 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -1824,6 +1824,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
 		hdr = (struct ieee80211_hdr *) (hdr_skb->data + rx_status_len);
 		rxs = IEEE80211_SKB_RXCB(hdr_skb);
 		if (ieee80211_is_beacon(hdr->frame_control) &&
+		    !is_zero_ether_addr(common->curbssid) &&
 		    !compare_ether_addr(hdr->addr3, common->curbssid))
 			rs.is_mybeacon = true;
 		else
-- 
1.7.0.4

[ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>

before concluding that the recieved beacon is for us, let us make sure
that the BSSID is non-zero.

Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/recv.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index 4c8e296..620230d 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -1824,6 +1824,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
 		hdr = (struct ieee80211_hdr *) (hdr_skb->data + rx_status_len);
 		rxs = IEEE80211_SKB_RXCB(hdr_skb);
 		if (ieee80211_is_beacon(hdr->frame_control) &&
+		    !is_zero_ether_addr(common->curbssid) &&
 		    !compare_ether_addr(hdr->addr3, common->curbssid))
 			rs.is_mybeacon = true;
 		else
-- 
1.7.0.4

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Peter Stuge]

Mohammed Shafi Shajakhan wrote:
> before concluding that the recieved beacon is for us, let us make sure
> that the BSSID is non-zero.

Under what circumstances would the BSSID be zero?


//Peter

[ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Peter Stuge]

Mohammed Shafi Shajakhan wrote:
> before concluding that the recieved beacon is for us, let us make sure
> that the BSSID is non-zero.

Under what circumstances would the BSSID be zero?


//Peter

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

Hi Peter,

On Wednesday 30 November 2011 08:06 AM, Peter Stuge wrote:
> Mohammed Shafi Shajakhan wrote:
>> before concluding that the recieved beacon is for us, let us make sure
>> that the BSSID is non-zero.
>
> Under what circumstances would the BSSID be zero?
>
>
> //Peter

unassociated state for station.

but I observed this when i tested ad-hoc mode. I just started an ad-hoc 
mode creator and left it for some time with no one joining. i observed 
there are few frames in rx_tasklet of ath9k driver which seem to be 
beacons and their BSSID is '0', as our curbssid is also '0' they seem to 
be wrongly identified as 'my_beacons'. let me also verify it in STA mode 
and find the effect of this before sending it as a PATCH.
let me also check if it has any effect in ath9k_process_rssi and ath_rx_ps.

-- 
thanks,
shafi

[ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

Hi Peter,

On Wednesday 30 November 2011 08:06 AM, Peter Stuge wrote:
> Mohammed Shafi Shajakhan wrote:
>> before concluding that the recieved beacon is for us, let us make sure
>> that the BSSID is non-zero.
>
> Under what circumstances would the BSSID be zero?
>
>
> //Peter

unassociated state for station.

but I observed this when i tested ad-hoc mode. I just started an ad-hoc 
mode creator and left it for some time with no one joining. i observed 
there are few frames in rx_tasklet of ath9k driver which seem to be 
beacons and their BSSID is '0', as our curbssid is also '0' they seem to 
be wrongly identified as 'my_beacons'. let me also verify it in STA mode 
and find the effect of this before sending it as a PATCH.
let me also check if it has any effect in ath9k_process_rssi and ath_rx_ps.

-- 
thanks,
shafi

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Kalle Valo]

Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:

> unassociated state for station.
>
> but I observed this when i tested ad-hoc mode. I just started an
> ad-hoc mode creator and left it for some time with no one joining. i
> observed there are few frames in rx_tasklet of ath9k driver which seem
> to be beacons and their BSSID is '0', as our curbssid is also '0' they
> seem to be wrongly identified as 'my_beacons'.

This is a perfect addition to the commit log. Remember that the commit
log should especially answer the question "why?".

-- 
Kalle Valo

[ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Kalle Valo]

Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:

> unassociated state for station.
>
> but I observed this when i tested ad-hoc mode. I just started an
> ad-hoc mode creator and left it for some time with no one joining. i
> observed there are few frames in rx_tasklet of ath9k driver which seem
> to be beacons and their BSSID is '0', as our curbssid is also '0' they
> seem to be wrongly identified as 'my_beacons'.

This is a perfect addition to the commit log. Remember that the commit
log should especially answer the question "why?".

-- 
Kalle Valo

Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

On Wednesday 30 November 2011 12:17 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>  writes:
>
>> unassociated state for station.
>>
>> but I observed this when i tested ad-hoc mode. I just started an
>> ad-hoc mode creator and left it for some time with no one joining. i
>> observed there are few frames in rx_tasklet of ath9k driver which seem
>> to be beacons and their BSSID is '0', as our curbssid is also '0' they
>> seem to be wrongly identified as 'my_beacons'.
>
> This is a perfect addition to the commit log. Remember that the commit
> log should especially answer the question "why?".
>
Kalle, thanks. I will properly test this in STA and IBSS mode, and add 
this commit log.

-- 
thanks,
shafi

[ath9k-devel] [RFC] ath9k: validate for non-zero BSSID

[Mohammed Shafi Shajakhan]

On Wednesday 30 November 2011 12:17 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>  writes:
>
>> unassociated state for station.
>>
>> but I observed this when i tested ad-hoc mode. I just started an
>> ad-hoc mode creator and left it for some time with no one joining. i
>> observed there are few frames in rx_tasklet of ath9k driver which seem
>> to be beacons and their BSSID is '0', as our curbssid is also '0' they
>> seem to be wrongly identified as 'my_beacons'.
>
> This is a perfect addition to the commit log. Remember that the commit
> log should especially answer the question "why?".
>
Kalle, thanks. I will properly test this in STA and IBSS mode, and add 
this commit log.

-- 
thanks,
shafi