All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Dave Jones <davej@redhat.com>, Jan Kara <jack@suse.cz>,
	Andy Isaacson <adi@hexapodia.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Nai Xia <nai.xia@gmail.com>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/11] mm: vmscan: Do not OOM if aborting reclaim to start compaction
Date: Wed, 14 Dec 2011 15:41:26 +0000	[thread overview]
Message-ID: <1323877293-15401-5-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1323877293-15401-1-git-send-email-mgorman@suse.de>

During direct reclaim it is possible that reclaim will be aborted so
that compaction can be attempted to satisfy a high-order allocation. If
this decision is made before any pages are reclaimed, it is possible
that 0 is returned to the page allocator potentially triggering an
OOM. This has not been observed but it is a possibility so this patch
addresses it.

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/vmscan.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index faf88b8..69057b5 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2222,6 +2222,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 	struct zoneref *z;
 	struct zone *zone;
 	unsigned long writeback_threshold;
+	bool should_abort_reclaim;
 
 	get_mems_allowed();
 	delayacct_freepages_start();
@@ -2233,7 +2234,8 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 		sc->nr_scanned = 0;
 		if (!priority)
 			disable_swap_token(sc->mem_cgroup);
-		if (shrink_zones(priority, zonelist, sc))
+		should_abort_reclaim = shrink_zones(priority, zonelist, sc);
+		if (should_abort_reclaim)
 			break;
 
 		/*
@@ -2301,6 +2303,10 @@ out:
 	if (oom_killer_disabled)
 		return 0;
 
+	/* Aborting reclaim to try compaction? don't OOM, then */
+	if (should_abort_reclaim)
+		return 1;
+
 	/* top priority shrink_zones still had more to do? don't OOM, then */
 	if (scanning_global_lru(sc) && !all_unreclaimable(zonelist, sc))
 		return 1;
-- 
1.7.3.4


WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Dave Jones <davej@redhat.com>, Jan Kara <jack@suse.cz>,
	Andy Isaacson <adi@hexapodia.org>,
	Johannes Weiner <jweiner@redhat.com>,
	Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Nai Xia <nai.xia@gmail.com>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/11] mm: vmscan: Do not OOM if aborting reclaim to start compaction
Date: Wed, 14 Dec 2011 15:41:26 +0000	[thread overview]
Message-ID: <1323877293-15401-5-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1323877293-15401-1-git-send-email-mgorman@suse.de>

During direct reclaim it is possible that reclaim will be aborted so
that compaction can be attempted to satisfy a high-order allocation. If
this decision is made before any pages are reclaimed, it is possible
that 0 is returned to the page allocator potentially triggering an
OOM. This has not been observed but it is a possibility so this patch
addresses it.

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/vmscan.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index faf88b8..69057b5 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2222,6 +2222,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 	struct zoneref *z;
 	struct zone *zone;
 	unsigned long writeback_threshold;
+	bool should_abort_reclaim;
 
 	get_mems_allowed();
 	delayacct_freepages_start();
@@ -2233,7 +2234,8 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 		sc->nr_scanned = 0;
 		if (!priority)
 			disable_swap_token(sc->mem_cgroup);
-		if (shrink_zones(priority, zonelist, sc))
+		should_abort_reclaim = shrink_zones(priority, zonelist, sc);
+		if (should_abort_reclaim)
 			break;
 
 		/*
@@ -2301,6 +2303,10 @@ out:
 	if (oom_killer_disabled)
 		return 0;
 
+	/* Aborting reclaim to try compaction? don't OOM, then */
+	if (should_abort_reclaim)
+		return 1;
+
 	/* top priority shrink_zones still had more to do? don't OOM, then */
 	if (scanning_global_lru(sc) && !all_unreclaimable(zonelist, sc))
 		return 1;
-- 
1.7.3.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-12-14 15:41 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 15:41 [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v6 Mel Gorman
2011-12-14 15:41 ` Mel Gorman
2011-12-14 15:41 ` [PATCH 01/11] mm: compaction: Allow compaction to isolate dirty pages Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-14 15:41 ` [PATCH 02/11] mm: compaction: Use synchronous compaction for /proc/sys/vm/compact_memory Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-14 15:41 ` [PATCH 03/11] mm: vmscan: Check if we isolated a compound page during lumpy scan Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-15 23:21   ` Rik van Riel
2011-12-15 23:21     ` Rik van Riel
2011-12-14 15:41 ` Mel Gorman [this message]
2011-12-14 15:41   ` [PATCH 04/11] mm: vmscan: Do not OOM if aborting reclaim to start compaction Mel Gorman
2011-12-15 23:36   ` Rik van Riel
2011-12-15 23:36     ` Rik van Riel
2011-12-14 15:41 ` [PATCH 05/11] mm: compaction: Determine if dirty pages can be migrated without blocking within ->migratepage Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  3:32   ` Rik van Riel
2011-12-16  3:32     ` Rik van Riel
2011-12-16 23:20   ` Andrew Morton
2011-12-16 23:20     ` Andrew Morton
2011-12-17  3:03     ` Nai Xia
2011-12-17  3:03       ` Nai Xia
2011-12-17  3:26       ` Andrew Morton
2011-12-17  3:26         ` Andrew Morton
2011-12-19 11:05     ` Mel Gorman
2011-12-19 11:05       ` Mel Gorman
2011-12-19 13:12       ` nai.xia
2011-12-19 13:12         ` nai.xia
2011-12-14 15:41 ` [PATCH 06/11] mm: compaction: make isolate_lru_page() filter-aware again Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  3:34   ` Rik van Riel
2011-12-16  3:34     ` Rik van Riel
2011-12-18  1:53   ` Minchan Kim
2011-12-18  1:53     ` Minchan Kim
2011-12-14 15:41 ` [PATCH 07/11] mm: page allocator: Do not call direct reclaim for THP allocations while compaction is deferred Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  4:10   ` Rik van Riel
2011-12-16  4:10     ` Rik van Riel
2011-12-14 15:41 ` [PATCH 08/11] mm: compaction: Introduce sync-light migration for use by compaction Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  4:31   ` Rik van Riel
2011-12-16  4:31     ` Rik van Riel
2011-12-18  2:05   ` Minchan Kim
2011-12-18  2:05     ` Minchan Kim
2011-12-19 11:45     ` Mel Gorman
2011-12-19 11:45       ` Mel Gorman
2011-12-20  7:18       ` Minchan Kim
2011-12-20  7:18         ` Minchan Kim
2012-01-13 21:25   ` Andrew Morton
2012-01-13 21:25     ` Andrew Morton
2012-01-16 11:33     ` Mel Gorman
2012-01-16 11:33       ` Mel Gorman
2011-12-14 15:41 ` [PATCH 09/11] mm: vmscan: When reclaiming for compaction, ensure there are sufficient free pages available Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  4:35   ` Rik van Riel
2011-12-16  4:35     ` Rik van Riel
2011-12-14 15:41 ` [PATCH 10/11] mm: vmscan: Check if reclaim should really abort even if compaction_ready() is true for one zone Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  4:38   ` Rik van Riel
2011-12-16  4:38     ` Rik van Riel
2011-12-16 11:29     ` Mel Gorman
2011-12-16 11:29       ` Mel Gorman
2011-12-14 15:41 ` [PATCH 11/11] mm: Isolate pages for immediate reclaim on their own LRU Mel Gorman
2011-12-14 15:41   ` Mel Gorman
2011-12-16  4:47   ` Rik van Riel
2011-12-16  4:47     ` Rik van Riel
2011-12-16 12:26     ` Mel Gorman
2011-12-16 12:26       ` Mel Gorman
2011-12-16 15:17   ` Johannes Weiner
2011-12-16 15:17     ` Johannes Weiner
2011-12-16 16:07     ` Mel Gorman
2011-12-16 16:07       ` Mel Gorman
2011-12-19 16:14       ` Johannes Weiner
2011-12-19 16:14         ` Johannes Weiner
2011-12-17 16:08   ` Minchan Kim
2011-12-17 16:08     ` Minchan Kim
2011-12-19 13:26     ` Mel Gorman
2011-12-19 13:26       ` Mel Gorman
2011-12-20  7:10       ` Minchan Kim
2011-12-20  7:10         ` Minchan Kim
2011-12-20  9:55         ` Mel Gorman
2011-12-20  9:55           ` Mel Gorman
2011-12-23 19:08           ` Hugh Dickins
2011-12-23 19:08             ` Hugh Dickins
2011-12-29 16:59             ` Mel Gorman
2011-12-29 16:59               ` Mel Gorman
2011-12-29 19:31               ` Rik van Riel
2011-12-29 19:31                 ` Rik van Riel
2011-12-30 11:27                 ` Mel Gorman
2011-12-30 11:27                   ` Mel Gorman
2011-12-16 22:56 ` [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v6 Andrew Morton
2011-12-16 22:56   ` Andrew Morton
2011-12-19 14:40   ` Mel Gorman
2011-12-19 14:40     ` Mel Gorman
2011-12-16 23:37 ` Andrew Morton
2011-12-16 23:37   ` Andrew Morton
2011-12-19 14:20   ` Mel Gorman
2011-12-19 14:20     ` Mel Gorman
  -- strict thread matches above, loose matches on Subject: below --
2011-12-01 17:36 [PATCH 0/11] Reduce compaction-related stalls and improve asynchronous migration of dirty pages v5 Mel Gorman
2011-12-01 17:36 ` [PATCH 04/11] mm: vmscan: Do not OOM if aborting reclaim to start compaction Mel Gorman
2011-12-01 17:36   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323877293-15401-5-git-send-email-mgorman@suse.de \
    --to=mgorman@suse.de \
    --cc=aarcange@redhat.com \
    --cc=adi@hexapodia.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=jack@suse.cz \
    --cc=jweiner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=nai.xia@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.