* [RFC 2/2] perf: duct tape a crash on perf kvm --guestmount=$(pwd) report
2011-12-17 13:35 [PATCH 1/2] tools/perf: const.h to perf-tar-src-pkg Sebastian Andrzej Siewior
@ 2011-12-17 13:35 ` Sebastian Andrzej Siewior
2012-01-08 11:50 ` [tip:perf/core] perf tools: Add const. h to MANIFEST to make perf-tar-src-pkg work again tip-bot for Sebastian Andrzej Siewior
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2011-12-17 13:35 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, linux-kernel,
Sebastian Andrzej Siewior
Data was collected with
|perf kvm --guestmount=$(pwd) record -a -R -g -s -d -T
After executing
|kvm --guestmount=$(pwd) report
I ended up with two segfaults. This patch duct tapes both of them.
Most likely there is some infomration missing.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
tools/perf/util/map.c | 2 +-
tools/perf/util/symbol.c | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 316aa0a..a57f897 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -693,7 +693,7 @@ char *machine__mmap_name(struct machine *self, char *bf, size_t size)
else if (machine__is_default_guest(self))
snprintf(bf, size, "[%s]", "guest.kernel.kallsyms");
else
- snprintf(bf, size, "[%s.%d]", "guest.kernel.kallsyms", self->pid);
+ snprintf(bf, size, "[%s.%d]", "guest.kernel.kallsyms", self ? self->pid : -1);
return bf;
}
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index f2dd916..2760ab1 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1876,8 +1876,12 @@ struct map *machine__new_module(struct machine *machine, u64 start,
const char *filename)
{
struct map *map;
- struct dso *dso = __dsos__findnew(&machine->kernel_dsos, filename);
+ struct dso *dso;
+
+ if (!machine)
+ return NULL;
+ dso = __dsos__findnew(&machine->kernel_dsos, filename);
if (dso == NULL)
return NULL;
--
1.7.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [tip:perf/core] perf tools: Add const. h to MANIFEST to make perf-tar-src-pkg work again
2011-12-17 13:35 [PATCH 1/2] tools/perf: const.h to perf-tar-src-pkg Sebastian Andrzej Siewior
2011-12-17 13:35 ` [RFC 2/2] perf: duct tape a crash on perf kvm --guestmount=$(pwd) report Sebastian Andrzej Siewior
@ 2012-01-08 11:50 ` tip-bot for Sebastian Andrzej Siewior
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Sebastian Andrzej Siewior @ 2012-01-08 11:50 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, hpa, mingo, a.p.zijlstra, tglx,
sebastian, mingo
Commit-ID: cc5a91e972212aea022ff86b2c11d3e84d552bf5
Gitweb: http://git.kernel.org/tip/cc5a91e972212aea022ff86b2c11d3e84d552bf5
Author: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
AuthorDate: Sat, 17 Dec 2011 14:35:37 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 6 Jan 2012 15:52:18 -0200
perf tools: Add const.h to MANIFEST to make perf-tar-src-pkg work again
Fixes:
|make: *** No rule to make target `../../include/linux/const.h', needed by `builtin-annotate.o'. Stop.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1324128938-17553-1-git-send-email-sebastian@breakpoint.cc
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/MANIFEST | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
index c12659d..1078c5f 100644
--- a/tools/perf/MANIFEST
+++ b/tools/perf/MANIFEST
@@ -1,4 +1,5 @@
tools/perf
+include/linux/const.h
include/linux/perf_event.h
include/linux/rbtree.h
include/linux/list.h
^ permalink raw reply related [flat|nested] 3+ messages in thread