* [PATCH] clone: don't say <branch> when we mean <remote>
@ 2011-12-21 18:14 Carlos Martín Nieto
2011-12-21 19:25 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Carlos Martín Nieto @ 2011-12-21 18:14 UTC (permalink / raw)
To: git
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
---
The manpage says <name> which might actually be a better word to use
everywhere, but having <branch> instead of <remote> can only lead to
confusion.
Looking through blame, the second line survived a typo fix and was
introduced in 2008 when clone was made a builtin. The script used to
say <name>. So it's clearly nothing urgent, but it bugged me, so I'm
sending a patch.
builtin/clone.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index efe8b6c..e85ee69 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -84,8 +84,8 @@ static struct option builtin_clone_options[] = {
"directory from which templates will be used"),
OPT_CALLBACK(0 , "reference", &option_reference, "repo",
"reference repository", &opt_parse_reference),
- OPT_STRING('o', "origin", &option_origin, "branch",
- "use <branch> instead of 'origin' to track upstream"),
+ OPT_STRING('o', "origin", &option_origin, "remote",
+ "use <remote> instead of 'origin' to track upstream"),
OPT_STRING('b', "branch", &option_branch, "branch",
"checkout <branch> instead of the remote's HEAD"),
OPT_STRING('u', "upload-pack", &option_upload_pack, "path",
--
1.7.8.352.g876a6f
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clone: don't say <branch> when we mean <remote>
2011-12-21 18:14 [PATCH] clone: don't say <branch> when we mean <remote> Carlos Martín Nieto
@ 2011-12-21 19:25 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2011-12-21 19:25 UTC (permalink / raw)
To: Carlos Martín Nieto; +Cc: git
Carlos Martín Nieto <cmn@elego.de> writes:
> Looking through blame, the second line survived a typo fix and was
> introduced in 2008 when clone was made a builtin. The script used to
> say <name>. So it's clearly nothing urgent, but it bugged me, so I'm
> sending a patch.
Thanks.
How I hated these "rewrite in C" now comes back piece by piece, trickling
in. That's the price of progress, I guess.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 18:14 [PATCH] clone: don't say <branch> when we mean <remote> Carlos Martín Nieto
2011-12-21 19:25 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.