* [PATCH 1/1] nfs4_setfacl failed with unexpected messages
@ 2011-12-22 14:49 Steve Dickson
0 siblings, 0 replies; only message in thread
From: Steve Dickson @ 2011-12-22 14:49 UTC (permalink / raw)
To: Linux NFS Mailing list
From: faizan <faizan.husain@in.ibm.com>
When the format of the input file is incorrect nfs4_setfacl
fails with a *** glibc detected *** error.
See: https://bugzilla.redhat.com/show_bug.cgi?id=693422
Signed-off-by: Steve Dickson <steved@redhat.com>
---
libnfs4acl/nfs4_ace_from_string.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/libnfs4acl/nfs4_ace_from_string.c b/libnfs4acl/nfs4_ace_from_string.c
index 510ffee..d26c829 100644
--- a/libnfs4acl/nfs4_ace_from_string.c
+++ b/libnfs4acl/nfs4_ace_from_string.c
@@ -86,9 +86,10 @@ free_fields(char *fields[NUMFIELDS])
{
int i;
- for (i = 0; i < NUMFIELDS; i++)
- if (fields[i] != NULL)
- free(fields[i]);
+ for (i = 0; i < NUMFIELDS; i++) {
+ free(fields[i]);
+ fields[i] = NULL;
+ }
}
int
@@ -107,7 +108,7 @@ parse_alloc_fields(char *buf, char *fields[NUMFIELDS])
count++;
}
if (count != 3)
- goto out_free;
+ return -EINVAL;
for (i = 0; i < NUMFIELDS; i++) {
field = strsep(&buf, ":");
--
1.7.7.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-22 14:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-22 14:49 [PATCH 1/1] nfs4_setfacl failed with unexpected messages Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.