[PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Sachin Kamat]

This patch series adds support for MFC and FIMC on SMDK C110 and V210 boards.
It is based on Kukjin Kim's latest for-next branch.

Sachin Kamat (4):
  ARM: S5PV210: Enable MFC on SMDKV210
  ARM: S5PV210: Enable MFC on SMDKC110
  ARM: S5PV210: Enable FIMC on SMDKV210
  ARM: S5PV210: Enable FIMC on SMDKC110

 arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
 arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
 arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
 3 files changed, 35 insertions(+), 0 deletions(-)

-- 
1.7.4.1

[PATCH 1/4] ARM: S5PV210: Enable MFC on SMDKV210

[Sachin Kamat]

This patch adds MFC support on SMDKV210 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/mach-s5pv210/Kconfig         |    1 +
 arch/arm/mach-s5pv210/mach-smdkv210.c |   10 ++++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 646057a..251491d 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -137,6 +137,7 @@ config MACH_SMDKV210
 	select S3C_DEV_I2C2
 	select S3C_DEV_RTC
 	select S3C_DEV_WDT
+	select S5P_DEV_MFC
 	select SAMSUNG_DEV_ADC
 	select SAMSUNG_DEV_BACKLIGHT
 	select SAMSUNG_DEV_IDE
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
index 8662ef6..d50cacd 100644
--- a/arch/arm/mach-s5pv210/mach-smdkv210.c
+++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
@@ -46,6 +46,7 @@
 #include <plat/s5p-time.h>
 #include <plat/backlight.h>
 #include <plat/regs-fb-v4.h>
+#include <plat/mfc.h>
 
 /* Following are default values for UCON, ULCON and UFCON UART registers */
 #define SMDKV210_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
@@ -225,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = {
 	&s3c_device_rtc,
 	&s3c_device_ts,
 	&s3c_device_wdt,
+	&s5p_device_mfc,
+	&s5p_device_mfc_l,
+	&s5p_device_mfc_r,
 	&s5pv210_device_ac97,
 	&s5pv210_device_iis0,
 	&s5pv210_device_spdif,
@@ -284,6 +288,11 @@ static void __init smdkv210_map_io(void)
 	s5p_set_timer_source(S5P_PWM2, S5P_PWM4);
 }
 
+static void __init smdkv210_reserve(void)
+{
+	s5p_mfc_reserve_mem(0x43000000, 8 << 20, 0x51000000, 8 << 20);
+}
+
 static void __init smdkv210_machine_init(void)
 {
 	s3c_pm_init();
@@ -319,4 +328,5 @@ MACHINE_START(SMDKV210, "SMDKV210")
 	.map_io		= smdkv210_map_io,
 	.init_machine	= smdkv210_machine_init,
 	.timer		= &s5p_timer,
+	.reserve	= &smdkv210_reserve,
 MACHINE_END
-- 
1.7.4.1

[PATCH 2/4] ARM: S5PV210: Enable MFC on SMDKC110

[Sachin Kamat]

This patch adds MFC support on SMDKC110 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/mach-s5pv210/Kconfig         |    1 +
 arch/arm/mach-s5pv210/mach-smdkc110.c |   11 +++++++++++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 251491d..32893c7 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -113,6 +113,7 @@ config MACH_SMDKC110
 	select S3C_DEV_I2C2
 	select S3C_DEV_RTC
 	select S3C_DEV_WDT
+	select S5P_DEV_MFC
 	select SAMSUNG_DEV_IDE
 	select S5PV210_SETUP_I2C1
 	select S5PV210_SETUP_I2C2
diff --git a/arch/arm/mach-s5pv210/mach-smdkc110.c b/arch/arm/mach-s5pv210/mach-smdkc110.c
index f7266bb..0087c7b 100644
--- a/arch/arm/mach-s5pv210/mach-smdkc110.c
+++ b/arch/arm/mach-s5pv210/mach-smdkc110.c
@@ -31,6 +31,7 @@
 #include <plat/iic.h>
 #include <plat/pm.h>
 #include <plat/s5p-time.h>
+#include <plat/mfc.h>
 
 /* Following are default values for UCON, ULCON and UFCON UART registers */
 #define SMDKC110_UCON_DEFAULT	(S3C2410_UCON_TXILEVEL |	\
@@ -92,6 +93,9 @@ static struct platform_device *smdkc110_devices[] __initdata = {
 	&s3c_device_i2c2,
 	&s3c_device_rtc,
 	&s3c_device_wdt,
+	&s5p_device_mfc,
+	&s5p_device_mfc_l,
+	&s5p_device_mfc_r,
 };
 
 static struct i2c_board_info smdkc110_i2c_devs0[] __initdata = {
@@ -115,6 +119,12 @@ static void __init smdkc110_map_io(void)
 	s5p_set_timer_source(S5P_PWM3, S5P_PWM4);
 }
 
+static void __init smdkc110_reserve(void)
+{
+	s5p_mfc_reserve_mem(0x43000000, 8 << 20, 0x51000000, 8 << 20);
+}
+
+
 static void __init smdkc110_machine_init(void)
 {
 	s3c_pm_init();
@@ -141,4 +151,5 @@ MACHINE_START(SMDKC110, "SMDKC110")
 	.map_io		= smdkc110_map_io,
 	.init_machine	= smdkc110_machine_init,
 	.timer		= &s5p_timer,
+	.reserve	= &smdkc110_reserve,
 MACHINE_END
-- 
1.7.4.1

[PATCH 3/4] ARM: S5PV210: Enable FIMC on SMDKV210

[Sachin Kamat]

This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/mach-s5pv210/Kconfig         |    3 +++
 arch/arm/mach-s5pv210/mach-smdkv210.c |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 32893c7..66e1b3d 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -138,6 +138,9 @@ config MACH_SMDKV210
 	select S3C_DEV_I2C2
 	select S3C_DEV_RTC
 	select S3C_DEV_WDT
+	select S5P_DEV_FIMC0
+	select S5P_DEV_FIMC1
+	select S5P_DEV_FIMC2
 	select S5P_DEV_MFC
 	select SAMSUNG_DEV_ADC
 	select SAMSUNG_DEV_BACKLIGHT
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
index d50cacd..038fc5f 100644
--- a/arch/arm/mach-s5pv210/mach-smdkv210.c
+++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
@@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = {
 	&s3c_device_rtc,
 	&s3c_device_ts,
 	&s3c_device_wdt,
+	&s5p_device_fimc0,
+	&s5p_device_fimc1,
+	&s5p_device_fimc2,
 	&s5p_device_mfc,
 	&s5p_device_mfc_l,
 	&s5p_device_mfc_r,
-- 
1.7.4.1

[PATCH 4/4] ARM: S5PV210: Enable FIMC on SMDKC110

[Sachin Kamat]

This patch adds support for FIMC 0, 1 & 2 on SMDKC110 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/mach-s5pv210/Kconfig         |    3 +++
 arch/arm/mach-s5pv210/mach-smdkc110.c |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 66e1b3d..eb31498 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -113,6 +113,9 @@ config MACH_SMDKC110
 	select S3C_DEV_I2C2
 	select S3C_DEV_RTC
 	select S3C_DEV_WDT
+	select S5P_DEV_FIMC0
+	select S5P_DEV_FIMC1
+	select S5P_DEV_FIMC2
 	select S5P_DEV_MFC
 	select SAMSUNG_DEV_IDE
 	select S5PV210_SETUP_I2C1
diff --git a/arch/arm/mach-s5pv210/mach-smdkc110.c b/arch/arm/mach-s5pv210/mach-smdkc110.c
index 0087c7b..59757b6 100644
--- a/arch/arm/mach-s5pv210/mach-smdkc110.c
+++ b/arch/arm/mach-s5pv210/mach-smdkc110.c
@@ -93,6 +93,9 @@ static struct platform_device *smdkc110_devices[] __initdata = {
 	&s3c_device_i2c2,
 	&s3c_device_rtc,
 	&s3c_device_wdt,
+	&s5p_device_fimc0,
+	&s5p_device_fimc1,
+	&s5p_device_fimc2,
 	&s5p_device_mfc,
 	&s5p_device_mfc_l,
 	&s5p_device_mfc_r,
-- 
1.7.4.1

Re: [PATCH 3/4] ARM: S5PV210: Enable FIMC on SMDKV210

[Mark Brown]

On Mon, Dec 26, 2011 at 03:30:12PM +0530, Sachin Kamat wrote:
> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board.

Why does this not also apply to the Aquilla, Gony and Torbreck machines?  

>  	&s3c_device_wdt,
> +	&s5p_device_fimc0,
> +	&s5p_device_fimc1,
> +	&s5p_device_fimc2,
>  	&s5p_device_mfc,

The support consists solely of adding them to the lists of devices,
there's no visible per board hookup here.

Re: [PATCH 3/4] ARM: S5PV210: Enable FIMC on SMDKV210

[Sachin Kamat]

Hi Mark,

Thank you for your review comments.

On 26 December 2011 17:24, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Dec 26, 2011 at 03:30:12PM +0530, Sachin Kamat wrote:
>> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board.
>
> Why does this not also apply to the Aquilla, Gony and Torbreck machines?

FIMC is already enabled in Aquila and Goni machines.
I was not sure if it is required in Torbreck.

>
>>       &s3c_device_wdt,
>> +     &s5p_device_fimc0,
>> +     &s5p_device_fimc1,
>> +     &s5p_device_fimc2,
>>       &s5p_device_mfc,
>
> The support consists solely of adding them to the lists of devices,
> there's no visible per board hookup here.

Yes.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With warm regards,
Sachin

Re: [PATCH 3/4] ARM: S5PV210: Enable FIMC on SMDKV210

[Sylwester Nawrocki]

Hi Sachin,

thanks for the patch.

On 12/26/2011 11:00 AM, Sachin Kamat wrote:
> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/mach-s5pv210/Kconfig         |    3 +++
>  arch/arm/mach-s5pv210/mach-smdkv210.c |    3 +++
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 32893c7..66e1b3d 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -138,6 +138,9 @@ config MACH_SMDKV210
>  	select S3C_DEV_I2C2
>  	select S3C_DEV_RTC
>  	select S3C_DEV_WDT
> +	select S5P_DEV_FIMC0
> +	select S5P_DEV_FIMC1
> +	select S5P_DEV_FIMC2
>  	select S5P_DEV_MFC
>  	select SAMSUNG_DEV_ADC
>  	select SAMSUNG_DEV_BACKLIGHT
> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
> index d50cacd..038fc5f 100644
> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c
> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
> @@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = {
>  	&s3c_device_rtc,
>  	&s3c_device_ts,
>  	&s3c_device_wdt,
> +	&s5p_device_fimc0,
> +	&s5p_device_fimc1,
> +	&s5p_device_fimc2,

Sorry, this won't work, unless you add &s5p_device_fimc_md after all
s5p_fimc_device? entries. s5p_device_fimc_md is a platform device for
FIMC media device driver (/dev/media?), which registers all required
video nodes (mem-to-mem and video capture).
Complete board code for FIMC can be found in Goni (or Nuri) board files.

Does the above really work for you with 3.2-rc7 kernel ?

I've had prepared a patch adding s5p_device_fimc_md for the SMDK boards
that already register FIMC devices, but got distracted by other tasks
and finally I didn't send it for 3.2 :(

BTW, is there anyone interested in s3c64xx (s3c24xx) CAMIF v4l2 driver
in the mainline kernel ? I've started some works on it and could carry on
with that if there is some interest, so we can have something which
is in line with the mainline APIs.

--

Thanks,
Sylwester

Re: [PATCH 3/4] ARM: S5PV210: Enable FIMC on SMDKV210

[Sachin Kamat]

Hi Sylwester,

Thank you for your comments.

I did check Goni code and found that there was  s5p_device_fimc_md device added.
But I could n't find much description about it and also initial
version did not have it enabled, hence I did not include it.
I will re-submit the patch after adding s5p_device_fimc_md in the device list.

Thanks and regards
Sachin


On 26 December 2011 21:57, Sylwester Nawrocki <snjw23@gmail.com> wrote:
> Hi Sachin,
>
> thanks for the patch.
>
> On 12/26/2011 11:00 AM, Sachin Kamat wrote:
>> This patch adds support for FIMC 0, 1 and 2 on SMDKV210 board.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  arch/arm/mach-s5pv210/Kconfig         |    3 +++
>>  arch/arm/mach-s5pv210/mach-smdkv210.c |    3 +++
>>  2 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
>> index 32893c7..66e1b3d 100644
>> --- a/arch/arm/mach-s5pv210/Kconfig
>> +++ b/arch/arm/mach-s5pv210/Kconfig
>> @@ -138,6 +138,9 @@ config MACH_SMDKV210
>>       select S3C_DEV_I2C2
>>       select S3C_DEV_RTC
>>       select S3C_DEV_WDT
>> +     select S5P_DEV_FIMC0
>> +     select S5P_DEV_FIMC1
>> +     select S5P_DEV_FIMC2
>>       select S5P_DEV_MFC
>>       select SAMSUNG_DEV_ADC
>>       select SAMSUNG_DEV_BACKLIGHT
>> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
>> index d50cacd..038fc5f 100644
>> --- a/arch/arm/mach-s5pv210/mach-smdkv210.c
>> +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c
>> @@ -226,6 +226,9 @@ static struct platform_device *smdkv210_devices[] __initdata = {
>>       &s3c_device_rtc,
>>       &s3c_device_ts,
>>       &s3c_device_wdt,
>> +     &s5p_device_fimc0,
>> +     &s5p_device_fimc1,
>> +     &s5p_device_fimc2,
>
> Sorry, this won't work, unless you add &s5p_device_fimc_md after all
> s5p_fimc_device? entries. s5p_device_fimc_md is a platform device for
> FIMC media device driver (/dev/media?), which registers all required
> video nodes (mem-to-mem and video capture).
> Complete board code for FIMC can be found in Goni (or Nuri) board files.
>
> Does the above really work for you with 3.2-rc7 kernel ?
>
> I've had prepared a patch adding s5p_device_fimc_md for the SMDK boards
> that already register FIMC devices, but got distracted by other tasks
> and finally I didn't send it for 3.2 :(
>
> BTW, is there anyone interested in s3c64xx (s3c24xx) CAMIF v4l2 driver
> in the mainline kernel ? I've started some works on it and could carry on
> with that if there is some interest, so we can have something which
> is in line with the mainline APIs.
>
> --
>
> Thanks,
> Sylwester



-- 
With warm regards,
Sachin

Re: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Sachin Kamat]

Hi Kukjin,

Please pick up the MFC patches (patches 1 & 2) from this series. I
will post a separate patch series for FIMC related changes.

Regards
Sachin

On 26 December 2011 15:30, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> This patch series adds support for MFC and FIMC on SMDK C110 and V210 boards.
> It is based on Kukjin Kim's latest for-next branch.
>
> Sachin Kamat (4):
>  ARM: S5PV210: Enable MFC on SMDKV210
>  ARM: S5PV210: Enable MFC on SMDKC110
>  ARM: S5PV210: Enable FIMC on SMDKV210
>  ARM: S5PV210: Enable FIMC on SMDKC110
>
>  arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
>  arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
>  arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
>  3 files changed, 35 insertions(+), 0 deletions(-)
>
> --
> 1.7.4.1
>



-- 
With warm regards,
Sachin

RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Kukjin Kim]

Sachin Kamat wrote:
> 
> Hi Kukjin,
> 
> Please pick up the MFC patches (patches 1 & 2) from this series. I
> will post a separate patch series for FIMC related changes.
> 
(Cc'ed Jeongtae Park)

Jeongtae, let me know your opinion on this MFC enabling patches.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> Regards
> Sachin
> 
> On 26 December 2011 15:30, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > This patch series adds support for MFC and FIMC on SMDK C110 and V210
> boards.
> > It is based on Kukjin Kim's latest for-next branch.
> >
> > Sachin Kamat (4):
> >  ARM: S5PV210: Enable MFC on SMDKV210
> >  ARM: S5PV210: Enable MFC on SMDKC110
> >  ARM: S5PV210: Enable FIMC on SMDKV210
> >  ARM: S5PV210: Enable FIMC on SMDKC110
> >
> >  arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
> >  arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
> >  arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
> >  3 files changed, 35 insertions(+), 0 deletions(-)
> >
> > --
> > 1.7.4.1
> >
> 
> 
> 
> --
> With warm regards,
> Sachin

RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Jeongtae Park]

Hi Sachin,

thanks for the patch.
There is no issue for MFC.

Best regards,
/jtpark

> -----Original Message-----
> From: Kukjin Kim [mailto:kgene.kim@samsung.com]
> Sent: Thursday, December 29, 2011 12:35 PM
> To: 'Sachin Kamat'; linux-samsung-soc@vger.kernel.org
> Cc: jtp.park@samsung.com
> Subject: RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards
> 
> Sachin Kamat wrote:
> >
> > Hi Kukjin,
> >
> > Please pick up the MFC patches (patches 1 & 2) from this series. I
> > will post a separate patch series for FIMC related changes.
> >
> (Cc'ed Jeongtae Park)
> 
> Jeongtae, let me know your opinion on this MFC enabling patches.
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> > Regards
> > Sachin
> >
> > On 26 December 2011 15:30, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > > This patch series adds support for MFC and FIMC on SMDK C110 and V210
> > boards.
> > > It is based on Kukjin Kim's latest for-next branch.
> > >
> > > Sachin Kamat (4):
> > >  ARM: S5PV210: Enable MFC on SMDKV210
> > >  ARM: S5PV210: Enable MFC on SMDKC110
> > >  ARM: S5PV210: Enable FIMC on SMDKV210
> > >  ARM: S5PV210: Enable FIMC on SMDKC110
> > >
> > >  arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
> > >  arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
> > >  arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
> > >  3 files changed, 35 insertions(+), 0 deletions(-)
> > >
> > > --
> > > 1.7.4.1
> > >
> >
> >
> >
> > --
> > With warm regards,
> > Sachin

Re: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Sachin Kamat]

Hi Kukjin,

Ping.



On 10 January 2012 04:48, Jeongtae Park <jtp.park@samsung.com> wrote:
> Hi Sachin,
>
> thanks for the patch.
> There is no issue for MFC.
>
> Best regards,
> /jtpark
>
>> -----Original Message-----
>> From: Kukjin Kim [mailto:kgene.kim@samsung.com]
>> Sent: Thursday, December 29, 2011 12:35 PM
>> To: 'Sachin Kamat'; linux-samsung-soc@vger.kernel.org
>> Cc: jtp.park@samsung.com
>> Subject: RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards
>>
>> Sachin Kamat wrote:
>> >
>> > Hi Kukjin,
>> >
>> > Please pick up the MFC patches (patches 1 & 2) from this series. I
>> > will post a separate patch series for FIMC related changes.
>> >
>> (Cc'ed Jeongtae Park)
>>
>> Jeongtae, let me know your opinion on this MFC enabling patches.
>>
>> Thanks.
>>
>> Best regards,
>> Kgene.
>> --
>> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
>> SW Solution Development Team, Samsung Electronics Co., Ltd.
>>
>> > Regards
>> > Sachin
>> >
>> > On 26 December 2011 15:30, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> > > This patch series adds support for MFC and FIMC on SMDK C110 and V210
>> > boards.
>> > > It is based on Kukjin Kim's latest for-next branch.
>> > >
>> > > Sachin Kamat (4):
>> > >  ARM: S5PV210: Enable MFC on SMDKV210
>> > >  ARM: S5PV210: Enable MFC on SMDKC110
>> > >  ARM: S5PV210: Enable FIMC on SMDKV210
>> > >  ARM: S5PV210: Enable FIMC on SMDKC110
>> > >
>> > >  arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
>> > >  arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
>> > >  arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
>> > >  3 files changed, 35 insertions(+), 0 deletions(-)
>> > >
>> > > --
>> > > 1.7.4.1
>> > >
>> >
>> >
>> >
>> > --
>> > With warm regards,
>> > Sachin
>



-- 
With warm regards,
Sachin

Re: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Kukjin Kim]

On 01/30/12 14:15, Sachin Kamat wrote:
> Hi Kukjin,
>
> Ping.
>
Hi Sachin,

I looked at your reply on Sylwester's comments, PATCH 3/4.
I'd like to apply all of this series after your re-submitting.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

>
> On 10 January 2012 04:48, Jeongtae Park<jtp.park@samsung.com>  wrote:
>> Hi Sachin,
>>
>> thanks for the patch.
>> There is no issue for MFC.
>>
>> Best regards,
>> /jtpark
>>
>>> -----Original Message-----
>>> From: Kukjin Kim [mailto:kgene.kim@samsung.com]
>>> Sent: Thursday, December 29, 2011 12:35 PM
>>> To: 'Sachin Kamat'; linux-samsung-soc@vger.kernel.org
>>> Cc: jtp.park@samsung.com
>>> Subject: RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards
>>>
>>> Sachin Kamat wrote:
>>>>
>>>> Hi Kukjin,
>>>>
>>>> Please pick up the MFC patches (patches 1&  2) from this series. I
>>>> will post a separate patch series for FIMC related changes.
>>>>
>>> (Cc'ed Jeongtae Park)
>>>
>>> Jeongtae, let me know your opinion on this MFC enabling patches.
>>>
>>> Thanks.
>>>
>>> Best regards,
>>> Kgene.
>>> --
>>> Kukjin Kim<kgene.kim@samsung.com>, Senior Engineer,
>>> SW Solution Development Team, Samsung Electronics Co., Ltd.
>>>
>>>> Regards
>>>> Sachin
>>>>
>>>> On 26 December 2011 15:30, Sachin Kamat<sachin.kamat@linaro.org>  wrote:
>>>>> This patch series adds support for MFC and FIMC on SMDK C110 and V210
>>>> boards.
>>>>> It is based on Kukjin Kim's latest for-next branch.
>>>>>
>>>>> Sachin Kamat (4):
>>>>>   ARM: S5PV210: Enable MFC on SMDKV210
>>>>>   ARM: S5PV210: Enable MFC on SMDKC110
>>>>>   ARM: S5PV210: Enable FIMC on SMDKV210
>>>>>   ARM: S5PV210: Enable FIMC on SMDKC110
>>>>>
>>>>>   arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
>>>>>   arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
>>>>>   arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
>>>>>   3 files changed, 35 insertions(+), 0 deletions(-)
>>>>>
>>>>> --
>>>>> 1.7.4.1

Re: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Sachin Kamat]

Hi Kukjin,


On 31 January 2012 09:47, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 01/30/12 14:15, Sachin Kamat wrote:
>>
>> Hi Kukjin,
>>
>> Ping.
>>
> Hi Sachin,
>
> I looked at your reply on Sylwester's comments, PATCH 3/4.
> I'd like to apply all of this series after your re-submitting.


I have already re-submitted patches 3 and 4 incorporating Sylwester's comments.

Please let me know if you want me to send them once again.

Regards
Sachin

>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>>
>> On 10 January 2012 04:48, Jeongtae Park<jtp.park@samsung.com>  wrote:
>>>
>>> Hi Sachin,
>>>
>>> thanks for the patch.
>>> There is no issue for MFC.
>>>
>>> Best regards,
>>> /jtpark
>>>
>>>> -----Original Message-----
>>>> From: Kukjin Kim [mailto:kgene.kim@samsung.com]
>>>> Sent: Thursday, December 29, 2011 12:35 PM
>>>> To: 'Sachin Kamat'; linux-samsung-soc@vger.kernel.org
>>>> Cc: jtp.park@samsung.com
>>>> Subject: RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110
>>>> and V210 boards
>>>>
>>>> Sachin Kamat wrote:
>>>>>
>>>>>
>>>>> Hi Kukjin,
>>>>>
>>>>> Please pick up the MFC patches (patches 1&  2) from this series. I
>>>>>
>>>>> will post a separate patch series for FIMC related changes.
>>>>>
>>>> (Cc'ed Jeongtae Park)
>>>>
>>>> Jeongtae, let me know your opinion on this MFC enabling patches.
>>>>
>>>> Thanks.
>>>>
>>>> Best regards,
>>>> Kgene.
>>>> --
>>>> Kukjin Kim<kgene.kim@samsung.com>, Senior Engineer,
>>>> SW Solution Development Team, Samsung Electronics Co., Ltd.
>>>>
>>>>> Regards
>>>>> Sachin
>>>>>
>>>>> On 26 December 2011 15:30, Sachin Kamat<sachin.kamat@linaro.org>
>>>>>  wrote:
>>>>>>
>>>>>> This patch series adds support for MFC and FIMC on SMDK C110 and V210
>>>>>
>>>>> boards.
>>>>>>
>>>>>> It is based on Kukjin Kim's latest for-next branch.
>>>>>>
>>>>>> Sachin Kamat (4):
>>>>>>  ARM: S5PV210: Enable MFC on SMDKV210
>>>>>>  ARM: S5PV210: Enable MFC on SMDKC110
>>>>>>  ARM: S5PV210: Enable FIMC on SMDKV210
>>>>>>  ARM: S5PV210: Enable FIMC on SMDKC110
>>>>>>
>>>>>>  arch/arm/mach-s5pv210/Kconfig         |    8 ++++++++
>>>>>>  arch/arm/mach-s5pv210/mach-smdkc110.c |   14 ++++++++++++++
>>>>>>  arch/arm/mach-s5pv210/mach-smdkv210.c |   13 +++++++++++++
>>>>>>  3 files changed, 35 insertions(+), 0 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 1.7.4.1



-- 
With warm regards,
Sachin

RE: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Kukjin Kim]

Sachin Kamat wrote:
> 
> Hi Kukjin,
> 
Hi,
> 
> On 31 January 2012 09:47, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > On 01/30/12 14:15, Sachin Kamat wrote:
> >>
> >> Hi Kukjin,
> >>
> >> Ping.
> >>
> > Hi Sachin,
> >
> > I looked at your reply on Sylwester's comments, PATCH 3/4.
> > I'd like to apply all of this series after your re-submitting.
> 
> 
> I have already re-submitted patches 3 and 4 incorporating Sylwester's
> comments.
> 
Would be helpful to me if you could add the mark of version in the re-submit
patch.

> Please let me know if you want me to send them once again.
> 
Yes, please.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH 0/4] ARM: S5PV210: Enable FIMC and MFC on SMDK C110 and V210 boards

[Sachin Kamat]

Hi Kukjin,

On 9 February 2012 18:57, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> Hi Kukjin,
>>
> Hi,
>>
>> On 31 January 2012 09:47, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > On 01/30/12 14:15, Sachin Kamat wrote:
>> >>
>> >> Hi Kukjin,
>> >>
>> >> Ping.
>> >>
>> > Hi Sachin,
>> >
>> > I looked at your reply on Sylwester's comments, PATCH 3/4.
>> > I'd like to apply all of this series after your re-submitting.
>>
>>
>> I have already re-submitted patches 3 and 4 incorporating Sylwester's
>> comments.
>>
> Would be helpful to me if you could add the mark of version in the re-submit
> patch.
>
>> Please let me know if you want me to send them once again.
>>
> Yes, please.


Re-sent the patch series "[PATCH-RESEND 0/4] ARM: S5PV210: Enable FIMC
& MFC on SMDKC110 & V210 boards"
rebased on your next/board-samsung branch.

>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>



-- 
With warm regards,
Sachin