* [PATCH v8 0/2]remove machine specific header file inclusion from driver
@ 2012-01-04 7:17 Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
0 siblings, 2 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: linux-arm-kernel
remove unnecessary inclusion of machine specific header
file from driver which comes in the way of platform code
consolidation.
Manjunath Hadli (2):
davinci: vpif: remove machine specific header file inclusion from the
driver
davinci: CQ93VC: remove machine specific header file inclusion from
codec driver
drivers/media/video/davinci/vpif.h | 2 --
drivers/media/video/davinci/vpif_display.c | 2 --
include/media/davinci/vpif_types.h | 2 ++
sound/soc/codecs/cq93vc.c | 2 --
4 files changed, 2 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
2012-01-04 7:17 [PATCH v8 0/2]remove machine specific header file inclusion from driver Manjunath Hadli
@ 2012-01-04 7:17 ` Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
1 sibling, 0 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: dlos, LAK; +Cc: Manjunath Hadli, Mauro Carvalho Chehab, LMML
remove unnecessary inclusion of machine specific header files mach/dm646x.h,
mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c
driver which comes in the way of platform code consolidation.
Add linux/i2c.h header file in vpif_types.h which is required for
building.
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: LMML <linux-media@vger.kernel.org>
---
drivers/media/video/davinci/vpif.h | 2 --
drivers/media/video/davinci/vpif_display.c | 2 --
include/media/davinci/vpif_types.h | 2 ++
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/davinci/vpif.h b/drivers/media/video/davinci/vpif.h
index 25036cb..8bcac65 100644
--- a/drivers/media/video/davinci/vpif.h
+++ b/drivers/media/video/davinci/vpif.h
@@ -18,8 +18,6 @@
#include <linux/io.h>
#include <linux/videodev2.h>
-#include <mach/hardware.h>
-#include <mach/dm646x.h>
#include <media/davinci/vpif_types.h>
/* Maximum channel allowed */
diff --git a/drivers/media/video/davinci/vpif_display.c b/drivers/media/video/davinci/vpif_display.c
index 286f029..7fa34b4 100644
--- a/drivers/media/video/davinci/vpif_display.c
+++ b/drivers/media/video/davinci/vpif_display.c
@@ -39,8 +39,6 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-chip-ident.h>
-#include <mach/dm646x.h>
-
#include "vpif_display.h"
#include "vpif.h"
diff --git a/include/media/davinci/vpif_types.h b/include/media/davinci/vpif_types.h
index 9929b05..bd8217c 100644
--- a/include/media/davinci/vpif_types.h
+++ b/include/media/davinci/vpif_types.h
@@ -17,6 +17,8 @@
#ifndef _VPIF_TYPES_H
#define _VPIF_TYPES_H
+#include <linux/i2c.h>
+
#define VPIF_CAPTURE_MAX_CHANNELS 2
enum vpif_if_type {
--
1.6.2.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
@ 2012-01-04 7:17 ` Manjunath Hadli
0 siblings, 0 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: linux-arm-kernel
remove unnecessary inclusion of machine specific header files mach/dm646x.h,
mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c
driver which comes in the way of platform code consolidation.
Add linux/i2c.h header file in vpif_types.h which is required for
building.
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: LMML <linux-media@vger.kernel.org>
---
drivers/media/video/davinci/vpif.h | 2 --
drivers/media/video/davinci/vpif_display.c | 2 --
include/media/davinci/vpif_types.h | 2 ++
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/davinci/vpif.h b/drivers/media/video/davinci/vpif.h
index 25036cb..8bcac65 100644
--- a/drivers/media/video/davinci/vpif.h
+++ b/drivers/media/video/davinci/vpif.h
@@ -18,8 +18,6 @@
#include <linux/io.h>
#include <linux/videodev2.h>
-#include <mach/hardware.h>
-#include <mach/dm646x.h>
#include <media/davinci/vpif_types.h>
/* Maximum channel allowed */
diff --git a/drivers/media/video/davinci/vpif_display.c b/drivers/media/video/davinci/vpif_display.c
index 286f029..7fa34b4 100644
--- a/drivers/media/video/davinci/vpif_display.c
+++ b/drivers/media/video/davinci/vpif_display.c
@@ -39,8 +39,6 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-chip-ident.h>
-#include <mach/dm646x.h>
-
#include "vpif_display.h"
#include "vpif.h"
diff --git a/include/media/davinci/vpif_types.h b/include/media/davinci/vpif_types.h
index 9929b05..bd8217c 100644
--- a/include/media/davinci/vpif_types.h
+++ b/include/media/davinci/vpif_types.h
@@ -17,6 +17,8 @@
#ifndef _VPIF_TYPES_H
#define _VPIF_TYPES_H
+#include <linux/i2c.h>
+
#define VPIF_CAPTURE_MAX_CHANNELS 2
enum vpif_if_type {
--
1.6.2.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
2012-01-04 7:17 [PATCH v8 0/2]remove machine specific header file inclusion from driver Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
@ 2012-01-04 7:17 ` Manjunath Hadli
1 sibling, 0 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: dlos, LAK
Cc: Manjunath Hadli, Miguel Aguilar, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
remove unnecessary inclusion of machine specific header
file mach/dm365.h from cq93vc.c voice codec driver
which comes in the way of platform code consolidation.
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
Cc: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.de>
Cc: <alsa-devel@alsa-project.org>
Cc: <linux-kernel@vger.kernel.org>
---
sound/soc/codecs/cq93vc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..ff4eb7a 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -38,8 +38,6 @@
#include <sound/soc.h>
#include <sound/initval.h>
-#include <mach/dm365.h>
-
static inline unsigned int cq93vc_read(struct snd_soc_codec *codec,
unsigned int reg)
{
--
1.6.2.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
@ 2012-01-04 7:17 ` Manjunath Hadli
0 siblings, 0 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: dlos, LAK
Cc: alsa-devel, Takashi Iwai, linux-kernel, Jaroslav Kysela,
Manjunath Hadli, Miguel Aguilar
remove unnecessary inclusion of machine specific header
file mach/dm365.h from cq93vc.c voice codec driver
which comes in the way of platform code consolidation.
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
Cc: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.de>
Cc: <alsa-devel@alsa-project.org>
Cc: <linux-kernel@vger.kernel.org>
---
sound/soc/codecs/cq93vc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..ff4eb7a 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -38,8 +38,6 @@
#include <sound/soc.h>
#include <sound/initval.h>
-#include <mach/dm365.h>
-
static inline unsigned int cq93vc_read(struct snd_soc_codec *codec,
unsigned int reg)
{
--
1.6.2.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
@ 2012-01-04 7:17 ` Manjunath Hadli
0 siblings, 0 replies; 13+ messages in thread
From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw)
To: linux-arm-kernel
remove unnecessary inclusion of machine specific header
file mach/dm365.h from cq93vc.c voice codec driver
which comes in the way of platform code consolidation.
Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: Miguel Aguilar <miguel.aguilar@ridgerun.com>
Cc: Jaroslav Kysela <perex@perex.cz>
CC: Takashi Iwai <tiwai@suse.de>
Cc: <alsa-devel@alsa-project.org>
Cc: <linux-kernel@vger.kernel.org>
---
sound/soc/codecs/cq93vc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cq93vc.c b/sound/soc/codecs/cq93vc.c
index 46dbfd0..ff4eb7a 100644
--- a/sound/soc/codecs/cq93vc.c
+++ b/sound/soc/codecs/cq93vc.c
@@ -38,8 +38,6 @@
#include <sound/soc.h>
#include <sound/initval.h>
-#include <mach/dm365.h>
-
static inline unsigned int cq93vc_read(struct snd_soc_codec *codec,
unsigned int reg)
{
--
1.6.2.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
2012-01-04 7:17 ` Manjunath Hadli
@ 2012-01-04 12:59 ` Sergei Shtylyov
-1 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2012-01-04 12:59 UTC (permalink / raw)
To: Manjunath Hadli; +Cc: dlos, LAK, LMML, Mauro Carvalho Chehab
Hello.
On 04-01-2012 11:17, Manjunath Hadli wrote:
> remove unnecessary inclusion of machine specific header files mach/dm646x.h,
> mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c
> driver which comes in the way of platform code consolidation.
> Add linux/i2c.h header file in vpif_types.h which is required for
> building.
This last modification should be in a separate patch. Don;t mix changes
having the different purpose.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> Cc: Mauro Carvalho Chehab<mchehab@infradead.org>
> Cc: LMML<linux-media@vger.kernel.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
@ 2012-01-04 12:59 ` Sergei Shtylyov
0 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2012-01-04 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 04-01-2012 11:17, Manjunath Hadli wrote:
> remove unnecessary inclusion of machine specific header files mach/dm646x.h,
> mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c
> driver which comes in the way of platform code consolidation.
> Add linux/i2c.h header file in vpif_types.h which is required for
> building.
This last modification should be in a separate patch. Don;t mix changes
having the different purpose.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> Cc: Mauro Carvalho Chehab<mchehab@infradead.org>
> Cc: LMML<linux-media@vger.kernel.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
2012-01-04 12:59 ` Sergei Shtylyov
@ 2012-01-04 14:27 ` Hadli, Manjunath
-1 siblings, 0 replies; 13+ messages in thread
From: Hadli, Manjunath @ 2012-01-04 14:27 UTC (permalink / raw)
To: 'Sergei Shtylyov'; +Cc: dlos, LAK, LMML, Mauro Carvalho Chehab
Sergei,
On Wed, Jan 04, 2012 at 18:29:13, Sergei Shtylyov wrote:
> Hello.
>
> On 04-01-2012 11:17, Manjunath Hadli wrote:
>
> > remove unnecessary inclusion of machine specific header files
> > mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h
> > from vpif_display.c driver which comes in the way of platform code consolidation.
> > Add linux/i2c.h header file in vpif_types.h which is required for
> > building.
>
> This last modification should be in a separate patch. Don;t mix changes having the different purpose.
It is part of the same modification of removing the machine specific header.
When the header file was removed, it needed the i2c to be included due to
a dependency and hence the inclusion.
Thx,
-Manju
>
> > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> > Cc: Mauro Carvalho Chehab<mchehab@infradead.org>
> > Cc: LMML<linux-media@vger.kernel.org>
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver
@ 2012-01-04 14:27 ` Hadli, Manjunath
0 siblings, 0 replies; 13+ messages in thread
From: Hadli, Manjunath @ 2012-01-04 14:27 UTC (permalink / raw)
To: linux-arm-kernel
Sergei,
On Wed, Jan 04, 2012 at 18:29:13, Sergei Shtylyov wrote:
> Hello.
>
> On 04-01-2012 11:17, Manjunath Hadli wrote:
>
> > remove unnecessary inclusion of machine specific header files
> > mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h
> > from vpif_display.c driver which comes in the way of platform code consolidation.
> > Add linux/i2c.h header file in vpif_types.h which is required for
> > building.
>
> This last modification should be in a separate patch. Don;t mix changes having the different purpose.
It is part of the same modification of removing the machine specific header.
When the header file was removed, it needed the i2c to be included due to
a dependency and hence the inclusion.
Thx,
-Manju
>
> > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> > Cc: Mauro Carvalho Chehab<mchehab@infradead.org>
> > Cc: LMML<linux-media@vger.kernel.org>
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
2012-01-04 7:17 ` Manjunath Hadli
(?)
@ 2012-01-07 0:53 ` Mark Brown
-1 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2012-01-07 0:53 UTC (permalink / raw)
To: Manjunath Hadli
Cc: dlos, LAK, alsa-devel, Takashi Iwai, linux-kernel,
Jaroslav Kysela, Miguel Aguilar
On Wed, Jan 04, 2012 at 12:47:49PM +0530, Manjunath Hadli wrote:
> remove unnecessary inclusion of machine specific header
> file mach/dm365.h from cq93vc.c voice codec driver
> which comes in the way of platform code consolidation.
*Always* CC maintainers on patches. If you send me a copy directly this
looks OK.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
@ 2012-01-07 0:53 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2012-01-07 0:53 UTC (permalink / raw)
To: Manjunath Hadli
Cc: dlos, Takashi Iwai, linux-kernel, alsa-devel, Miguel Aguilar, LAK
On Wed, Jan 04, 2012 at 12:47:49PM +0530, Manjunath Hadli wrote:
> remove unnecessary inclusion of machine specific header
> file mach/dm365.h from cq93vc.c voice codec driver
> which comes in the way of platform code consolidation.
*Always* CC maintainers on patches. If you send me a copy directly this
looks OK.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver
@ 2012-01-07 0:53 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2012-01-07 0:53 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 04, 2012 at 12:47:49PM +0530, Manjunath Hadli wrote:
> remove unnecessary inclusion of machine specific header
> file mach/dm365.h from cq93vc.c voice codec driver
> which comes in the way of platform code consolidation.
*Always* CC maintainers on patches. If you send me a copy directly this
looks OK.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-01-07 0:54 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-04 7:17 [PATCH v8 0/2]remove machine specific header file inclusion from driver Manjunath Hadli
2012-01-04 7:17 ` [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
2012-01-04 12:59 ` Sergei Shtylyov
2012-01-04 12:59 ` Sergei Shtylyov
2012-01-04 14:27 ` Hadli, Manjunath
2012-01-04 14:27 ` Hadli, Manjunath
2012-01-04 7:17 ` [PATCH v8 2/2] davinci: CQ93VC: remove machine specific header file inclusion from codec driver Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
2012-01-04 7:17 ` Manjunath Hadli
2012-01-07 0:53 ` Mark Brown
2012-01-07 0:53 ` Mark Brown
2012-01-07 0:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.