All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] prep: Use ISA m48t59
@ 2012-01-13 17:35 Andreas Färber
  2012-01-16 14:37 ` Andreas Färber
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2012-01-13 17:35 UTC (permalink / raw)
  To: qemu-devel
  Cc: Blue Swirl, Hervé Poussineau, Andreas Färber, qemu-ppc,
	Jan Kiszka

This simplifies the code later when the i8259 moves to the i82378
PCI->ISA bridge and happens to fix a SysBus m48t59 io_base issue
introduced by commit 0fb56ffc5edd66f12ccfc0d71af5f9c79c0a2612 (m48t59:
drop obsolete address base arithmetic). Suggested by Hervé and Jan.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Hervé Poussineau <hpoussin@reactos.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>
---
 hw/ppc_prep.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
index dec059a..1cc0ae0 100644
--- a/hw/ppc_prep.c
+++ b/hw/ppc_prep.c
@@ -707,7 +707,7 @@ static void ppc_prep_init (ram_addr_t ram_size,
         usb_ohci_init_pci(pci_bus, -1);
     }
 
-    m48t59 = m48t59_init(i8259[8], 0, 0x0074, NVRAM_SIZE, 59);
+    m48t59 = m48t59_init_isa(isa_bus, 0x0074, NVRAM_SIZE, 59);
     if (m48t59 == NULL)
         return;
     sysctrl->nvram = m48t59;
-- 
1.7.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] prep: Use ISA m48t59
  2012-01-13 17:35 [Qemu-devel] [PATCH] prep: Use ISA m48t59 Andreas Färber
@ 2012-01-16 14:37 ` Andreas Färber
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Färber @ 2012-01-16 14:37 UTC (permalink / raw)
  To: qemu-devel; +Cc: Blue Swirl, qemu-ppc, Hervé Poussineau, Jan Kiszka

Am 13.01.2012 18:35, schrieb Andreas Färber:
> This simplifies the code later when the i8259 moves to the i82378
> PCI->ISA bridge and happens to fix a SysBus m48t59 io_base issue
> introduced by commit 0fb56ffc5edd66f12ccfc0d71af5f9c79c0a2612 (m48t59:
> drop obsolete address base arithmetic). Suggested by Hervé and Jan.
> 
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Cc: Hervé Poussineau <hpoussin@reactos.org>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> ---

Applied to prep-up branch:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up

/-F

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-16 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-13 17:35 [Qemu-devel] [PATCH] prep: Use ISA m48t59 Andreas Färber
2012-01-16 14:37 ` Andreas Färber

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.