All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mips: fix netlogic defconfigs for coverage builds
@ 2012-01-22 20:02 Paul Gortmaker
  2012-01-23 13:32 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2012-01-22 20:02 UTC (permalink / raw)
  To: linux-mips; +Cc: ralf, Paul Gortmaker, Jayachandran C

The toolchain prefix will most likely be site specific and is
not guaranteed to always be "mips-linux-gnu-", so simply don't
specify one.  A quick "git grep" shows this to be consistent
amongst other cross compiled targets.

Similarly, the site specific initramfs source location should not
be used, since that won't exist for most people, and it prevents
them from doing coverage builds on the defconfigs, such as those
done in linux-next and run routinely by many others.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: Jayachandran C <jayachandranc@netlogicmicro.com>

diff --git a/arch/mips/configs/nlm_xlp_defconfig b/arch/mips/configs/nlm_xlp_defconfig
index 4479fd6..28c6b27 100644
--- a/arch/mips/configs/nlm_xlp_defconfig
+++ b/arch/mips/configs/nlm_xlp_defconfig
@@ -8,7 +8,7 @@ CONFIG_HIGH_RES_TIMERS=y
 # CONFIG_SECCOMP is not set
 CONFIG_USE_OF=y
 CONFIG_EXPERIMENTAL=y
-CONFIG_CROSS_COMPILE="mips-linux-gnu-"
+CONFIG_CROSS_COMPILE=""
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
@@ -22,7 +22,7 @@ CONFIG_AUDIT=y
 CONFIG_CGROUPS=y
 CONFIG_NAMESPACES=y
 CONFIG_BLK_DEV_INITRD=y
-CONFIG_INITRAMFS_SOURCE="usr/dev_file_list usr/rootfs.xlp"
+CONFIG_INITRAMFS_SOURCE=""
 CONFIG_RD_BZIP2=y
 CONFIG_RD_LZMA=y
 CONFIG_INITRAMFS_COMPRESSION_LZMA=y
diff --git a/arch/mips/configs/nlm_xlr_defconfig b/arch/mips/configs/nlm_xlr_defconfig
index 7c68666..d0b857d 100644
--- a/arch/mips/configs/nlm_xlr_defconfig
+++ b/arch/mips/configs/nlm_xlr_defconfig
@@ -8,7 +8,7 @@ CONFIG_HIGH_RES_TIMERS=y
 CONFIG_PREEMPT_VOLUNTARY=y
 CONFIG_KEXEC=y
 CONFIG_EXPERIMENTAL=y
-CONFIG_CROSS_COMPILE="mips-linux-gnu-"
+CONFIG_CROSS_COMPILE=""
 # CONFIG_LOCALVERSION_AUTO is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
@@ -22,7 +22,7 @@ CONFIG_AUDIT=y
 CONFIG_NAMESPACES=y
 CONFIG_SCHED_AUTOGROUP=y
 CONFIG_BLK_DEV_INITRD=y
-CONFIG_INITRAMFS_SOURCE="usr/dev_file_list usr/rootfs.xlr"
+CONFIG_INITRAMFS_SOURCE=""
 CONFIG_RD_BZIP2=y
 CONFIG_RD_LZMA=y
 CONFIG_INITRAMFS_COMPRESSION_GZIP=y
-- 
1.7.7.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mips: fix netlogic defconfigs for coverage builds
  2012-01-22 20:02 [PATCH] mips: fix netlogic defconfigs for coverage builds Paul Gortmaker
@ 2012-01-23 13:32 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2012-01-23 13:32 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-mips, Jayachandran C, David VomLehn

On Sun, Jan 22, 2012 at 03:02:46PM -0500, Paul Gortmaker wrote:

> The toolchain prefix will most likely be site specific and is
> not guaranteed to always be "mips-linux-gnu-", so simply don't
> specify one.  A quick "git grep" shows this to be consistent
> amongst other cross compiled targets.
> 
> Similarly, the site specific initramfs source location should not
> be used, since that won't exist for most people, and it prevents
> them from doing coverage builds on the defconfigs, such as those
> done in linux-next and run routinely by many others.

I ran into that issue as well.  My build script does something like

  sed -i -e s@^CONFIG_CROSS_COMPILE=\"[^\"]*\"\$@CONFIG_CROSS_COMPILE=\"\"@
  sed -i -e s@^CONFIG_INITRAMFS_SOURCE=\"[^\"]*\"\$@CONFIG_INITRAMFS_SOURCE=\"\"@
  sed -i -e s/^CONFIG_DEBUG_INFO=y\$/#\ CONFIG_DEBUG_INFO\ is\ not\ set/

to patch up two two annoying settings and the last one to make the compiler
run a little quicker and increase chances for a hit in ccache.

But for benefit of the rest of the world I've applied tihs patch and will
also patch up powertv_defconfig which now is the last CONFIG_CROSS_COMPILE
user.

Thanks!

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-23 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-22 20:02 [PATCH] mips: fix netlogic defconfigs for coverage builds Paul Gortmaker
2012-01-23 13:32 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.