All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] drivers/staging/android/ashmem.c: Cleanups
@ 2012-01-23  2:28 Tracey Dent
  2012-01-23  2:28 ` [PATCH 2/3] drivers/staging/android/pmem.c: Cleanups Tracey Dent
  2012-01-23  2:28 ` [PATCH 3/3] drivers/staging/android/timed_gpio.c: Stlye fixes Tracey Dent
  0 siblings, 2 replies; 3+ messages in thread
From: Tracey Dent @ 2012-01-23  2:28 UTC (permalink / raw)
  To: greg; +Cc: linux-kernel, swetland, Tracey Dent

Minor cleanups that consist of removal of a whitespace and
make file_operations const.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/android/ashmem.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 99052bf..9f1f27e 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -315,7 +315,7 @@ static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
 	get_file(asma->file);
 
 	/*
-	 * XXX - Reworked to use shmem_zero_setup() instead of 
+	 * XXX - Reworked to use shmem_zero_setup() instead of
 	 * shmem_set_file while we're in staging. -jstultz
 	 */
 	if (vma->vm_flags & VM_SHARED) {
@@ -680,7 +680,7 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	return ret;
 }
 
-static struct file_operations ashmem_fops = {
+static const struct file_operations ashmem_fops = {
 	.owner = THIS_MODULE,
 	.open = ashmem_open,
 	.release = ashmem_release,
-- 
1.7.9.rc2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] drivers/staging/android/pmem.c: Cleanups
  2012-01-23  2:28 [PATCH 1/3] drivers/staging/android/ashmem.c: Cleanups Tracey Dent
@ 2012-01-23  2:28 ` Tracey Dent
  2012-01-23  2:28 ` [PATCH 3/3] drivers/staging/android/timed_gpio.c: Stlye fixes Tracey Dent
  1 sibling, 0 replies; 3+ messages in thread
From: Tracey Dent @ 2012-01-23  2:28 UTC (permalink / raw)
  To: greg; +Cc: linux-kernel, swetland, Tracey Dent

Minor cleanups that consist of including a space and removal
of braces when there not needed.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/android/pmem.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/android/pmem.c b/drivers/staging/android/pmem.c
index 7d97032..b57cdce 100644
--- a/drivers/staging/android/pmem.c
+++ b/drivers/staging/android/pmem.c
@@ -92,7 +92,7 @@ struct pmem_region_node {
 
 #define PMEM_DEBUG_MSGS 0
 #if PMEM_DEBUG_MSGS
-#define DLOG(fmt,args...) \
+#define DLOG(fmt, args...) \
 	do { printk(KERN_INFO "[%s:%s:%d] "fmt, __FILE__, __func__, __LINE__, \
 		    ##args); } \
 	while (0)
@@ -708,9 +708,9 @@ int get_pmem_addr(struct file *file, unsigned long *start,
 	struct pmem_data *data;
 	int id;
 
-	if (!is_pmem_file(file) || !has_allocation(file)) {
+	if (!is_pmem_file(file) || !has_allocation(file))
 		return -1;
-	}
+
 
 	data = (struct pmem_data *)file->private_data;
 	if (data->index == -1) {
@@ -789,9 +789,9 @@ void flush_pmem_file(struct file *file, unsigned long offset, unsigned long len)
 	struct list_head *elt;
 	void *flush_start, *flush_end;
 
-	if (!is_pmem_file(file) || !has_allocation(file)) {
+	if (!is_pmem_file(file) || !has_allocation(file))
 		return;
-	}
+
 
 	id = get_id(file);
 	data = (struct pmem_data *)file->private_data;
-- 
1.7.9.rc2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] drivers/staging/android/timed_gpio.c: Stlye fixes
  2012-01-23  2:28 [PATCH 1/3] drivers/staging/android/ashmem.c: Cleanups Tracey Dent
  2012-01-23  2:28 ` [PATCH 2/3] drivers/staging/android/pmem.c: Cleanups Tracey Dent
@ 2012-01-23  2:28 ` Tracey Dent
  1 sibling, 0 replies; 3+ messages in thread
From: Tracey Dent @ 2012-01-23  2:28 UTC (permalink / raw)
  To: greg; +Cc: linux-kernel, swetland, Tracey Dent

Just made it more neat and not bother scripts/checkpatch.pl

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/staging/android/timed_gpio.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c
index a64481c..bc723ef 100644
--- a/drivers/staging/android/timed_gpio.c
+++ b/drivers/staging/android/timed_gpio.c
@@ -29,9 +29,9 @@ struct timed_gpio_data {
 	struct timed_output_dev dev;
 	struct hrtimer timer;
 	spinlock_t lock;
-	unsigned 	gpio;
-	int 		max_timeout;
-	u8 		active_low;
+	unsigned gpio;
+	int max_timeout;
+	u8 active_low;
 };
 
 static enum hrtimer_restart gpio_timer_func(struct hrtimer *timer)
-- 
1.7.9.rc2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-23  2:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-23  2:28 [PATCH 1/3] drivers/staging/android/ashmem.c: Cleanups Tracey Dent
2012-01-23  2:28 ` [PATCH 2/3] drivers/staging/android/pmem.c: Cleanups Tracey Dent
2012-01-23  2:28 ` [PATCH 3/3] drivers/staging/android/timed_gpio.c: Stlye fixes Tracey Dent

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.