* [PATCH 0/1] bootimg: Fix a math thinko in the block count calculation
@ 2012-01-25 5:20 Darren Hart
2012-01-25 5:20 ` [PATCH 1/1] " Darren Hart
0 siblings, 1 reply; 4+ messages in thread
From: Darren Hart @ 2012-01-25 5:20 UTC (permalink / raw)
To: openembedded-core, Tom Zanussi; +Cc: Darren Hart
The following changes since commit 6b2cb8280211d2e28ce75d6a107f99a3fa7868ae:
gcc-common.inc: Fix comment (2012-01-24 14:38:39 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dvhart/bug/1852
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/bug/1852
Darren Hart (1):
bootimg: Fix a math thinko in the block count calculation
meta/classes/bootimg.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
1.7.6.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] bootimg: Fix a math thinko in the block count calculation
2012-01-25 5:20 [PATCH 0/1] bootimg: Fix a math thinko in the block count calculation Darren Hart
@ 2012-01-25 5:20 ` Darren Hart
2012-01-25 5:53 ` Tom Zanussi
2012-01-25 15:21 ` Richard Purdie
0 siblings, 2 replies; 4+ messages in thread
From: Darren Hart @ 2012-01-25 5:20 UTC (permalink / raw)
To: openembedded-core, Tom Zanussi
Fixes [YOCTO #1852] ... again.
The conversion from sectors to blocks was multiplying by 2 instead
of dividing by 2. Blocks are 1024 bytes, sectors are 512 bytes. The
result was images being much larger than intended.
Reported-by: Tom Zanussi <tom.zanussi@intel.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
CC: Joshua Lock <josh@linux.intel.com>
---
meta/classes/bootimg.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
index df3ee73..e65bef7 100644
--- a/meta/classes/bootimg.bbclass
+++ b/meta/classes/bootimg.bbclass
@@ -133,7 +133,7 @@ build_hddimg() {
SECTORS=$(expr $SECTORS + $(expr $DIR_SECTORS + $FAT_SECTORS))
# Determine the final size in blocks accounting for some padding
- BLOCKS=$(expr $(expr $SECTORS \* 2) + ${BOOTIMG_EXTRA_SPACE})
+ BLOCKS=$(expr $(expr $SECTORS / 2) + ${BOOTIMG_EXTRA_SPACE})
# Ensure total sectors is an integral number of sectors per
# track or mcopy will complain. Sectors are 512 bytes, and we
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] bootimg: Fix a math thinko in the block count calculation
2012-01-25 5:20 ` [PATCH 1/1] " Darren Hart
@ 2012-01-25 5:53 ` Tom Zanussi
2012-01-25 15:21 ` Richard Purdie
1 sibling, 0 replies; 4+ messages in thread
From: Tom Zanussi @ 2012-01-25 5:53 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core
On Tue, 2012-01-24 at 21:20 -0800, Darren Hart wrote:
> Fixes [YOCTO #1852] ... again.
>
> The conversion from sectors to blocks was multiplying by 2 instead
> of dividing by 2. Blocks are 1024 bytes, sectors are 512 bytes. The
> result was images being much larger than intended.
>
Much better, thanks for the quick fix.
Tested-by: Tom Zanussi <tom.zanussi@intel.com>
> Reported-by: Tom Zanussi <tom.zanussi@intel.com>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Joshua Lock <josh@linux.intel.com>
> ---
> meta/classes/bootimg.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
> index df3ee73..e65bef7 100644
> --- a/meta/classes/bootimg.bbclass
> +++ b/meta/classes/bootimg.bbclass
> @@ -133,7 +133,7 @@ build_hddimg() {
> SECTORS=$(expr $SECTORS + $(expr $DIR_SECTORS + $FAT_SECTORS))
>
> # Determine the final size in blocks accounting for some padding
> - BLOCKS=$(expr $(expr $SECTORS \* 2) + ${BOOTIMG_EXTRA_SPACE})
> + BLOCKS=$(expr $(expr $SECTORS / 2) + ${BOOTIMG_EXTRA_SPACE})
>
> # Ensure total sectors is an integral number of sectors per
> # track or mcopy will complain. Sectors are 512 bytes, and we
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] bootimg: Fix a math thinko in the block count calculation
2012-01-25 5:20 ` [PATCH 1/1] " Darren Hart
2012-01-25 5:53 ` Tom Zanussi
@ 2012-01-25 15:21 ` Richard Purdie
1 sibling, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2012-01-25 15:21 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, 2012-01-24 at 21:20 -0800, Darren Hart wrote:
> Fixes [YOCTO #1852] ... again.
>
> The conversion from sectors to blocks was multiplying by 2 instead
> of dividing by 2. Blocks are 1024 bytes, sectors are 512 bytes. The
> result was images being much larger than intended.
>
> Reported-by: Tom Zanussi <tom.zanussi@intel.com>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Joshua Lock <josh@linux.intel.com>
> ---
> meta/classes/bootimg.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-25 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-25 5:20 [PATCH 0/1] bootimg: Fix a math thinko in the block count calculation Darren Hart
2012-01-25 5:20 ` [PATCH 1/1] " Darren Hart
2012-01-25 5:53 ` Tom Zanussi
2012-01-25 15:21 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.