All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: core: Support suspend to disk
@ 2012-01-31 15:30 Mark Brown
  2012-01-31 15:40 ` Liam Girdwood
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-01-31 15:30 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown

Use the same pm_ops for all system suspend and resume paths. This isn't
ideal for suspend to disk with older CODECs as we'll suspend and then
resume the CODEC before powering off all of which takes a long time due
to VMID ramps but it's very simple to implement and for modern CODECs the
overhead should be minimal.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/soc-core.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index e25d69c..53fd9d2 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1663,8 +1663,7 @@ int snd_soc_poweroff(struct device *dev)
 EXPORT_SYMBOL_GPL(snd_soc_poweroff);
 
 const struct dev_pm_ops snd_soc_pm_ops = {
-	.suspend = snd_soc_suspend,
-	.resume = snd_soc_resume,
+	SET_SYSTEM_SLEEP_PM_OPS(snd_soc_suspend, snd_soc_resume)
 	.poweroff = snd_soc_poweroff,
 };
 EXPORT_SYMBOL_GPL(snd_soc_pm_ops);
-- 
1.7.9.rc1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: core: Support suspend to disk
  2012-01-31 15:30 [PATCH] ASoC: core: Support suspend to disk Mark Brown
@ 2012-01-31 15:40 ` Liam Girdwood
  0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2012-01-31 15:40 UTC (permalink / raw)
  To: Mark Brown; +Cc: alsa-devel, patches

On Tue, 2012-01-31 at 15:30 +0000, Mark Brown wrote:
> Use the same pm_ops for all system suspend and resume paths. This isn't
> ideal for suspend to disk with older CODECs as we'll suspend and then
> resume the CODEC before powering off all of which takes a long time due
> to VMID ramps but it's very simple to implement and for modern CODECs the
> overhead should be minimal.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/soc-core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index e25d69c..53fd9d2 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1663,8 +1663,7 @@ int snd_soc_poweroff(struct device *dev)
>  EXPORT_SYMBOL_GPL(snd_soc_poweroff);
>  
>  const struct dev_pm_ops snd_soc_pm_ops = {
> -	.suspend = snd_soc_suspend,
> -	.resume = snd_soc_resume,
> +	SET_SYSTEM_SLEEP_PM_OPS(snd_soc_suspend, snd_soc_resume)
>  	.poweroff = snd_soc_poweroff,
>  };
>  EXPORT_SYMBOL_GPL(snd_soc_pm_ops);

Acked-by: Liam Girdwood <lrg@ti.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-31 15:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-31 15:30 [PATCH] ASoC: core: Support suspend to disk Mark Brown
2012-01-31 15:40 ` Liam Girdwood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.