[PATCH 0/1] bitbake: fix bug #1492

[PATCH 0/1] bitbake: fix bug #1492

[Lianhao Lu]

The following changes since commit 636d7e308fefe7cca67166d564c3a8f877f2ca86:
  Richard Purdie (1):
        useradd.bbclass: Fix missing quote

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib llu/bug1942
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug1942

Lianhao Lu (1):
  prserv: Do not ping PRService if not required

 bitbake/lib/prserv/serv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/1] prserv: Do not ping PRService if not required

[Lianhao Lu]

[YOCTO #1942]
Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
---
 bitbake/lib/prserv/serv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
index fa437f9..5567c6f 100644
--- a/bitbake/lib/prserv/serv.py
+++ b/bitbake/lib/prserv/serv.py
@@ -268,7 +268,7 @@ def is_local_special(host, port):
 
 def auto_start(d):
     global singleton
-    if d.getVar('USE_PR_SERV', True) == '0':
+    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):
         return True
 
     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
-- 
1.7.0.4

Re: [PATCH 1/1] prserv: Do not ping PRService if not required

[Khem Raj]

On Mon, Jan 30, 2012 at 10:18 PM, Lianhao Lu <lianhao.lu@intel.com> wrote:
> [YOCTO #1942]
> Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.
>
> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
>  bitbake/lib/prserv/serv.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
> index fa437f9..5567c6f 100644
> --- a/bitbake/lib/prserv/serv.py
> +++ b/bitbake/lib/prserv/serv.py
> @@ -268,7 +268,7 @@ def is_local_special(host, port):
>
>  def auto_start(d):
>     global singleton
> -    if d.getVar('USE_PR_SERV', True) == '0':
> +    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):


should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST
or PRSERV_PORT are unset

>         return True
>
>     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
> --
> 1.7.0.4
>
>
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

Re: [PATCH 1/1] prserv: Do not ping PRService if not required

[Lu, Lianhao]

Khem Raj wrote on 2012-01-31:
> On Mon, Jan 30, 2012 at 10:18 PM, Lianhao Lu <lianhao.lu@intel.com> wrote:
>> [YOCTO #1942]
>> Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.
>> 
>> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
>> ---
>>  bitbake/lib/prserv/serv.py |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/bitbake/lib/prserv/serv.py b/bitbake/lib/prserv/serv.py
>> index fa437f9..5567c6f 100644
>> --- a/bitbake/lib/prserv/serv.py
>> +++ b/bitbake/lib/prserv/serv.py
>> @@ -268,7 +268,7 @@ def is_local_special(host, port):
>> 
>>  def auto_start(d):
>>     global singleton
>> -    if d.getVar('USE_PR_SERV', True) == '0':
>> +    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):
>
> 
> should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST
> or PRSERV_PORT are unset

USE_PR_SERV will also be set if PRSERV_LOCKDOWN is set in the case of release 'lockdown'.

>>         return True
>> 
>>     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
>> --
>> 1.7.0.4
>> 
>> 
>> _______________________________________________
>> bitbake-devel mailing list
>> bitbake-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

Re: [PATCH 0/1] bitbake: fix bug #1492

[Richard Purdie]

On Tue, 2012-01-31 at 14:18 +0800, Lianhao Lu wrote:
> The following changes since commit 636d7e308fefe7cca67166d564c3a8f877f2ca86:
>   Richard Purdie (1):
>         useradd.bbclass: Fix missing quote
> 
> are available in the git repository at:
> 
>   git://git.pokylinux.org/poky-contrib llu/bug1942
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug1942
> 
> Lianhao Lu (1):
>   prserv: Do not ping PRService if not required

Merged to master, thanks.

Richard