All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-06 14:44 ` Alexander Stein
  0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-06 14:44 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying
  Cc: Alexander Stein, linux-phy, devicetree

These properties are allowed anyway and some SoC (e.g. imx8mq) configure
more than just one clock using these properties.

Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
properties.

 .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
index 786cfd71cb7eb..3c28ec50f0979 100644
--- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
@@ -32,15 +32,6 @@ properties:
   clock-names:
     const: phy_ref
 
-  assigned-clocks:
-    maxItems: 1
-
-  assigned-clock-parents:
-    maxItems: 1
-
-  assigned-clock-rates:
-    maxItems: 1
-
   "#phy-cells":
     const: 0
 
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-06 14:44 ` Alexander Stein
  0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-06 14:44 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying
  Cc: Alexander Stein, linux-phy, devicetree

These properties are allowed anyway and some SoC (e.g. imx8mq) configure
more than just one clock using these properties.

Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
properties.

 .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
index 786cfd71cb7eb..3c28ec50f0979 100644
--- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
@@ -32,15 +32,6 @@ properties:
   clock-names:
     const: phy_ref
 
-  assigned-clocks:
-    maxItems: 1
-
-  assigned-clock-parents:
-    maxItems: 1
-
-  assigned-clock-rates:
-    maxItems: 1
-
   "#phy-cells":
     const: 0
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
  2023-06-06 14:44 ` Alexander Stein
@ 2023-06-06 18:21   ` Conor Dooley
  -1 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2023-06-06 18:21 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree


[-- Attachment #1.1: Type: text/plain, Size: 1720 bytes --]

On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.

What does "allowed anyway" mean?
And following from that, why not modify the min/maxItems to suit
reality, rather than remove them. Is there enforcement from elsewhere?

> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

I suspect that meant that the property was in the dt but not in the
binding at the time of the conversion.

Cheers,
Conor.

> 
> Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> properties.
> 
>  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> index 786cfd71cb7eb..3c28ec50f0979 100644
> --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> @@ -32,15 +32,6 @@ properties:
>    clock-names:
>      const: phy_ref
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-parents:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    "#phy-cells":
>      const: 0
>  
> -- 
> 2.34.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-06 18:21   ` Conor Dooley
  0 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2023-06-06 18:21 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.

What does "allowed anyway" mean?
And following from that, why not modify the min/maxItems to suit
reality, rather than remove them. Is there enforcement from elsewhere?

> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

I suspect that meant that the property was in the dt but not in the
binding at the time of the conversion.

Cheers,
Conor.

> 
> Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> properties.
> 
>  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> index 786cfd71cb7eb..3c28ec50f0979 100644
> --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> @@ -32,15 +32,6 @@ properties:
>    clock-names:
>      const: phy_ref
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-parents:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    "#phy-cells":
>      const: 0
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
  2023-06-06 14:44 ` Alexander Stein
@ 2023-06-07  2:45   ` Ying Liu
  -1 siblings, 0 replies; 12+ messages in thread
From: Ying Liu @ 2023-06-07  2:45 UTC (permalink / raw)
  To: Alexander Stein, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-phy, devicetree

> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.
> 
> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-
> schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

IIUC, this is due to dt-schema change done by commit c3424745f900
("dtschema: Add assigned-clock* properties by default").  See
https://github.com/devicetree-org/dt-schema/commit/c3424745f900e8cf0a0e3acebffeeda83a82f6d4

Regards,
Liu Ying

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-07  2:45   ` Ying Liu
  0 siblings, 0 replies; 12+ messages in thread
From: Ying Liu @ 2023-06-07  2:45 UTC (permalink / raw)
  To: Alexander Stein, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-phy, devicetree

> From: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.
> 
> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-
> schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

IIUC, this is due to dt-schema change done by commit c3424745f900
("dtschema: Add assigned-clock* properties by default").  See
https://github.com/devicetree-org/dt-schema/commit/c3424745f900e8cf0a0e3acebffeeda83a82f6d4

Regards,
Liu Ying

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
  2023-06-06 18:21   ` Conor Dooley
@ 2023-06-08  7:31     ` Alexander Stein
  -1 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-08  7:31 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

Hi Conor,

Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> * PGP Signed by an unknown key
> 
> On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > more than just one clock using these properties.
> 
> What does "allowed anyway" mean?
> And following from that, why not modify the min/maxItems to suit
> reality, rather than remove them. Is there enforcement from elsewhere?

As Liu pointed out, assigned-clock* were considered a generic property added 
by default at that time. With that support added there is no need to specify 
these properties in this bindings again.
Despite that you never know in advance how many items you will have to add to 
assigned-clock* properties, that's totally different to 'clocks', it may even 
depend on board specific clock setups.

> > Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to
> > json-schema") Signed-off-by: Alexander Stein
> > <alexander.stein@ew.tq-group.com>
> > ---
> > I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> > ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").
> 
> I suspect that meant that the property was in the dt but not in the
> binding at the time of the conversion.

You are right, given the commit [1]. Which, from today's perspective, is also 
a rationale for this patch.

Best regards,
Alexander

[1] https://github.com/devicetree-org/dt-schema/commit/
c3424745f900e8cf0a0e3acebffeeda83a82f6d4

> Cheers,
> Conor.
> 
> > Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> > mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> > properties.
> > 
> >  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml index
> > 786cfd71cb7eb..3c28ec50f0979 100644
> > --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > 
> > @@ -32,15 +32,6 @@ properties:
> >    clock-names:
> >      const: phy_ref
> > 
> > -  assigned-clocks:
> > -    maxItems: 1
> > -
> > -  assigned-clock-parents:
> > -    maxItems: 1
> > -
> > -  assigned-clock-rates:
> > -    maxItems: 1
> > -
> > 
> >    "#phy-cells":
> >      const: 0
> 
> * Unknown Key
> * 0xA08262D2


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-08  7:31     ` Alexander Stein
  0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-08  7:31 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

Hi Conor,

Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> * PGP Signed by an unknown key
> 
> On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > more than just one clock using these properties.
> 
> What does "allowed anyway" mean?
> And following from that, why not modify the min/maxItems to suit
> reality, rather than remove them. Is there enforcement from elsewhere?

As Liu pointed out, assigned-clock* were considered a generic property added 
by default at that time. With that support added there is no need to specify 
these properties in this bindings again.
Despite that you never know in advance how many items you will have to add to 
assigned-clock* properties, that's totally different to 'clocks', it may even 
depend on board specific clock setups.

> > Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to
> > json-schema") Signed-off-by: Alexander Stein
> > <alexander.stein@ew.tq-group.com>
> > ---
> > I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> > ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").
> 
> I suspect that meant that the property was in the dt but not in the
> binding at the time of the conversion.

You are right, given the commit [1]. Which, from today's perspective, is also 
a rationale for this patch.

Best regards,
Alexander

[1] https://github.com/devicetree-org/dt-schema/commit/
c3424745f900e8cf0a0e3acebffeeda83a82f6d4

> Cheers,
> Conor.
> 
> > Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> > mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> > properties.
> > 
> >  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml index
> > 786cfd71cb7eb..3c28ec50f0979 100644
> > --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> > 
> > @@ -32,15 +32,6 @@ properties:
> >    clock-names:
> >      const: phy_ref
> > 
> > -  assigned-clocks:
> > -    maxItems: 1
> > -
> > -  assigned-clock-parents:
> > -    maxItems: 1
> > -
> > -  assigned-clock-rates:
> > -    maxItems: 1
> > -
> > 
> >    "#phy-cells":
> >      const: 0
> 
> * Unknown Key
> * 0xA08262D2


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
  2023-06-08  7:31     ` Alexander Stein
@ 2023-06-08  7:59       ` Conor Dooley
  -1 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2023-06-08  7:59 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> Hi Conor,
> 
> Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > * PGP Signed by an unknown key
> > 
> > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > > more than just one clock using these properties.
> > 
> > What does "allowed anyway" mean?
> > And following from that, why not modify the min/maxItems to suit
> > reality, rather than remove them. Is there enforcement from elsewhere?
> 
> As Liu pointed out, assigned-clock* were considered a generic property added 
> by default at that time. With that support added there is no need to specify 
> these properties in this bindings again.
> Despite that you never know in advance how many items you will have to add to 
> assigned-clock* properties, that's totally different to 'clocks', it may even 
> depend on board specific clock setups.

Sounds grand to me. I think it'd be good in the future to explain
*where* the enforcement comes from, rather than saying something like
"allowed anyway". Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-08  7:59       ` Conor Dooley
  0 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2023-06-08  7:59 UTC (permalink / raw)
  To: Alexander Stein
  Cc: Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree


[-- Attachment #1.1: Type: text/plain, Size: 1248 bytes --]

On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> Hi Conor,
> 
> Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > * PGP Signed by an unknown key
> > 
> > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> > > more than just one clock using these properties.
> > 
> > What does "allowed anyway" mean?
> > And following from that, why not modify the min/maxItems to suit
> > reality, rather than remove them. Is there enforcement from elsewhere?
> 
> As Liu pointed out, assigned-clock* were considered a generic property added 
> by default at that time. With that support added there is no need to specify 
> these properties in this bindings again.
> Despite that you never know in advance how many items you will have to add to 
> assigned-clock* properties, that's totally different to 'clocks', it may even 
> depend on board specific clock setups.

Sounds grand to me. I think it'd be good in the future to explain
*where* the enforcement comes from, rather than saying something like
"allowed anyway". Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
  2023-06-08  7:59       ` Conor Dooley
@ 2023-06-08  8:07         ` Alexander Stein
  -1 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-08  8:07 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

Hi Conor,

Am Donnerstag, 8. Juni 2023, 09:59:10 CEST schrieb Conor Dooley:
> * PGP Signed by an unknown key
> 
> On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> > Hi Conor,
> > 
> > Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > > > Old Signed by an unknown key
> > > 
> > > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > > These properties are allowed anyway and some SoC (e.g. imx8mq)
> > > > configure
> > > > more than just one clock using these properties.
> > > 
> > > What does "allowed anyway" mean?
> > > And following from that, why not modify the min/maxItems to suit
> > > reality, rather than remove them. Is there enforcement from elsewhere?
> > 
> > As Liu pointed out, assigned-clock* were considered a generic property
> > added by default at that time. With that support added there is no need
> > to specify these properties in this bindings again.
> > Despite that you never know in advance how many items you will have to add
> > to assigned-clock* properties, that's totally different to 'clocks', it
> > may even depend on board specific clock setups.
> 
> Sounds grand to me. I think it'd be good in the future to explain
> *where* the enforcement comes from, rather than saying something like
> "allowed anyway". 

True, I'll send an updated patch with commit message improved referring to 
updated dt-schema.

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Alexander

> Cheers,
> Conor.
> 
> * Unknown Key
> * 0xA08262D2


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: Remove assigned-clock* properties
@ 2023-06-08  8:07         ` Alexander Stein
  0 siblings, 0 replies; 12+ messages in thread
From: Alexander Stein @ 2023-06-08  8:07 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Liu Ying, linux-phy,
	devicetree

Hi Conor,

Am Donnerstag, 8. Juni 2023, 09:59:10 CEST schrieb Conor Dooley:
> * PGP Signed by an unknown key
> 
> On Thu, Jun 08, 2023 at 09:31:57AM +0200, Alexander Stein wrote:
> > Hi Conor,
> > 
> > Am Dienstag, 6. Juni 2023, 20:21:02 CEST schrieb Conor Dooley:
> > > > Old Signed by an unknown key
> > > 
> > > On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> > > > These properties are allowed anyway and some SoC (e.g. imx8mq)
> > > > configure
> > > > more than just one clock using these properties.
> > > 
> > > What does "allowed anyway" mean?
> > > And following from that, why not modify the min/maxItems to suit
> > > reality, rather than remove them. Is there enforcement from elsewhere?
> > 
> > As Liu pointed out, assigned-clock* were considered a generic property
> > added by default at that time. With that support added there is no need
> > to specify these properties in this bindings again.
> > Despite that you never know in advance how many items you will have to add
> > to assigned-clock* properties, that's totally different to 'clocks', it
> > may even depend on board specific clock setups.
> 
> Sounds grand to me. I think it'd be good in the future to explain
> *where* the enforcement comes from, rather than saying something like
> "allowed anyway". 

True, I'll send an updated patch with commit message improved referring to 
updated dt-schema.

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Alexander

> Cheers,
> Conor.
> 
> * Unknown Key
> * 0xA08262D2


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-06-08  8:07 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 14:44 [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties Alexander Stein
2023-06-06 14:44 ` Alexander Stein
2023-06-06 18:21 ` Conor Dooley
2023-06-06 18:21   ` Conor Dooley
2023-06-08  7:31   ` [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: " Alexander Stein
2023-06-08  7:31     ` Alexander Stein
2023-06-08  7:59     ` Conor Dooley
2023-06-08  7:59       ` Conor Dooley
2023-06-08  8:07       ` Alexander Stein
2023-06-08  8:07         ` Alexander Stein
2023-06-07  2:45 ` [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: " Ying Liu
2023-06-07  2:45   ` Ying Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.