From: Liam Girdwood <lrg@ti.com>
To: M R Swami Reddy <MR.Swami.Reddy@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: FW: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
Date: Wed, 08 Feb 2012 09:18:43 +0000 [thread overview]
Message-ID: <1328692723.3955.4.camel@odin> (raw)
In-Reply-To: <4F323BF5.4010309@ti.com>
On Wed, 2012-02-08 at 14:40 +0530, M R Swami Reddy wrote:
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> > Sent: Tuesday, February 07, 2012 10:34 PM
> > To: Reddy, MR Swami
> > Cc: Girdwood, Liam; alsa-devel@alsa-project.org
> > Subject: Re: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
> >
> > On Mon, Feb 06, 2012 at 06:20:26AM -0800, Reddy, MR Swami wrote:
> >
> >> Changes made in v3:
> >> o Updated the lm49453_set_dai_pll() as per review comments in v2 patch.
> >> o Removed pll disable code in _set_dai_pll().
> >
> > This doesn't really seem to address the issue at all - you still have the problems with the set_pll() function not doing anything it's supposed to do with the input and output frequencies, and now there's no way to disable the PLL.
>
> OK. So its ideal to remove the _set_dai_pll(), as its not doing anything here.
The set_pll() function is meant to take the input and output frequencies
passed in as parameters and then use these to configure the PLL. If the
output frequency is 0 then you should switch OFF your PLL to conserve
power.
Your function is just enabling the PLLs. Where do you configure the PLL
dividers (to divide the input frequency into the output frequency)?
Where do you switch the PLL off when it's not in use ?
Liam
next prev parent reply other threads:[~2012-02-08 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <290463D19D2E064191F1F96ECA480A89434AC4A96E@EXMAIL02.scwf.nsc.com>
2012-02-08 9:10 ` FW: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec M R Swami Reddy
2012-02-08 9:18 ` Liam Girdwood [this message]
2012-02-08 9:37 ` Vinod Koul
2012-02-08 9:54 ` Liam Girdwood
2012-02-08 10:36 ` Vinod Koul
2012-02-08 10:57 ` Liam Girdwood
2012-02-08 11:17 ` Vinod Koul
2012-02-08 11:21 ` Mark Brown
2012-02-08 14:31 ` Vinod Koul
2012-02-08 11:20 ` Mark Brown
2012-02-08 13:27 ` Liam Girdwood
2012-02-08 13:54 ` Mark Brown
2012-02-08 14:33 ` Vinod Koul
2012-02-08 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328692723.3955.4.camel@odin \
--to=lrg@ti.com \
--cc=MR.Swami.Reddy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.