From: Vinod Koul <vinod.koul@linux.intel.com>
To: Liam Girdwood <lrg@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
M R Swami Reddy <MR.Swami.Reddy@ti.com>
Subject: Re: FW: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec
Date: Wed, 08 Feb 2012 15:07:34 +0530 [thread overview]
Message-ID: <1328693854.21099.5.camel@vkoul-udesk3> (raw)
In-Reply-To: <1328692723.3955.4.camel@odin>
On Wed, 2012-02-08 at 09:18 +0000, Liam Girdwood wrote:
> The set_pll() function is meant to take the input and output frequencies
> passed in as parameters and then use these to configure the PLL. If the
> output frequency is 0 then you should switch OFF your PLL to conserve
> power.
>
> Your function is just enabling the PLLs. Where do you configure the PLL
> dividers (to divide the input frequency into the output frequency)?
> Where do you switch the PLL off when it's not in use ?
>
A different question...
how does a codec driver ensure that input clock is ON. Codec doesn't
know anything about platform so shouldn't there be a callback to
machine/platform to turn on the input clock?
--
~Vinod
next prev parent reply other threads:[~2012-02-08 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <290463D19D2E064191F1F96ECA480A89434AC4A96E@EXMAIL02.scwf.nsc.com>
2012-02-08 9:10 ` FW: [PATCH v3] ASoC: Add support for TI LM49453 Audio codec M R Swami Reddy
2012-02-08 9:18 ` Liam Girdwood
2012-02-08 9:37 ` Vinod Koul [this message]
2012-02-08 9:54 ` Liam Girdwood
2012-02-08 10:36 ` Vinod Koul
2012-02-08 10:57 ` Liam Girdwood
2012-02-08 11:17 ` Vinod Koul
2012-02-08 11:21 ` Mark Brown
2012-02-08 14:31 ` Vinod Koul
2012-02-08 11:20 ` Mark Brown
2012-02-08 13:27 ` Liam Girdwood
2012-02-08 13:54 ` Mark Brown
2012-02-08 14:33 ` Vinod Koul
2012-02-08 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328693854.21099.5.camel@vkoul-udesk3 \
--to=vinod.koul@linux.intel.com \
--cc=MR.Swami.Reddy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.