All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] mace: Fix build for mace due to netdev_alloc_skb
@ 2012-02-08 10:03 Pradeep A Dalvi
  2012-02-08 20:23 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Pradeep A Dalvi @ 2012-02-08 10:03 UTC (permalink / raw)
  To: netdev; +Cc: David S. Miller, linux-kernel, Pradeep A Dalvi

Refs:
1. pmac32_defconfig
http://kisskb.ellerman.id.au/kisskb/buildresult/5583746/
2. ppc6xx_defconfig
http://kisskb.ellerman.id.au/kisskb/buildresult/5584116/

Confirmed any such occurances from all failed defconfigs &
in net-next sources with
grep -nrs "netdev_alloc_skb" drivers/net/ethernet/ | grep -v ","

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Pradeep A Dalvi <netdev@pradeepdalvi.com>
---
 drivers/net/ethernet/apple/mace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c
index 0699846..e1df4b7 100644
--- a/drivers/net/ethernet/apple/mace.c
+++ b/drivers/net/ethernet/apple/mace.c
@@ -956,7 +956,7 @@ static irqreturn_t mace_rxdma_intr(int irq, void *dev_id)
 	cp = mp->rx_cmds + i;
 	skb = mp->rx_bufs[i];
 	if (!skb) {
-	    skb = netdev_alloc_skb(RX_BUFLEN + 2);
+	    skb = netdev_alloc_skb(dev, RX_BUFLEN + 2);
 	    if (skb) {
 		skb_reserve(skb, 2);
 		mp->rx_bufs[i] = skb;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] mace: Fix build for mace due to netdev_alloc_skb
  2012-02-08 10:03 [PATCH net-next] mace: Fix build for mace due to netdev_alloc_skb Pradeep A Dalvi
@ 2012-02-08 20:23 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-02-08 20:23 UTC (permalink / raw)
  To: netdev; +Cc: netdev, linux-kernel

From: Pradeep A Dalvi <netdev@pradeepdalvi.com>
Date: Wed,  8 Feb 2012 15:33:15 +0530

> Refs:
> 1. pmac32_defconfig
> http://kisskb.ellerman.id.au/kisskb/buildresult/5583746/
> 2. ppc6xx_defconfig
> http://kisskb.ellerman.id.au/kisskb/buildresult/5584116/
> 
> Confirmed any such occurances from all failed defconfigs &
> in net-next sources with
> grep -nrs "netdev_alloc_skb" drivers/net/ethernet/ | grep -v ","
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Pradeep A Dalvi <netdev@pradeepdalvi.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-08 20:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 10:03 [PATCH net-next] mace: Fix build for mace due to netdev_alloc_skb Pradeep A Dalvi
2012-02-08 20:23 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.