* [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value
@ 2012-02-08 17:56 Nikolaus Schulz
2012-02-08 19:00 ` [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu Guenter Roeck
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nikolaus Schulz @ 2012-02-08 17:56 UTC (permalink / raw)
To: lm-sensors
From: Nikolaus Schulz <schulz@macnetix.de>
Treat pwmX as a measured value, not as a (mostly static) limit value, so
that it is updated more frequently from the device register.
Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
---
drivers/hwmon/f75375s.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index 0aabaaf..f609b57 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -200,9 +200,6 @@ static struct f75375_data *f75375_update_device(struct device *dev)
f75375_read16(client, F75375_REG_FAN_MIN(nr));
data->fan_target[nr] f75375_read16(client, F75375_REG_FAN_EXP(nr));
- data->pwm[nr] = f75375_read8(client,
- F75375_REG_FAN_PWM_DUTY(nr));
-
}
for (nr = 0; nr < 4; nr++) {
data->in_max[nr] @@ -218,6 +215,8 @@ static struct f75375_data *f75375_update_device(struct device *dev)
if (time_after(jiffies, data->last_updated + 2 * HZ)
|| !data->valid) {
for (nr = 0; nr < 2; nr++) {
+ data->pwm[nr] = f75375_read8(client,
+ F75375_REG_FAN_PWM_DUTY(nr));
/* assign MSB, therefore shift it by 8 bits */
data->temp11[nr] f75375_read8(client, F75375_REG_TEMP(nr)) << 8;
--
1.7.9
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu
2012-02-08 17:56 [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value Nikolaus Schulz
@ 2012-02-08 19:00 ` Guenter Roeck
2012-02-09 18:50 ` Nikolaus Schulz
2012-02-09 19:19 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-02-08 19:00 UTC (permalink / raw)
To: lm-sensors
On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> From: Nikolaus Schulz <schulz@macnetix.de>
>
> Treat pwmX as a measured value, not as a (mostly static) limit value, so
> that it is updated more frequently from the device register.
>
> Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
> ---
> drivers/hwmon/f75375s.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> index 0aabaaf..f609b57 100644
> --- a/drivers/hwmon/f75375s.c
> +++ b/drivers/hwmon/f75375s.c
> @@ -200,9 +200,6 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> f75375_read16(client, F75375_REG_FAN_MIN(nr));
> data->fan_target[nr] > f75375_read16(client, F75375_REG_FAN_EXP(nr));
> - data->pwm[nr] = f75375_read8(client,
> - F75375_REG_FAN_PWM_DUTY(nr));
> -
> }
> for (nr = 0; nr < 4; nr++) {
> data->in_max[nr] > @@ -218,6 +215,8 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> if (time_after(jiffies, data->last_updated + 2 * HZ)
> || !data->valid) {
> for (nr = 0; nr < 2; nr++) {
> + data->pwm[nr] = f75375_read8(client,
> + F75375_REG_FAN_PWM_DUTY(nr));
> /* assign MSB, therefore shift it by 8 bits */
> data->temp11[nr] > f75375_read8(client, F75375_REG_TEMP(nr)) << 8;
This also fixes a bug where pwm was not read at all if there is no
platform data. Doesn't apply to -stable, since support for automatic
startup (no platform data) was only added recently, but still ...
Thanks, applied.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu
2012-02-08 17:56 [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value Nikolaus Schulz
2012-02-08 19:00 ` [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu Guenter Roeck
@ 2012-02-09 18:50 ` Nikolaus Schulz
2012-02-09 19:19 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Nikolaus Schulz @ 2012-02-09 18:50 UTC (permalink / raw)
To: lm-sensors
On Wed, Feb 08, 2012 at 11:00:43AM -0800, Guenter Roeck wrote:
> On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> > From: Nikolaus Schulz <schulz@macnetix.de>
> >
> > Treat pwmX as a measured value, not as a (mostly static) limit value, so
> > that it is updated more frequently from the device register.
> >
> > Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
> > ---
> > drivers/hwmon/f75375s.c | 5 ++---
> > 1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> > index 0aabaaf..f609b57 100644
> > --- a/drivers/hwmon/f75375s.c
> > +++ b/drivers/hwmon/f75375s.c
> > @@ -200,9 +200,6 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> > f75375_read16(client, F75375_REG_FAN_MIN(nr));
> > data->fan_target[nr] > > f75375_read16(client, F75375_REG_FAN_EXP(nr));
> > - data->pwm[nr] = f75375_read8(client,
> > - F75375_REG_FAN_PWM_DUTY(nr));
> > -
> > }
> > for (nr = 0; nr < 4; nr++) {
> > data->in_max[nr] > > @@ -218,6 +215,8 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> > if (time_after(jiffies, data->last_updated + 2 * HZ)
> > || !data->valid) {
> > for (nr = 0; nr < 2; nr++) {
> > + data->pwm[nr] = f75375_read8(client,
> > + F75375_REG_FAN_PWM_DUTY(nr));
> > /* assign MSB, therefore shift it by 8 bits */
> > data->temp11[nr] > > f75375_read8(client, F75375_REG_TEMP(nr)) << 8;
>
> This also fixes a bug where pwm was not read at all if there is no
> platform data.
I don't think so, but anyways...
> Doesn't apply to -stable, since support for automatic
> startup (no platform data) was only added recently, but still ...
(stable@kernel.org wasn't cc'ed here.)
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu
2012-02-08 17:56 [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value Nikolaus Schulz
2012-02-08 19:00 ` [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu Guenter Roeck
2012-02-09 18:50 ` Nikolaus Schulz
@ 2012-02-09 19:19 ` Guenter Roeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-02-09 19:19 UTC (permalink / raw)
To: lm-sensors
On Thu, 2012-02-09 at 13:50 -0500, Nikolaus Schulz wrote:
> On Wed, Feb 08, 2012 at 11:00:43AM -0800, Guenter Roeck wrote:
> > On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> > > From: Nikolaus Schulz <schulz@macnetix.de>
> > >
> > > Treat pwmX as a measured value, not as a (mostly static) limit value, so
> > > that it is updated more frequently from the device register.
> > >
> > > Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
> > > ---
> > > drivers/hwmon/f75375s.c | 5 ++---
> > > 1 files changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> > > index 0aabaaf..f609b57 100644
> > > --- a/drivers/hwmon/f75375s.c
> > > +++ b/drivers/hwmon/f75375s.c
> > > @@ -200,9 +200,6 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> > > f75375_read16(client, F75375_REG_FAN_MIN(nr));
> > > data->fan_target[nr] > > > f75375_read16(client, F75375_REG_FAN_EXP(nr));
> > > - data->pwm[nr] = f75375_read8(client,
> > > - F75375_REG_FAN_PWM_DUTY(nr));
> > > -
> > > }
> > > for (nr = 0; nr < 4; nr++) {
> > > data->in_max[nr] > > > @@ -218,6 +215,8 @@ static struct f75375_data *f75375_update_device(struct device *dev)
> > > if (time_after(jiffies, data->last_updated + 2 * HZ)
> > > || !data->valid) {
> > > for (nr = 0; nr < 2; nr++) {
> > > + data->pwm[nr] = f75375_read8(client,
> > > + F75375_REG_FAN_PWM_DUTY(nr));
> > > /* assign MSB, therefore shift it by 8 bits */
> > > data->temp11[nr] > > > f75375_read8(client, F75375_REG_TEMP(nr)) << 8;
> >
> > This also fixes a bug where pwm was not read at all if there is no
> > platform data.
>
> I don't think so, but anyways...
>
You are right, I missed the (now removed) first round of reading the pwm
value. Sorry for the noise; I'll updated the commit accordingly.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-09 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 17:56 [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured value Nikolaus Schulz
2012-02-08 19:00 ` [lm-sensors] [PATCH 4/4] hwmon: (f75375s) Let f75375_update_device treat pwmX as a measured valu Guenter Roeck
2012-02-09 18:50 ` Nikolaus Schulz
2012-02-09 19:19 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.