[lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F75387

[lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F75387

[Nikolaus Schulz]

From: Nikolaus Schulz <schulz@macnetix.de>

Unlike the other chips supported by this driver, the F75387 stores the
pwm_mode in register F75375_REG_FAN_TIMER, not F75375_REG_CONFIG1.

Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
Cc: stable@kernel.org
---
 drivers/hwmon/f75375s.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index c81ad45..b3eef44 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -723,7 +723,7 @@ static void f75375_init(struct i2c_client *client, struct f75375_data *data,
 			if (data->kind = f75387) {
 				bool manu, duty;
 
-				if (!(conf & (1 << F75387_FAN_CTRL_LINEAR(nr))))
+				if (!(mode & (1 << F75387_FAN_CTRL_LINEAR(nr))))
 					data->pwm_mode[nr] = 1;
 
 				manu = ((mode >> F75387_FAN_MANU_MODE(nr)) & 1);
-- 
1.7.9


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Guenter Roeck]

On Wed, 2012-02-08 at 12:56 -0500, Nikolaus Schulz wrote:
> From: Nikolaus Schulz <schulz@macnetix.de>
> 
> Unlike the other chips supported by this driver, the F75387 stores the
> pwm_mode in register F75375_REG_FAN_TIMER, not F75375_REG_CONFIG1.
> 
> Signed-off-by: Nikolaus Schulz <mail@microschulz.de>
> Cc: stable@kernel.org
> ---
>  drivers/hwmon/f75375s.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
> index c81ad45..b3eef44 100644
> --- a/drivers/hwmon/f75375s.c
> +++ b/drivers/hwmon/f75375s.c
> @@ -723,7 +723,7 @@ static void f75375_init(struct i2c_client *client, struct f75375_data *data,
>  			if (data->kind = f75387) {
>  				bool manu, duty;
>  
> -				if (!(conf & (1 << F75387_FAN_CTRL_LINEAR(nr))))
> +				if (!(mode & (1 << F75387_FAN_CTRL_LINEAR(nr))))
>  					data->pwm_mode[nr] = 1;
>  
>  				manu = ((mode >> F75387_FAN_MANU_MODE(nr)) & 1);

Applied.

This code was only added for 3.3, so the patch does not apply to stable,
only to 3.3-rc.

Thanks,
Guenter




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Nikolaus Schulz]

On Wed, Feb 08, 2012 at 10:53:51AM -0800, Guenter Roeck wrote:
> This code was only added for 3.3, so the patch does not apply to stable,
> only to 3.3-rc.

Ah, indeed, I missed that.

Thanks,
Nikolaus

PS. Hmm, I don't see my patch emails appear on the lm-sensors list, only
the introductionary one. I wonder what's wrong?

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Guenter Roeck]

On Wed, 2012-02-08 at 16:31 -0500, Nikolaus Schulz wrote:
> On Wed, Feb 08, 2012 at 10:53:51AM -0800, Guenter Roeck wrote:
> > This code was only added for 3.3, so the patch does not apply to stable,
> > only to 3.3-rc.
> 
> Ah, indeed, I missed that.
> 
> Thanks,
> Nikolaus
> 
> PS. Hmm, I don't see my patch emails appear on the lm-sensors list, only
> the introductionary one. I wonder what's wrong?

As far as I know, gmane only stores an email once if it is sent to
multiple lists. Kind of annoying, but happens on a quite regular basis.

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Jean Delvare]

On Wed, 8 Feb 2012 22:31:53 +0100, Nikolaus Schulz wrote:
> PS. Hmm, I don't see my patch emails appear on the lm-sensors list, only
> the introductionary one. I wonder what's wrong?

I see everything:
http://lists.lm-sensors.org/pipermail/lm-sensors/2012-February/thread.html

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Guenter Roeck]

On Wed, 2012-02-08 at 17:01 -0500, Jean Delvare wrote:
> On Wed, 8 Feb 2012 22:31:53 +0100, Nikolaus Schulz wrote:
> > PS. Hmm, I don't see my patch emails appear on the lm-sensors list, only
> > the introductionary one. I wonder what's wrong?
> 
> I see everything:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2012-February/thread.html
> 
I think dropping some posts is a gmane specialty.

Guenter




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH 2/4] hwmon: (f75375s) Fix reading of wrong register when initializing the F7

[Nikolaus Schulz]

On Wed, Feb 08, 2012 at 11:01:54PM +0100, Jean Delvare wrote:
> On Wed, 8 Feb 2012 22:31:53 +0100, Nikolaus Schulz wrote:
> > PS. Hmm, I don't see my patch emails appear on the lm-sensors list, only
> > the introductionary one. I wonder what's wrong?
> 
> I see everything:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2012-February/thread.html

Oh, nevermind, found it: it's mailman avoiding duplicate emails, since I
was already in the email recipient list.  Sorry for the noise.

Nikolaus

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors