All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: s5m-core: Fix val_len parameters for regmap_raw_write
@ 2012-02-14  3:08 Axel Lin
  2012-02-23 15:32 ` Samuel Ortiz
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-02-14  3:08 UTC (permalink / raw)
  To: linux-kernel; +Cc: Sangbeom Kim, Mark Brown, Samuel Ortiz

The val_len parameters for regmap_raw_write should be "count * sizeof(u8)"
(or simply "count") instead of "count * sizeof(u16)".

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/mfd/s5m-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/s5m-core.c b/drivers/mfd/s5m-core.c
index e075c11..2c45427 100644
--- a/drivers/mfd/s5m-core.c
+++ b/drivers/mfd/s5m-core.c
@@ -54,7 +54,7 @@ EXPORT_SYMBOL_GPL(s5m_reg_write);
 
 int s5m_bulk_write(struct s5m87xx_dev *s5m87xx, u8 reg, int count, u8 *buf)
 {
-	return regmap_raw_write(s5m87xx->regmap, reg, buf, count * sizeof(u16));
+	return regmap_raw_write(s5m87xx->regmap, reg, buf, count);
 }
 EXPORT_SYMBOL_GPL(s5m_bulk_write);
 
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: s5m-core: Fix val_len parameters for regmap_raw_write
  2012-02-14  3:08 [PATCH] mfd: s5m-core: Fix val_len parameters for regmap_raw_write Axel Lin
@ 2012-02-23 15:32 ` Samuel Ortiz
  0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2012-02-23 15:32 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Sangbeom Kim, Mark Brown

Hi Axel,

On Tue, Feb 14, 2012 at 11:08:07AM +0800, Axel Lin wrote:
> The val_len parameters for regmap_raw_write should be "count * sizeof(u8)"
> (or simply "count") instead of "count * sizeof(u16)".
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Patch applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-23 15:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-14  3:08 [PATCH] mfd: s5m-core: Fix val_len parameters for regmap_raw_write Axel Lin
2012-02-23 15:32 ` Samuel Ortiz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.