[PATCH 1/2] drm/i915: print the unrecognised pixel format value.

[PATCH 1/2] drm/i915: print the unrecognised pixel format value.

[Dave Airlie]

From: Dave Airlie <airlied@redhat.com>

Another contentless error bites the dust.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f425b23..1efb5fc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7830,7 +7830,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 	case DRM_FORMAT_VYUY:
 		break;
 	default:
-		DRM_ERROR("unsupported pixel format\n");
+		DRM_ERROR("unsupported pixel format %x\n", mode_cmd->pixel_format);
 		return -EINVAL;
 	}
 
-- 
1.7.7.6

[PATCH 2/2] drm/i915: fix mode set on load pipe.

[Dave Airlie]

From: Dave Airlie <airlied@redhat.com>

Booted my i965 machine and it started printing the unsupported pixel
format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1efb5fc..c03bad7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6561,7 +6561,7 @@ intel_framebuffer_create_for_mode(struct drm_device *dev,
 	mode_cmd.height = mode->vdisplay;
 	mode_cmd.pitches[0] = intel_framebuffer_pitch_for_width(mode_cmd.width,
 								bpp);
-	mode_cmd.pixel_format = 0;
+	mode_cmd.pixel_format = drm_fb_legacy_fb_format(bpp, depth);
 
 	return intel_framebuffer_create(dev, &mode_cmd, obj);
 }
-- 
1.7.7.6

Re: [PATCH 1/2] drm/i915: print the unrecognised pixel format value.

[Daniel Vetter]

On Thu, Feb 23, 2012 at 03:31:45PM +0000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> Another contentless error bites the dust.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Almost identical patch is already merged into -next:

commit aca258482ed7c600b5aeed03aa8727d94d8dd07e
Author: Eugeni Dodonov <eugeni.dodonov@intel.com>
Date:   Tue Jan 17 15:25:45 2012 -0200

    drm/i915: print out which pixel format we do not support

> ---
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f425b23..1efb5fc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7830,7 +7830,7 @@ int intel_framebuffer_init(struct drm_device *dev,
>  	case DRM_FORMAT_VYUY:
>  		break;
>  	default:
> -		DRM_ERROR("unsupported pixel format\n");
> +		DRM_ERROR("unsupported pixel format %x\n", mode_cmd->pixel_format);
>  		return -EINVAL;
>  	}
>  
> -- 
> 1.7.7.6
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

Re: [PATCH 1/2] drm/i915: print the unrecognised pixel format value.

[Chris Wilson]

On Thu, 23 Feb 2012 15:31:45 +0000, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> Another contentless error bites the dust.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre