[Qemu-devel] [PATCH 0/2] Trivial MemoryRegionOps patches

[Qemu-devel] [PATCH 0/2] Trivial MemoryRegionOps patches

[Stefan Weil]

Please apply http://patchwork.ozlabs.org/patch/139660/ to the qemu-trivial
patch queue. Here are two additional trivial patches which also touch
MemoryRegionOps and make the code more uniform.

[PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops
[PATCH 2/2] sh7750: Remove redundant 'struct' from MemoryRegionOps

Regards,

Stefan W.

[Qemu-devel] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops

[Stefan Weil]

spin_rw_ops is only used in hw/ppce500_spin.c.

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/ppce500_spin.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c
index 6b8a189..6ed676b 100644
--- a/hw/ppce500_spin.c
+++ b/hw/ppce500_spin.c
@@ -182,7 +182,7 @@ static uint64_t spin_read(void *opaque, target_phys_addr_t addr, unsigned len)
     }
 }
 
-const MemoryRegionOps spin_rw_ops = {
+static const MemoryRegionOps spin_rw_ops = {
     .read = spin_read,
     .write = spin_write,
     .endianness = DEVICE_BIG_ENDIAN,
-- 
1.7.9

[Qemu-devel] [PATCH 2/2] sh7750: Remove redundant 'struct' from MemoryRegionOps

[Stefan Weil]

The 'struct' is not needed, and all other MemoryRegionOps don't use it.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/sh7750.c  |    2 +-
 hw/sh_intc.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sh7750.c b/hw/sh7750.c
index 4f4d8e7..e712928 100644
--- a/hw/sh7750.c
+++ b/hw/sh7750.c
@@ -712,7 +712,7 @@ static void sh7750_mmct_write(void *opaque, target_phys_addr_t addr,
     }
 }
 
-static const struct MemoryRegionOps sh7750_mmct_ops = {
+static const MemoryRegionOps sh7750_mmct_ops = {
     .read = sh7750_mmct_read,
     .write = sh7750_mmct_write,
     .endianness = DEVICE_NATIVE_ENDIAN,
diff --git a/hw/sh_intc.c b/hw/sh_intc.c
index b24ec77..7d31ced 100644
--- a/hw/sh_intc.c
+++ b/hw/sh_intc.c
@@ -283,7 +283,7 @@ static void sh_intc_write(void *opaque, target_phys_addr_t offset,
 #endif
 }
 
-static const struct MemoryRegionOps sh_intc_ops = {
+static const MemoryRegionOps sh_intc_ops = {
     .read = sh_intc_read,
     .write = sh_intc_write,
     .endianness = DEVICE_NATIVE_ENDIAN,
-- 
1.7.9

Re: [Qemu-devel] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops

[Andreas Färber]

Am 25.02.2012 13:37, schrieb Stefan Weil:
> spin_rw_ops is only used in hw/ppce500_spin.c.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Acked-by: Andreas Färber <afaerber@suse.de>

/-F

> ---
>  hw/ppce500_spin.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c
> index 6b8a189..6ed676b 100644
> --- a/hw/ppce500_spin.c
> +++ b/hw/ppce500_spin.c
> @@ -182,7 +182,7 @@ static uint64_t spin_read(void *opaque, target_phys_addr_t addr, unsigned len)
>      }
>  }
>  
> -const MemoryRegionOps spin_rw_ops = {
> +static const MemoryRegionOps spin_rw_ops = {
>      .read = spin_read,
>      .write = spin_write,
>      .endianness = DEVICE_BIG_ENDIAN,

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/2] Trivial MemoryRegionOps patches

[Stefan Hajnoczi]

On Sat, Feb 25, 2012 at 01:37:11PM +0100, Stefan Weil wrote:
> Please apply http://patchwork.ozlabs.org/patch/139660/ to the qemu-trivial
> patch queue. Here are two additional trivial patches which also touch
> MemoryRegionOps and make the code more uniform.
> 
> [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops
> [PATCH 2/2] sh7750: Remove redundant 'struct' from MemoryRegionOps

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan