* [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-26 23:26 Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
` (2 more replies)
0 siblings, 3 replies; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-26 23:26 UTC (permalink / raw)
To: JBottomley, jejb, kyle, deller
Cc: linux-parisc, linux-kernel, linux-next, Paul Gortmaker
Using the 64 bit toolchains from kernel.org[1], one finds that
you can't build the a500_defconfig, because the Makefile will
stomp whatever value you have in your env. for CROSS_COMPILE.
This shows up since the kernel.org toolchains for parisc-64
do not have the "-gnu" prefix, and so you run into it always
saying hppa64-linux-gnu-gcc not found, regardless of the fact
you've not got "-gnu" put anywhere into CROSS_COMPILE.
[1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..cefff6d 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
+ifndef CROSS_COMPILE
+ CROSS_COMPILE := hppa64-linux-gnu-
+endif
else # 32-bit
WIDTH :=
endif
--
1.7.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
@ 2012-02-27 0:23 ` Mike Frysinger
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 15:14 ` John David Anglin
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2 siblings, 1 reply; 25+ messages in thread
From: Mike Frysinger @ 2012-02-27 0:23 UTC (permalink / raw)
To: Paul Gortmaker
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
[-- Attachment #1: Type: Text/Plain, Size: 322 bytes --]
On Sunday 26 February 2012 18:26:53 Paul Gortmaker wrote:
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
>
> -CROSS_COMPILE := hppa64-linux-gnu-
> +ifndef CROSS_COMPILE
> + CROSS_COMPILE := hppa64-linux-gnu-
> +endif
this should accomplish the same thing in practice:
CROSS_COMPILE ?= hppa64-linux-gnu-
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 0:23 ` Mike Frysinger
@ 2012-02-27 0:30 ` Paul Gortmaker
0 siblings, 0 replies; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-27 0:30 UTC (permalink / raw)
To: Mike Frysinger
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
[Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.] On 26/02/2012 (Sun 19:23) Mike Frysinger wrote:
> On Sunday 26 February 2012 18:26:53 Paul Gortmaker wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> >
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > +ifndef CROSS_COMPILE
> > + CROSS_COMPILE := hppa64-linux-gnu-
> > +endif
>
> this should accomplish the same thing in practice:
> CROSS_COMPILE ?= hppa64-linux-gnu-
Good point, I'll wait for a bit in case I was missing something else
obvious, and then resend.
THanks,
P.
> -mike
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 0:30 ` Paul Gortmaker
0 siblings, 0 replies; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-27 0:30 UTC (permalink / raw)
To: Mike Frysinger
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
[Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.] On 26/02/2012 (Sun 19:23) Mike Frysinger wrote:
> On Sunday 26 February 2012 18:26:53 Paul Gortmaker wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> >
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > +ifndef CROSS_COMPILE
> > + CROSS_COMPILE := hppa64-linux-gnu-
> > +endif
>
> this should accomplish the same thing in practice:
> CROSS_COMPILE ?= hppa64-linux-gnu-
Good point, I'll wait for a bit in case I was missing something else
obvious, and then resend.
THanks,
P.
> -mike
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
@ 2012-02-27 15:14 ` John David Anglin
2012-02-27 16:28 ` Paul Gortmaker
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2 siblings, 1 reply; 25+ messages in thread
From: John David Anglin @ 2012-02-27 15:14 UTC (permalink / raw)
To: Paul Gortmaker
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
> Using the 64 bit toolchains from kernel.org[1], one finds that
> you can't build the a500_defconfig, because the Makefile will
> stomp whatever value you have in your env. for CROSS_COMPILE.
>
> This shows up since the kernel.org toolchains for parisc-64
> do not have the "-gnu" prefix, and so you run into it always
> saying hppa64-linux-gnu-gcc not found, regardless of the fact
> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>
> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>
> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..cefff6d 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> -CROSS_COMPILE := hppa64-linux-gnu-
> +ifndef CROSS_COMPILE
> + CROSS_COMPILE := hppa64-linux-gnu-
> +endif
> else # 32-bit
> WIDTH :=
> endif
This change breaks native builds. So, I assume CROSS_COMPILE must be
previously defined.
I couldn't figure out where it is defined. CONFIG_CROSS_COMPILE in my
.config was an empty string and CROSS_COMPILE was not defined in my
build environment.
The default toolchain prefix on Debian systems contains "gnu-".
Given that users can use CONFIG_CROSS_COMPILE or set CROSS_COMPILE
in their build env, maybe setting CROSS_COMPILE in the Makefile is a
mistake.
Dave
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 15:14 ` John David Anglin
@ 2012-02-27 16:28 ` Paul Gortmaker
0 siblings, 0 replies; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-27 16:28 UTC (permalink / raw)
To: John David Anglin
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
On 12-02-27 10:14 AM, John David Anglin wrote:
> On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
>> Using the 64 bit toolchains from kernel.org[1], one finds that
>> you can't build the a500_defconfig, because the Makefile will
>> stomp whatever value you have in your env. for CROSS_COMPILE.
>>
>> This shows up since the kernel.org toolchains for parisc-64
>> do not have the "-gnu" prefix, and so you run into it always
>> saying hppa64-linux-gnu-gcc not found, regardless of the fact
>> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>>
>> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>
>> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>> index 55cca1d..cefff6d 100644
>> --- a/arch/parisc/Makefile
>> +++ b/arch/parisc/Makefile
>> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
>> UTS_MACHINE := parisc64
>> CHECKFLAGS += -D__LP64__=1 -m64
>> WIDTH := 64
>> -CROSS_COMPILE := hppa64-linux-gnu-
>> +ifndef CROSS_COMPILE
>> + CROSS_COMPILE := hppa64-linux-gnu-
>> +endif
>> else # 32-bit
>> WIDTH :=
>> endif
> This change breaks native builds. So, I assume CROSS_COMPILE must be
> previously defined.
You lost me here. As in a native 32bit env. doing a build for the
64 bit case is setting CROSS_COMPILE?
>
> I couldn't figure out where it is defined. CONFIG_CROSS_COMPILE in my
> .config was an empty string and CROSS_COMPILE was not defined in my
> build environment.
>
> The default toolchain prefix on Debian systems contains "gnu-".
>
> Given that users can use CONFIG_CROSS_COMPILE or set CROSS_COMPILE
> in their build env, maybe setting CROSS_COMPILE in the Makefile is a
> mistake.
Yeah, I'd support a complete nuke-and-pave of the whole Makefile
chunk as well. It does seem redundant and causes more issues than
it solves.
Paul.
>
> Dave
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 16:28 ` Paul Gortmaker
0 siblings, 0 replies; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-27 16:28 UTC (permalink / raw)
To: John David Anglin
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
On 12-02-27 10:14 AM, John David Anglin wrote:
> On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
>> Using the 64 bit toolchains from kernel.org[1], one finds that
>> you can't build the a500_defconfig, because the Makefile will
>> stomp whatever value you have in your env. for CROSS_COMPILE.
>>
>> This shows up since the kernel.org toolchains for parisc-64
>> do not have the "-gnu" prefix, and so you run into it always
>> saying hppa64-linux-gnu-gcc not found, regardless of the fact
>> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>>
>> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>>
>> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>
>> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>> index 55cca1d..cefff6d 100644
>> --- a/arch/parisc/Makefile
>> +++ b/arch/parisc/Makefile
>> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
>> UTS_MACHINE := parisc64
>> CHECKFLAGS += -D__LP64__=1 -m64
>> WIDTH := 64
>> -CROSS_COMPILE := hppa64-linux-gnu-
>> +ifndef CROSS_COMPILE
>> + CROSS_COMPILE := hppa64-linux-gnu-
>> +endif
>> else # 32-bit
>> WIDTH :=
>> endif
> This change breaks native builds. So, I assume CROSS_COMPILE must be
> previously defined.
You lost me here. As in a native 32bit env. doing a build for the
64 bit case is setting CROSS_COMPILE?
>
> I couldn't figure out where it is defined. CONFIG_CROSS_COMPILE in my
> .config was an empty string and CROSS_COMPILE was not defined in my
> build environment.
>
> The default toolchain prefix on Debian systems contains "gnu-".
>
> Given that users can use CONFIG_CROSS_COMPILE or set CROSS_COMPILE
> in their build env, maybe setting CROSS_COMPILE in the Makefile is a
> mistake.
Yeah, I'd support a complete nuke-and-pave of the whole Makefile
chunk as well. It does seem redundant and causes more issues than
it solves.
Paul.
>
> Dave
>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 16:28 ` Paul Gortmaker
(?)
@ 2012-02-27 16:45 ` John David Anglin
-1 siblings, 0 replies; 25+ messages in thread
From: John David Anglin @ 2012-02-27 16:45 UTC (permalink / raw)
To: Paul Gortmaker
Cc: JBottomley, jejb, kyle, deller, linux-parisc, linux-kernel, linux-next
On 2/27/2012 11:28 AM, Paul Gortmaker wrote:
> On 12-02-27 10:14 AM, John David Anglin wrote:
>> > On 2/26/2012 6:26 PM, Paul Gortmaker wrote:
>>> >> Using the 64 bit toolchains from kernel.org[1], one finds that
>>> >> you can't build the a500_defconfig, because the Makefile will
>>> >> stomp whatever value you have in your env. for CROSS_COMPILE.
>>> >>
>>> >> This shows up since the kernel.org toolchains for parisc-64
>>> >> do not have the "-gnu" prefix, and so you run into it always
>>> >> saying hppa64-linux-gnu-gcc not found, regardless of the fact
>>> >> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>>> >>
>>> >> [1]ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>>> >>
>>> >> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>>> >>
>>> >> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>>> >> index 55cca1d..cefff6d 100644
>>> >> --- a/arch/parisc/Makefile
>>> >> +++ b/arch/parisc/Makefile
>>> >> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT
>>> >> UTS_MACHINE := parisc64
>>> >> CHECKFLAGS += -D__LP64__=1 -m64
>>> >> WIDTH := 64
>>> >> -CROSS_COMPILE := hppa64-linux-gnu-
>>> >> +ifndef CROSS_COMPILE
>>> >> + CROSS_COMPILE := hppa64-linux-gnu-
>>> >> +endif
>>> >> else # 32-bit
>>> >> WIDTH :=
>>> >> endif
>> > This change breaks native builds. So, I assume CROSS_COMPILE must be
>> > previously defined.
> You lost me here. As in a native 32bit env. doing a build for the
> 64 bit case is setting CROSS_COMPILE?
>
Yes, native hppa is 32 bit . Building a 64-bit kernel with CONFIG_64BIT
causes the
setting of CROSS_COMPILE and the selection of hppa64-linux-gnu-gcc, etc.
If CROSS_COMPILE wasn't previously defined, your change wouldn't have have
affected the 64-bit build.
Dave
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
2012-02-27 15:14 ` John David Anglin
@ 2012-02-27 20:59 ` Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
2 siblings, 1 reply; 25+ messages in thread
From: Paul Gortmaker @ 2012-02-27 20:59 UTC (permalink / raw)
To: JBottomley, jejb, kyle, deller
Cc: vapier, dave.anglin, linux-parisc, linux-kernel, linux-next,
Paul Gortmaker
Using the 64 bit toolchains from kernel.org[1], one finds that
you can't build the a500_defconfig, because the Makefile will
stomp whatever value you have in your env. for CROSS_COMPILE.
This shows up since the kernel.org toolchains for parisc-64
do not have the "-gnu" prefix, and so you run into it always
saying hppa64-linux-gnu-gcc not found, regardless of the fact
you've not got "-gnu" put anywhere into CROSS_COMPILE.
Since you can set CROSS_COMPILE from the environment and/or set
it in your .config file, there really is no need for it to be
poked at by the Makefile at all. So just delete it.
[1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[v2: no ifdef/endif -- just delete the offending line.]
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..a533367 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
else # 32-bit
WIDTH :=
endif
--
1.7.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
@ 2012-02-27 21:41 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 21:41 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
T24gTW9uLCAyMDEyLTAyLTI3IGF0IDE1OjU5IC0wNTAwLCBQYXVsIEdvcnRtYWtlciB3cm90ZToN
Cj4gVXNpbmcgdGhlIDY0IGJpdCB0b29sY2hhaW5zIGZyb20ga2VybmVsLm9yZ1sxXSwgb25lIGZp
bmRzIHRoYXQNCj4geW91IGNhbid0IGJ1aWxkIHRoZSBhNTAwX2RlZmNvbmZpZywgYmVjYXVzZSB0
aGUgTWFrZWZpbGUgd2lsbA0KPiBzdG9tcCB3aGF0ZXZlciB2YWx1ZSB5b3UgaGF2ZSBpbiB5b3Vy
IGVudi4gZm9yIENST1NTX0NPTVBJTEUuDQo+IA0KPiBUaGlzIHNob3dzIHVwIHNpbmNlIHRoZSBr
ZXJuZWwub3JnIHRvb2xjaGFpbnMgZm9yIHBhcmlzYy02NA0KPiBkbyBub3QgaGF2ZSB0aGUgIi1n
bnUiIHByZWZpeCwgYW5kIHNvIHlvdSBydW4gaW50byBpdCBhbHdheXMNCj4gc2F5aW5nIGhwcGE2
NC1saW51eC1nbnUtZ2NjIG5vdCBmb3VuZCwgcmVnYXJkbGVzcyBvZiB0aGUgZmFjdA0KPiB5b3Un
dmUgbm90IGdvdCAiLWdudSIgcHV0IGFueXdoZXJlIGludG8gQ1JPU1NfQ09NUElMRS4NCj4gDQo+
IFNpbmNlIHlvdSBjYW4gc2V0IENST1NTX0NPTVBJTEUgZnJvbSB0aGUgZW52aXJvbm1lbnQgYW5k
L29yIHNldA0KPiBpdCBpbiB5b3VyIC5jb25maWcgZmlsZSwgdGhlcmUgcmVhbGx5IGlzIG5vIG5l
ZWQgZm9yIGl0IHRvIGJlDQo+IHBva2VkIGF0IGJ5IHRoZSBNYWtlZmlsZSBhdCBhbGwuICBTbyBq
dXN0IGRlbGV0ZSBpdC4NCj4gDQo+IFsxXSBmdHA6Ly9mdHAua2VybmVsLm9yZy9wdWIvdG9vbHMv
Y3Jvc3N0b29sL2ZpbGVzL2Jpbi94ODZfNjQvNC41LjIvDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBQ
YXVsIEdvcnRtYWtlciA8cGF1bC5nb3J0bWFrZXJAd2luZHJpdmVyLmNvbT4NCj4gLS0tDQo+IA0K
PiBbdjI6IG5vIGlmZGVmL2VuZGlmIC0tIGp1c3QgZGVsZXRlIHRoZSBvZmZlbmRpbmcgbGluZS5d
DQo+IA0KPiBkaWZmIC0tZ2l0IGEvYXJjaC9wYXJpc2MvTWFrZWZpbGUgYi9hcmNoL3BhcmlzYy9N
YWtlZmlsZQ0KPiBpbmRleCA1NWNjYTFkLi5hNTMzMzY3IDEwMDY0NA0KPiAtLS0gYS9hcmNoL3Bh
cmlzYy9NYWtlZmlsZQ0KPiArKysgYi9hcmNoL3BhcmlzYy9NYWtlZmlsZQ0KPiBAQCAtMzEsNyAr
MzEsNiBAQCBpZmRlZiBDT05GSUdfNjRCSVQNCj4gIFVUU19NQUNISU5FCTo9IHBhcmlzYzY0DQo+
ICBDSEVDS0ZMQUdTCSs9IC1EX19MUDY0X189MSAtbTY0DQo+ICBXSURUSAkJOj0gNjQNCj4gLUNS
T1NTX0NPTVBJTEUJOj0gaHBwYTY0LWxpbnV4LWdudS0NCj4gIGVsc2UgIyAzMi1iaXQNCj4gIFdJ
RFRICQk6PQ0KPiAgZW5kaWYNCg0KV2UgY2FuJ3QgZG8gdGhhdCAuLi4gaXQgY3Jhc2hlcyBhIHN0
YW5kYXJkIGJ1aWxkIGFsbW9zdCBpbW1lZGlhdGVseQ0KYmVjYXVzZSBpdCBkb2Vzbid0IHBpY2sg
dGhlIDY0IGJpdCBjb21waWxlciAoYW5kIHdlIGhhdmUgbm8gYmlhcmNoDQpzb2x1dGlvbikuDQoN
CldlIG5lZWQgbWFrZSBvbiBhIDY0IGJpdCBjb25maWcgdG8gd29yayBvdXQgb2YgdGhlIGJveC4g
IEl0IGJyZWFrcw0Kd2l0aCA/PSBhcyBKREEgcG9pbnRlZCBvdXQgYmVjYXVzZSBDUk9TU19DT01Q
SUxFIGlzIGFsd2F5cyBkZWZpbmVkLg0KRG9lcyB0aGlzIHNhdGlzZnkgZXZlcnlvbmU/DQoNCkph
bWVzDQoNCi0tLQ0KDQpkaWZmIC0tZ2l0IGEvYXJjaC9wYXJpc2MvTWFrZWZpbGUgYi9hcmNoL3Bh
cmlzYy9NYWtlZmlsZQ0KaW5kZXggNTVjY2ExZC4uMTlhYjdiMiAxMDA2NDQNCi0tLSBhL2FyY2gv
cGFyaXNjL01ha2VmaWxlDQorKysgYi9hcmNoL3BhcmlzYy9NYWtlZmlsZQ0KQEAgLTMxLDcgKzMx
LDExIEBAIGlmZGVmIENPTkZJR182NEJJVA0KIFVUU19NQUNISU5FCTo9IHBhcmlzYzY0DQogQ0hF
Q0tGTEFHUwkrPSAtRF9fTFA2NF9fPTEgLW02NA0KIFdJRFRICQk6PSA2NA0KKw0KKyMgRklYTUU6
IGlmIG5vIGRlZmF1bHQgc2V0LCBzaG91bGQgcmVhbGx5IHRyeSB0byBsb2NhdGUgZHluYW1pY2Fs
bHkNCitpZmVxICgkKENST1NTX0NPTVBJTEUpLCkNCiBDUk9TU19DT01QSUxFCTo9IGhwcGE2NC1s
aW51eC1nbnUtDQorZW5kaWYNCiBlbHNlICMgMzItYml0DQogV0lEVEgJCTo9DQogZW5kaWYNCg0K
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 21:41 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 21:41 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2149 bytes --]
On Mon, 2012-02-27 at 15:59 -0500, Paul Gortmaker wrote:
> Using the 64 bit toolchains from kernel.org[1], one finds that
> you can't build the a500_defconfig, because the Makefile will
> stomp whatever value you have in your env. for CROSS_COMPILE.
>
> This shows up since the kernel.org toolchains for parisc-64
> do not have the "-gnu" prefix, and so you run into it always
> saying hppa64-linux-gnu-gcc not found, regardless of the fact
> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>
> Since you can set CROSS_COMPILE from the environment and/or set
> it in your .config file, there really is no need for it to be
> poked at by the Makefile at all. So just delete it.
>
> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [v2: no ifdef/endif -- just delete the offending line.]
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..a533367 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> -CROSS_COMPILE := hppa64-linux-gnu-
> else # 32-bit
> WIDTH :=
> endif
We can't do that ... it crashes a standard build almost immediately
because it doesn't pick the 64 bit compiler (and we have no biarch
solution).
We need make on a 64 bit config to work out of the box. It breaks
with ?= as JDA pointed out because CROSS_COMPILE is always defined.
Does this satisfy everyone?
James
---
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..19ab7b2 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -31,7 +31,11 @@ ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
+
+# FIXME: if no default set, should really try to locate dynamically
+ifeq ($(CROSS_COMPILE),)
CROSS_COMPILE := hppa64-linux-gnu-
+endif
else # 32-bit
WIDTH :=
endif
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 21:41 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 21:41 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
On Mon, 2012-02-27 at 15:59 -0500, Paul Gortmaker wrote:
> Using the 64 bit toolchains from kernel.org[1], one finds that
> you can't build the a500_defconfig, because the Makefile will
> stomp whatever value you have in your env. for CROSS_COMPILE.
>
> This shows up since the kernel.org toolchains for parisc-64
> do not have the "-gnu" prefix, and so you run into it always
> saying hppa64-linux-gnu-gcc not found, regardless of the fact
> you've not got "-gnu" put anywhere into CROSS_COMPILE.
>
> Since you can set CROSS_COMPILE from the environment and/or set
> it in your .config file, there really is no need for it to be
> poked at by the Makefile at all. So just delete it.
>
> [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [v2: no ifdef/endif -- just delete the offending line.]
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..a533367 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> -CROSS_COMPILE := hppa64-linux-gnu-
> else # 32-bit
> WIDTH :=
> endif
We can't do that ... it crashes a standard build almost immediately
because it doesn't pick the 64 bit compiler (and we have no biarch
solution).
We need make on a 64 bit config to work out of the box. It breaks
with ?= as JDA pointed out because CROSS_COMPILE is always defined.
Does this satisfy everyone?
James
---
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..19ab7b2 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -31,7 +31,11 @@ ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
+
+# FIXME: if no default set, should really try to locate dynamically
+ifeq ($(CROSS_COMPILE),)
CROSS_COMPILE := hppa64-linux-gnu-
+endif
else # 32-bit
WIDTH :=
endif
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 21:41 ` James Bottomley
(?)
@ 2012-02-27 22:03 ` James Bottomley
-1 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 22:03 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
T24gTW9uLCAyMDEyLTAyLTI3IGF0IDIxOjQxICswMDAwLCBKYW1lcyBCb3R0b21sZXkgd3JvdGU6
DQo+IE9uIE1vbiwgMjAxMi0wMi0yNyBhdCAxNTo1OSAtMDUwMCwgUGF1bCBHb3J0bWFrZXIgd3Jv
dGU6DQo+ID4gVXNpbmcgdGhlIDY0IGJpdCB0b29sY2hhaW5zIGZyb20ga2VybmVsLm9yZ1sxXSwg
b25lIGZpbmRzIHRoYXQNCj4gPiB5b3UgY2FuJ3QgYnVpbGQgdGhlIGE1MDBfZGVmY29uZmlnLCBi
ZWNhdXNlIHRoZSBNYWtlZmlsZSB3aWxsDQo+ID4gc3RvbXAgd2hhdGV2ZXIgdmFsdWUgeW91IGhh
dmUgaW4geW91ciBlbnYuIGZvciBDUk9TU19DT01QSUxFLg0KPiA+IA0KPiA+IFRoaXMgc2hvd3Mg
dXAgc2luY2UgdGhlIGtlcm5lbC5vcmcgdG9vbGNoYWlucyBmb3IgcGFyaXNjLTY0DQo+ID4gZG8g
bm90IGhhdmUgdGhlICItZ251IiBwcmVmaXgsIGFuZCBzbyB5b3UgcnVuIGludG8gaXQgYWx3YXlz
DQo+ID4gc2F5aW5nIGhwcGE2NC1saW51eC1nbnUtZ2NjIG5vdCBmb3VuZCwgcmVnYXJkbGVzcyBv
ZiB0aGUgZmFjdA0KPiA+IHlvdSd2ZSBub3QgZ290ICItZ251IiBwdXQgYW55d2hlcmUgaW50byBD
Uk9TU19DT01QSUxFLg0KPiA+IA0KPiA+IFNpbmNlIHlvdSBjYW4gc2V0IENST1NTX0NPTVBJTEUg
ZnJvbSB0aGUgZW52aXJvbm1lbnQgYW5kL29yIHNldA0KPiA+IGl0IGluIHlvdXIgLmNvbmZpZyBm
aWxlLCB0aGVyZSByZWFsbHkgaXMgbm8gbmVlZCBmb3IgaXQgdG8gYmUNCj4gPiBwb2tlZCBhdCBi
eSB0aGUgTWFrZWZpbGUgYXQgYWxsLiAgU28ganVzdCBkZWxldGUgaXQuDQo+ID4gDQo+ID4gWzFd
IGZ0cDovL2Z0cC5rZXJuZWwub3JnL3B1Yi90b29scy9jcm9zc3Rvb2wvZmlsZXMvYmluL3g4Nl82
NC80LjUuMi8NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEdvcnRtYWtlciA8cGF1bC5n
b3J0bWFrZXJAd2luZHJpdmVyLmNvbT4NCj4gPiAtLS0NCj4gPiANCj4gPiBbdjI6IG5vIGlmZGVm
L2VuZGlmIC0tIGp1c3QgZGVsZXRlIHRoZSBvZmZlbmRpbmcgbGluZS5dDQo+ID4gDQo+ID4gZGlm
ZiAtLWdpdCBhL2FyY2gvcGFyaXNjL01ha2VmaWxlIGIvYXJjaC9wYXJpc2MvTWFrZWZpbGUNCj4g
PiBpbmRleCA1NWNjYTFkLi5hNTMzMzY3IDEwMDY0NA0KPiA+IC0tLSBhL2FyY2gvcGFyaXNjL01h
a2VmaWxlDQo+ID4gKysrIGIvYXJjaC9wYXJpc2MvTWFrZWZpbGUNCj4gPiBAQCAtMzEsNyArMzEs
NiBAQCBpZmRlZiBDT05GSUdfNjRCSVQNCj4gPiAgVVRTX01BQ0hJTkUJOj0gcGFyaXNjNjQNCj4g
PiAgQ0hFQ0tGTEFHUwkrPSAtRF9fTFA2NF9fPTEgLW02NA0KPiA+ICBXSURUSAkJOj0gNjQNCj4g
PiAtQ1JPU1NfQ09NUElMRQk6PSBocHBhNjQtbGludXgtZ251LQ0KPiA+ICBlbHNlICMgMzItYml0
DQo+ID4gIFdJRFRICQk6PQ0KPiA+ICBlbmRpZg0KPiANCj4gV2UgY2FuJ3QgZG8gdGhhdCAuLi4g
aXQgY3Jhc2hlcyBhIHN0YW5kYXJkIGJ1aWxkIGFsbW9zdCBpbW1lZGlhdGVseQ0KPiBiZWNhdXNl
IGl0IGRvZXNuJ3QgcGljayB0aGUgNjQgYml0IGNvbXBpbGVyIChhbmQgd2UgaGF2ZSBubyBiaWFy
Y2gNCj4gc29sdXRpb24pLg0KPiANCj4gV2UgbmVlZCBtYWtlIG9uIGEgNjQgYml0IGNvbmZpZyB0
byB3b3JrIG91dCBvZiB0aGUgYm94LiAgSXQgYnJlYWtzDQo+IHdpdGggPz0gYXMgSkRBIHBvaW50
ZWQgb3V0IGJlY2F1c2UgQ1JPU1NfQ09NUElMRSBpcyBhbHdheXMgZGVmaW5lZC4NCj4gRG9lcyB0
aGlzIHNhdGlzZnkgZXZlcnlvbmU/DQo+IA0KPiBKYW1lcw0KPiANCj4gLS0tDQo+IA0KPiBkaWZm
IC0tZ2l0IGEvYXJjaC9wYXJpc2MvTWFrZWZpbGUgYi9hcmNoL3BhcmlzYy9NYWtlZmlsZQ0KPiBp
bmRleCA1NWNjYTFkLi4xOWFiN2IyIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3BhcmlzYy9NYWtlZmls
ZQ0KPiArKysgYi9hcmNoL3BhcmlzYy9NYWtlZmlsZQ0KPiBAQCAtMzEsNyArMzEsMTEgQEAgaWZk
ZWYgQ09ORklHXzY0QklUDQo+ICBVVFNfTUFDSElORQk6PSBwYXJpc2M2NA0KPiAgQ0hFQ0tGTEFH
UwkrPSAtRF9fTFA2NF9fPTEgLW02NA0KPiAgV0lEVEgJCTo9IDY0DQo+ICsNCj4gKyMgRklYTUU6
IGlmIG5vIGRlZmF1bHQgc2V0LCBzaG91bGQgcmVhbGx5IHRyeSB0byBsb2NhdGUgZHluYW1pY2Fs
bHkNCj4gK2lmZXEgKCQoQ1JPU1NfQ09NUElMRSksKQ0KPiAgQ1JPU1NfQ09NUElMRQk6PSBocHBh
NjQtbGludXgtZ251LQ0KPiArZW5kaWYNCj4gIGVsc2UgIyAzMi1iaXQNCj4gIFdJRFRICQk6PQ0K
PiAgZW5kaWYNCg0KVGhlcmUncyBhbiBhd2Z1bCBsb3QgbW9yZSB0aGFuIGp1c3QgdGhpcyB3cm9u
ZyB3aXRoIHRoYXQgTWFrZWZpbGUuICBGb3INCmluc3RhbmNlLCBOQVRJVkUgY2FuIG5ldmVyIGJl
IHNldCBiZWNhdXNlIGlmZXEoKSBpc24ndCBnbG9iYmluZyBpbiBtYWtlDQpzY3JpcHRzIC4uLiAg
U28gSSB0aGluayBhIGZpbmFsIChhbmQgZHluYW1pY2FsbHkgY2hvb3NpbmcgaWYgdW5zZXQpDQpz
b2x1dGlvbiBpcyB0aGlzIG9uZS4NCg0KSSdsbCBzdG9wIG5vdyBiZWZvcmUgSSBmaW5kIHNvbWV0
aGluZyBlbHNlIHdyb25nIC4uLg0KDQpKYW1lcw0KDQotLS0NCg0KZGlmZiAtLWdpdCBhL2FyY2gv
cGFyaXNjL01ha2VmaWxlIGIvYXJjaC9wYXJpc2MvTWFrZWZpbGUNCmluZGV4IDU1Y2NhMWQuLmM4
MjNmNGEgMTAwNjQ0DQotLS0gYS9hcmNoL3BhcmlzYy9NYWtlZmlsZQ0KKysrIGIvYXJjaC9wYXJp
c2MvTWFrZWZpbGUNCkBAIC0yMywyNCArMjMsMjAgQEAgTk0JCT0gc2ggJChzcmN0cmVlKS9hcmNo
L3BhcmlzYy9ubQ0KIENIRUNLRkxBR1MJKz0gLURfX2hwcGFfXz0xDQogDQogTUFDSElORQkJOj0g
JChzaGVsbCB1bmFtZSAtbSkNCi1pZmVxICgkKE1BQ0hJTkUpLHBhcmlzYyopDQotTkFUSVZFCQk6
PSAxDQotZW5kaWYNCiANCiBpZmRlZiBDT05GSUdfNjRCSVQNCiBVVFNfTUFDSElORQk6PSBwYXJp
c2M2NA0KIENIRUNLRkxBR1MJKz0gLURfX0xQNjRfXz0xIC1tNjQNCiBXSURUSAkJOj0gNjQNCi1D
Uk9TU19DT01QSUxFCTo9IGhwcGE2NC1saW51eC1nbnUtDQorDQorIyBpZiBubyBkZWZhdWx0IHNl
dCwgdHJ5IHRvIGZpbmQgdGhlIGNvcnJlc3BvbmRpbmcgNjQgYml0IGNvbXBpbGVyDQoraWZlcSAo
JChDUk9TU19DT01QSUxFKSwpDQorQ1JPU1NfQ09NUElMRQk6PSAkKHNoZWxsICQoQ0MpIC1kdW1w
bWFjaGluZSB8IHNlZCBzL2hwcGEtXFxcKC4qXFxcKS9ocHBhNjQtXFwxLS8pDQorZW5kaWYNCiBl
bHNlICMgMzItYml0DQogV0lEVEgJCTo9DQogZW5kaWYNCiANCi0jIGF0dGVtcHQgdG8gaGVscCBv
dXQgZm9sa3Mgd2hvIGFyZSBjcm9zcy1jb21waWxpbmcNCi1pZmVxICgkKE5BVElWRSksMSkNCi1D
Uk9TU19DT01QSUxFCTo9IGhwcGEkKFdJRFRIKS1saW51eC0NCi1lbmRpZg0KLQ0KIE9CSkNPUFlf
RkxBR1MgPS1PIGJpbmFyeSAtUiAubm90ZSAtUiAuY29tbWVudCAtUw0KIA0KIGNmbGFncy15CTo9
IC1waXBlDQoNCg0KDQo=
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 22:03 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 22:03 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3482 bytes --]
On Mon, 2012-02-27 at 21:41 +0000, James Bottomley wrote:
> On Mon, 2012-02-27 at 15:59 -0500, Paul Gortmaker wrote:
> > Using the 64 bit toolchains from kernel.org[1], one finds that
> > you can't build the a500_defconfig, because the Makefile will
> > stomp whatever value you have in your env. for CROSS_COMPILE.
> >
> > This shows up since the kernel.org toolchains for parisc-64
> > do not have the "-gnu" prefix, and so you run into it always
> > saying hppa64-linux-gnu-gcc not found, regardless of the fact
> > you've not got "-gnu" put anywhere into CROSS_COMPILE.
> >
> > Since you can set CROSS_COMPILE from the environment and/or set
> > it in your .config file, there really is no need for it to be
> > poked at by the Makefile at all. So just delete it.
> >
> > [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> >
> > [v2: no ifdef/endif -- just delete the offending line.]
> >
> > diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> > index 55cca1d..a533367 100644
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> > @@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
> > UTS_MACHINE := parisc64
> > CHECKFLAGS += -D__LP64__=1 -m64
> > WIDTH := 64
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > else # 32-bit
> > WIDTH :=
> > endif
>
> We can't do that ... it crashes a standard build almost immediately
> because it doesn't pick the 64 bit compiler (and we have no biarch
> solution).
>
> We need make on a 64 bit config to work out of the box. It breaks
> with ?= as JDA pointed out because CROSS_COMPILE is always defined.
> Does this satisfy everyone?
>
> James
>
> ---
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..19ab7b2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,11 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> +
> +# FIXME: if no default set, should really try to locate dynamically
> +ifeq ($(CROSS_COMPILE),)
> CROSS_COMPILE := hppa64-linux-gnu-
> +endif
> else # 32-bit
> WIDTH :=
> endif
There's an awful lot more than just this wrong with that Makefile. For
instance, NATIVE can never be set because ifeq() isn't globbing in make
scripts ... So I think a final (and dynamically choosing if unset)
solution is this one.
I'll stop now before I find something else wrong ...
James
---
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..c823f4a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -23,24 +23,20 @@ NM = sh $(srctree)/arch/parisc/nm
CHECKFLAGS += -D__hppa__=1
MACHINE := $(shell uname -m)
-ifeq ($(MACHINE),parisc*)
-NATIVE := 1
-endif
ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
+
+# if no default set, try to find the corresponding 64 bit compiler
+ifeq ($(CROSS_COMPILE),)
+CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
+endif
else # 32-bit
WIDTH :=
endif
-# attempt to help out folks who are cross-compiling
-ifeq ($(NATIVE),1)
-CROSS_COMPILE := hppa$(WIDTH)-linux-
-endif
-
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
cflags-y := -pipe
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-27 22:03 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-27 22:03 UTC (permalink / raw)
To: Paul Gortmaker
Cc: kyle, deller, vapier, dave.anglin, linux-parisc, linux-kernel,
linux-next
On Mon, 2012-02-27 at 21:41 +0000, James Bottomley wrote:
> On Mon, 2012-02-27 at 15:59 -0500, Paul Gortmaker wrote:
> > Using the 64 bit toolchains from kernel.org[1], one finds that
> > you can't build the a500_defconfig, because the Makefile will
> > stomp whatever value you have in your env. for CROSS_COMPILE.
> >
> > This shows up since the kernel.org toolchains for parisc-64
> > do not have the "-gnu" prefix, and so you run into it always
> > saying hppa64-linux-gnu-gcc not found, regardless of the fact
> > you've not got "-gnu" put anywhere into CROSS_COMPILE.
> >
> > Since you can set CROSS_COMPILE from the environment and/or set
> > it in your .config file, there really is no need for it to be
> > poked at by the Makefile at all. So just delete it.
> >
> > [1] ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/
> >
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > ---
> >
> > [v2: no ifdef/endif -- just delete the offending line.]
> >
> > diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> > index 55cca1d..a533367 100644
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> > @@ -31,7 +31,6 @@ ifdef CONFIG_64BIT
> > UTS_MACHINE := parisc64
> > CHECKFLAGS += -D__LP64__=1 -m64
> > WIDTH := 64
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > else # 32-bit
> > WIDTH :=
> > endif
>
> We can't do that ... it crashes a standard build almost immediately
> because it doesn't pick the 64 bit compiler (and we have no biarch
> solution).
>
> We need make on a 64 bit config to work out of the box. It breaks
> with ?= as JDA pointed out because CROSS_COMPILE is always defined.
> Does this satisfy everyone?
>
> James
>
> ---
>
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 55cca1d..19ab7b2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -31,7 +31,11 @@ ifdef CONFIG_64BIT
> UTS_MACHINE := parisc64
> CHECKFLAGS += -D__LP64__=1 -m64
> WIDTH := 64
> +
> +# FIXME: if no default set, should really try to locate dynamically
> +ifeq ($(CROSS_COMPILE),)
> CROSS_COMPILE := hppa64-linux-gnu-
> +endif
> else # 32-bit
> WIDTH :=
> endif
There's an awful lot more than just this wrong with that Makefile. For
instance, NATIVE can never be set because ifeq() isn't globbing in make
scripts ... So I think a final (and dynamically choosing if unset)
solution is this one.
I'll stop now before I find something else wrong ...
James
---
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 55cca1d..c823f4a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -23,24 +23,20 @@ NM = sh $(srctree)/arch/parisc/nm
CHECKFLAGS += -D__hppa__=1
MACHINE := $(shell uname -m)
-ifeq ($(MACHINE),parisc*)
-NATIVE := 1
-endif
ifdef CONFIG_64BIT
UTS_MACHINE := parisc64
CHECKFLAGS += -D__LP64__=1 -m64
WIDTH := 64
-CROSS_COMPILE := hppa64-linux-gnu-
+
+# if no default set, try to find the corresponding 64 bit compiler
+ifeq ($(CROSS_COMPILE),)
+CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
+endif
else # 32-bit
WIDTH :=
endif
-# attempt to help out folks who are cross-compiling
-ifeq ($(NATIVE),1)
-CROSS_COMPILE := hppa$(WIDTH)-linux-
-endif
-
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
cflags-y := -pipe
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-27 22:03 ` James Bottomley
(?)
(?)
@ 2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
-1 siblings, 1 reply; 25+ messages in thread
From: Mike Frysinger @ 2012-02-28 1:04 UTC (permalink / raw)
To: James Bottomley
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
[-- Attachment #1: Type: Text/Plain, Size: 532 bytes --]
On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
>
> -CROSS_COMPILE := hppa64-linux-gnu-
> +
> +# if no default set, try to find the corresponding 64 bit compiler
> +ifeq ($(CROSS_COMPILE),)
> +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
> +endif
fails when using "hppa2.0-xxx". perhaps:
CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/')
don't even need the ifeq check then
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
@ 2012-02-28 3:17 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-28 3:17 UTC (permalink / raw)
To: Mike Frysinger
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
T24gTW9uLCAyMDEyLTAyLTI3IGF0IDIwOjA0IC0wNTAwLCBNaWtlIEZyeXNpbmdlciB3cm90ZToN
Cj4gT24gTW9uZGF5IDI3IEZlYnJ1YXJ5IDIwMTIgMTc6MDM6MTAgSmFtZXMgQm90dG9tbGV5IHdy
b3RlOg0KPiA+IC0tLSBhL2FyY2gvcGFyaXNjL01ha2VmaWxlDQo+ID4gKysrIGIvYXJjaC9wYXJp
c2MvTWFrZWZpbGUNCj4gPiANCj4gPiAtQ1JPU1NfQ09NUElMRQk6PSBocHBhNjQtbGludXgtZ251
LQ0KPiA+ICsNCj4gPiArIyBpZiBubyBkZWZhdWx0IHNldCwgdHJ5IHRvIGZpbmQgdGhlIGNvcnJl
c3BvbmRpbmcgNjQgYml0IGNvbXBpbGVyDQo+ID4gK2lmZXEgKCQoQ1JPU1NfQ09NUElMRSksKQ0K
PiA+ICtDUk9TU19DT01QSUxFCTo9ICQoc2hlbGwgJChDQykgLWR1bXBtYWNoaW5lIHwgc2VkIHMv
aHBwYS1cXFwoLipcXFwpL2hwcGE2NC1cXDEtLykNCj4gPiArZW5kaWYNCj4gDQo+IGZhaWxzIHdo
ZW4gdXNpbmcgImhwcGEyLjAteHh4Ii4gIHBlcmhhcHM6DQo+IENST1NTX0NPTVBJTEUgPz0gJChz
aGVsbCAkKENDKSAtZHVtcG1hY2hpbmUgfCBzZWQgJ3MvXmhwcGFbXi1dKi0vaHBwYTY0LS8nKQ0K
PiANCj4gZG9uJ3QgZXZlbiBuZWVkIHRoZSBpZmVxIGNoZWNrIHRoZW4NCg0KSG93IGlzIHRoYXQg
ZGlmZmVyZW50IGZyb20gQ2FybG9zJyBzdWdnZXN0aW9uPyAgVGhlIHJlYXNvbiBpdCBkb2Vzbid0
DQp3b3JrIGlzIHRoZSBzYW1lIC4uLiBDUk9TU19DT01QSUxFIGlzIGRlZmluZWQgdG8gYmUgZW1w
dHkuDQoNCkphbWVzDQoNCg==
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-28 3:17 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-28 3:17 UTC (permalink / raw)
To: Mike Frysinger
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 895 bytes --]
On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> >
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > +
> > +# if no default set, try to find the corresponding 64 bit compiler
> > +ifeq ($(CROSS_COMPILE),)
> > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
> > +endif
>
> fails when using "hppa2.0-xxx". perhaps:
> CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/')
>
> don't even need the ifeq check then
How is that different from Carlos' suggestion? The reason it doesn't
work is the same ... CROSS_COMPILE is defined to be empty.
James
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
@ 2012-02-28 3:17 ` James Bottomley
0 siblings, 0 replies; 25+ messages in thread
From: James Bottomley @ 2012-02-28 3:17 UTC (permalink / raw)
To: Mike Frysinger
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > --- a/arch/parisc/Makefile
> > +++ b/arch/parisc/Makefile
> >
> > -CROSS_COMPILE := hppa64-linux-gnu-
> > +
> > +# if no default set, try to find the corresponding 64 bit compiler
> > +ifeq ($(CROSS_COMPILE),)
> > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed s/hppa-\\\(.*\\\)/hppa64-\\1-/)
> > +endif
>
> fails when using "hppa2.0-xxx". perhaps:
> CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed 's/^hppa[^-]*-/hppa64-/')
>
> don't even need the ifeq check then
How is that different from Carlos' suggestion? The reason it doesn't
work is the same ... CROSS_COMPILE is defined to be empty.
James
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 3:17 ` James Bottomley
(?)
(?)
@ 2012-02-28 6:06 ` Mike Frysinger
2012-02-28 14:10 ` James Bottomley
-1 siblings, 1 reply; 25+ messages in thread
From: Mike Frysinger @ 2012-02-28 6:06 UTC (permalink / raw)
To: James Bottomley
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
[-- Attachment #1: Type: Text/Plain, Size: 1211 bytes --]
On Monday 27 February 2012 22:17:01 James Bottomley wrote:
> On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> > On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > > --- a/arch/parisc/Makefile
> > > +++ b/arch/parisc/Makefile
> > >
> > > -CROSS_COMPILE := hppa64-linux-gnu-
> > > +
> > > +# if no default set, try to find the corresponding 64 bit compiler
> > > +ifeq ($(CROSS_COMPILE),)
> > > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed
> > > s/hppa-\\\(.*\\\)/hppa64-\\1-/) +endif
> >
> > fails when using "hppa2.0-xxx". perhaps:
> > CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed
> > 's/^hppa[^-]*-/hppa64-/')
> >
> > don't even need the ifeq check then
>
> How is that different from Carlos' suggestion?
sorry, but i'm not seeing any e-mails from Carlos in this thread. what is his
suggestion ?
> The reason it doesn't work is the same ... CROSS_COMPILE is defined to be
> empty.
my suggestion was purely an incremental improvement on the patch you posted.
it improves two things:
- detection when the default tuple is hppa2.0-xxx rather than hppa-xxx
- one line for set-variable-only-when-its-unset rather than three lines
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 6:06 ` Mike Frysinger
@ 2012-02-28 14:10 ` James Bottomley
2012-02-28 15:21 ` Mike Frysinger
0 siblings, 1 reply; 25+ messages in thread
From: James Bottomley @ 2012-02-28 14:10 UTC (permalink / raw)
To: Mike Frysinger
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
On Tue, 2012-02-28 at 01:06 -0500, Mike Frysinger wrote:
> On Monday 27 February 2012 22:17:01 James Bottomley wrote:
> > On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> > > On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > > > --- a/arch/parisc/Makefile
> > > > +++ b/arch/parisc/Makefile
> > > >
> > > > -CROSS_COMPILE := hppa64-linux-gnu-
> > > > +
> > > > +# if no default set, try to find the corresponding 64 bit compiler
> > > > +ifeq ($(CROSS_COMPILE),)
> > > > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed
> > > > s/hppa-\\\(.*\\\)/hppa64-\\1-/) +endif
> > >
> > > fails when using "hppa2.0-xxx". perhaps:
Is that a valid prefix? I was thinking hppa32 might be, but hppa2.0 is
supposed to be hppa-xxx with -mpa-risc-2-0.
But anyway, I think being clever and removing unused stuff is likely
orthogonal to the first patch which is just making it all work.
> > > CROSS_COMPILE ?= $(shell $(CC) -dumpmachine | sed
> > > 's/^hppa[^-]*-/hppa64-/')
> > >
> > > don't even need the ifeq check then
> >
> > How is that different from Carlos' suggestion?
>
> sorry, but i'm not seeing any e-mails from Carlos in this thread. what is his
> suggestion ?
Actually, I misspoke, it was your suggestion in the first thread.
> > The reason it doesn't work is the same ... CROSS_COMPILE is defined to be
> > empty.
>
> my suggestion was purely an incremental improvement on the patch you posted.
> it improves two things:
> - detection when the default tuple is hppa2.0-xxx rather than hppa-xxx
> - one line for set-variable-only-when-its-unset rather than three lines
> -mike
It can't be done ... defined but empty is different from not defined in
makefiles (ifdef or ?= only checks for not defined). CROSS_COMPILE gets
automatically defined by the top level Makefile ... that's why we need a
check for empty not a check for not defined.
James
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 14:10 ` James Bottomley
@ 2012-02-28 15:21 ` Mike Frysinger
2012-02-28 15:33 ` John David Anglin
0 siblings, 1 reply; 25+ messages in thread
From: Mike Frysinger @ 2012-02-28 15:21 UTC (permalink / raw)
To: James Bottomley
Cc: Paul Gortmaker, kyle, deller, dave.anglin, linux-parisc,
linux-kernel, linux-next
[-- Attachment #1: Type: Text/Plain, Size: 2230 bytes --]
On Tuesday 28 February 2012 09:10:45 James Bottomley wrote:
> On Tue, 2012-02-28 at 01:06 -0500, Mike Frysinger wrote:
> > On Monday 27 February 2012 22:17:01 James Bottomley wrote:
> > > On Mon, 2012-02-27 at 20:04 -0500, Mike Frysinger wrote:
> > > > On Monday 27 February 2012 17:03:10 James Bottomley wrote:
> > > > > --- a/arch/parisc/Makefile
> > > > > +++ b/arch/parisc/Makefile
> > > > >
> > > > > -CROSS_COMPILE := hppa64-linux-gnu-
> > > > > +
> > > > > +# if no default set, try to find the corresponding 64 bit compiler
> > > > > +ifeq ($(CROSS_COMPILE),)
> > > > > +CROSS_COMPILE := $(shell $(CC) -dumpmachine | sed
> > > > > s/hppa-\\\(.*\\\)/hppa64-\\1-/) +endif
> > > >
> > > > fails when using "hppa2.0-xxx". perhaps:
>
> Is that a valid prefix? I was thinking hppa32 might be, but hppa2.0 is
> supposed to be hppa-xxx with -mpa-risc-2-0.
we've been using hppa2.0 for years. gnuconfig certainly recognizes it:
$ grep hppa /usr/share/gnuconfig/config.sub
| h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
| hppa-* | hppa1.[01]-* | hppa2.0-* | hppa2.0[nw]-* | hppa64-* \
and i've seen diff projects key off of the hppa2.0* to enable newer features by
default.
> But anyway, I think being clever and removing unused stuff is likely
> orthogonal to the first patch which is just making it all work.
sure, but your new patch added the sed :)
> > > The reason it doesn't work is the same ... CROSS_COMPILE is defined to
> > > be empty.
> >
> > my suggestion was purely an incremental improvement on the patch you
> > posted.
> >
> > it improves two things:
> > - detection when the default tuple is hppa2.0-xxx rather than hppa-xxx
> > - one line for set-variable-only-when-its-unset rather than three lines
>
> It can't be done ... defined but empty is different from not defined in
> makefiles (ifdef or ?= only checks for not defined). CROSS_COMPILE gets
> automatically defined by the top level Makefile ... that's why we need a
> check for empty not a check for not defined.
yeah, OK ... this behavior changed from what i was remembering. ?= used to
work until the top level Makefile was improved.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 15:21 ` Mike Frysinger
@ 2012-02-28 15:33 ` John David Anglin
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
0 siblings, 1 reply; 25+ messages in thread
From: John David Anglin @ 2012-02-28 15:33 UTC (permalink / raw)
To: Mike Frysinger
Cc: James Bottomley, Paul Gortmaker, kyle, deller, linux-parisc,
linux-kernel, linux-next
On 2/28/2012 10:21 AM, Mike Frysinger wrote:
> we've been using hppa2.0 for years. gnuconfig certainly recognizes it:
> $ grep hppa /usr/share/gnuconfig/config.sub
> | h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
> | hppa-* | hppa1.[01]-* | hppa2.0-* | hppa2.0[nw]-* | hppa64-* \
>
> and i've seen diff projects key off of the hppa2.0* to enable newer features by
> default.
Some of the above are specific to HP-UX, but hppa1.1, hppa2.0, hppa and
hppa64 are
valid for Linux based on config.guess.
Dave
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
@ 2012-02-28 18:37 ` Mike Frysinger
2012-02-28 19:54 ` Sam Ravnborg
0 siblings, 1 reply; 25+ messages in thread
From: Mike Frysinger @ 2012-02-28 18:37 UTC (permalink / raw)
To: Grant Grundler
Cc: John David Anglin, James Bottomley, Paul Gortmaker, kyle, deller,
linux-parisc, linux-kernel, linux-next
[-- Attachment #1: Type: Text/Plain, Size: 1477 bytes --]
On Tuesday 28 February 2012 13:22:50 Grant Grundler wrote:
> On Tue, Feb 28, 2012 at 7:33 AM, John David Anglin wrote:
> > On 2/28/2012 10:21 AM, Mike Frysinger wrote:
> >> we've been using hppa2.0 for years. gnuconfig certainly recognizes it:
> >> $ grep hppa /usr/share/gnuconfig/config.**sub
> >>
> >> | h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] |
> >>
> >> hppa64 \
> >>
> >> | hppa-* | hppa1.[01]-* | hppa2.0-* | hppa2.0[nw]-* | hppa64-* \
> >>
> >> and i've seen diff projects key off of the hppa2.0* to enable newer
> >> features by
> >> default.
> >
> > Some of the above are specific to HP-UX, but hppa1.1, hppa2.0, hppa and
> > hppa64 are
> > valid for Linux based on config.guess.
>
> Mike, et al,
> I'd suggest NOT using hppa2.0 as a surrogate for 64-bit build. I'd prefer
> hppa64 if 64-bit is meant.
>
> hppa2.0 can also mean PA2.0 compliant binary compiled using ILP32 model.
> right?
i don't think that's what the proposed change does. James' patch runs $(CC)
to find the active tuple, then replaces the first part with "hppa64" to get a
64bit toolchain automatically. but that magic only works when the tuple is
"hppa-xxx" and so will fail when the system is using "hppa2.0-xxx".
short story: the proposed change will additionally support turning "hppa2.0-
linux-gnu" into "hppa64-linux-gnu" rather than the existing "only turns hppa-
linux-gnu" into "hppa64-linux-gnu".
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v2] parisc: dont unconditionally override CROSS_COMPILE for 64 bit.
2012-02-28 18:37 ` Mike Frysinger
@ 2012-02-28 19:54 ` Sam Ravnborg
0 siblings, 0 replies; 25+ messages in thread
From: Sam Ravnborg @ 2012-02-28 19:54 UTC (permalink / raw)
To: Mike Frysinger
Cc: Grant Grundler, John David Anglin, James Bottomley,
Paul Gortmaker, kyle, deller, linux-parisc, linux-kernel,
linux-next
On Tue, Feb 28, 2012 at 01:37:10PM -0500, Mike Frysinger wrote:
> On Tuesday 28 February 2012 13:22:50 Grant Grundler wrote:
> > On Tue, Feb 28, 2012 at 7:33 AM, John David Anglin wrote:
> > > On 2/28/2012 10:21 AM, Mike Frysinger wrote:
> > >> we've been using hppa2.0 for years. gnuconfig certainly recognizes it:
> > >> $ grep hppa /usr/share/gnuconfig/config.**sub
> > >>
> > >> | h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] |
> > >>
> > >> hppa64 \
> > >>
> > >> | hppa-* | hppa1.[01]-* | hppa2.0-* | hppa2.0[nw]-* | hppa64-* \
> > >>
> > >> and i've seen diff projects key off of the hppa2.0* to enable newer
> > >> features by
> > >> default.
> > >
> > > Some of the above are specific to HP-UX, but hppa1.1, hppa2.0, hppa and
> > > hppa64 are
> > > valid for Linux based on config.guess.
> >
> > Mike, et al,
> > I'd suggest NOT using hppa2.0 as a surrogate for 64-bit build. I'd prefer
> > hppa64 if 64-bit is meant.
> >
> > hppa2.0 can also mean PA2.0 compliant binary compiled using ILP32 model.
> > right?
>
> i don't think that's what the proposed change does. James' patch runs $(CC)
> to find the active tuple, then replaces the first part with "hppa64" to get a
> 64bit toolchain automatically. but that magic only works when the tuple is
> "hppa-xxx" and so will fail when the system is using "hppa2.0-xxx".
>
> short story: the proposed change will additionally support turning "hppa2.0-
> linux-gnu" into "hppa64-linux-gnu" rather than the existing "only turns hppa-
> linux-gnu" into "hppa64-linux-gnu".
There is a small helper:
cc-cross-prefix
Which may be used ifyou have two or mroe candidated for CROSS_COMPILE.
>From mips:
CROSS_COMPILE := $(call cc-cross-prefix, $(tool-archpref)-linux- $(tool-archpref)-linux-gnu- $(tool-archpref)-unknown-linux-gnu-)
Dunno if this would help parisc in this case..
Sam
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2012-02-28 19:54 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-26 23:26 [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit Paul Gortmaker
2012-02-27 0:23 ` Mike Frysinger
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 0:30 ` Paul Gortmaker
2012-02-27 15:14 ` John David Anglin
2012-02-27 16:28 ` Paul Gortmaker
2012-02-27 16:28 ` Paul Gortmaker
2012-02-27 16:45 ` John David Anglin
2012-02-27 20:59 ` [PATCH v2] " Paul Gortmaker
2012-02-27 21:41 ` James Bottomley
2012-02-27 21:41 ` James Bottomley
2012-02-27 21:41 ` James Bottomley
2012-02-27 22:03 ` James Bottomley
2012-02-27 22:03 ` James Bottomley
2012-02-27 22:03 ` James Bottomley
2012-02-28 1:04 ` Mike Frysinger
2012-02-28 3:17 ` James Bottomley
2012-02-28 3:17 ` James Bottomley
2012-02-28 3:17 ` James Bottomley
2012-02-28 6:06 ` Mike Frysinger
2012-02-28 14:10 ` James Bottomley
2012-02-28 15:21 ` Mike Frysinger
2012-02-28 15:33 ` John David Anglin
[not found] ` <CANEJEGv2Zgtd8TGOzSNO8opMLQT8RsGRP=m2rBPUBBOJ9f+fKQ@mail.gmail.com>
2012-02-28 18:37 ` Mike Frysinger
2012-02-28 19:54 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.