* [B.A.T.M.A.N.] [PATCH] batman-adv: fix wrong dhcp option list browsing
@ 2012-02-27 10:29 Antonio Quartulli
2012-02-28 5:46 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Quartulli @ 2012-02-27 10:29 UTC (permalink / raw)
To: b.a.t.m.a.n
In is_type_dhcprequest(), while parsing a DHCP message, if the entry we found in
the option list is neither a padding nor the dhcp-type, we have to ignore it and
jump as many bytes as its length + 1. The "+ 1" byte is given by the subtype
field itself that has to be jumped too.
Reported-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
gateway_client.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gateway_client.c b/gateway_client.c
index 65a77a1..1f7e92d 100644
--- a/gateway_client.c
+++ b/gateway_client.c
@@ -563,10 +563,10 @@ static bool is_type_dhcprequest(struct sk_buff *skb, int header_len)
p++;
/* ...and then we jump over the data */
- if (pkt_len < *p)
+ if (pkt_len < 1 + (*p))
goto out;
- pkt_len -= *p;
- p += (*p);
+ pkt_len -= 1 + (*p);
+ p += 1 + (*p);
}
}
out:
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix wrong dhcp option list browsing
2012-02-27 10:29 [B.A.T.M.A.N.] [PATCH] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
@ 2012-02-28 5:46 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2012-02-28 5:46 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Monday, February 27, 2012 18:29:53 Antonio Quartulli wrote:
> In is_type_dhcprequest(), while parsing a DHCP message, if the entry we
> found in the option list is neither a padding nor the dhcp-type, we have
> to ignore it and jump as many bytes as its length + 1. The "+ 1" byte is
> given by the subtype field itself that has to be jumped too.
Applied in revision 459c4e4.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-28 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 10:29 [B.A.T.M.A.N.] [PATCH] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
2012-02-28 5:46 ` Marek Lindner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.