All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/nv50/vm: Prevent kernel freeze
@ 2012-02-27 21:01 Emil Velikov
       [not found] ` <1330376501-15055-1-git-send-email-emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Emil Velikov @ 2012-02-27 21:01 UTC (permalink / raw)
  To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Commit 'drm/nv50-nvc0/vm: support unsnooped system memory' caused
a regression on certain nv50 IGP due to not passing the correct
target type to nv50_vm_addr()

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45746
Reported-by: Johannes Obermayr <johannesobermayr-Mmb7MZpHnFY@public.gmane.org>
Tested-by: Johannes Obermayr <johannesobermayr-Mmb7MZpHnFY@public.gmane.org>
Signed-off-by: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nv50_vm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nv50_vm.c b/drivers/gpu/drm/nouveau/nv50_vm.c
index f06f4ad..44fbac9 100644
--- a/drivers/gpu/drm/nouveau/nv50_vm.c
+++ b/drivers/gpu/drm/nouveau/nv50_vm.c
@@ -85,7 +85,7 @@ nv50_vm_map(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt,
 		target = 3;
 	}
 
-	phys  = vm_addr(vma, phys, mem->memtype, 0);
+	phys  = vm_addr(vma, phys, mem->memtype, target);
 	pte <<= 3;
 	cnt <<= 3;
 
-- 
1.7.9.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/nv50/vm: Prevent kernel freeze
       [not found] ` <1330376501-15055-1-git-send-email-emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-02-29 23:15   ` Ben Skeggs
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2012-02-29 23:15 UTC (permalink / raw)
  To: Emil Velikov; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On Mon, 2012-02-27 at 21:01 +0000, Emil Velikov wrote:
> Commit 'drm/nv50-nvc0/vm: support unsnooped system memory' caused
> a regression on certain nv50 IGP due to not passing the correct
> target type to nv50_vm_addr()
Thanks for this, I've pushed it to the nouveau tree.

Ben.

> 
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=45746
> Reported-by: Johannes Obermayr <johannesobermayr-Mmb7MZpHnFY@public.gmane.org>
> Tested-by: Johannes Obermayr <johannesobermayr-Mmb7MZpHnFY@public.gmane.org>
> Signed-off-by: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/gpu/drm/nouveau/nv50_vm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nv50_vm.c b/drivers/gpu/drm/nouveau/nv50_vm.c
> index f06f4ad..44fbac9 100644
> --- a/drivers/gpu/drm/nouveau/nv50_vm.c
> +++ b/drivers/gpu/drm/nouveau/nv50_vm.c
> @@ -85,7 +85,7 @@ nv50_vm_map(struct nouveau_vma *vma, struct nouveau_gpuobj *pgt,
>  		target = 3;
>  	}
>  
> -	phys  = vm_addr(vma, phys, mem->memtype, 0);
> +	phys  = vm_addr(vma, phys, mem->memtype, target);
>  	pte <<= 3;
>  	cnt <<= 3;
>  

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-29 23:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 21:01 [PATCH] drm/nv50/vm: Prevent kernel freeze Emil Velikov
     [not found] ` <1330376501-15055-1-git-send-email-emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-29 23:15   ` Ben Skeggs

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.