All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, xen-devel@lists.xensource.com,
	avi@redhat.com, anthony@codemonkey.ws,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH RESEND v5 1/6] cirrus_vga: do not reset videoram
Date: Tue, 28 Feb 2012 15:51:30 +0000	[thread overview]
Message-ID: <1330444295-8859-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1202281525110.23091@kaball-desktop>

There is no need to set the videoram to 0xff in cirrus_reset, because it
is the BIOS' job.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 hw/cirrus_vga.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 4edcb94..afedaa4 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2767,10 +2767,6 @@ static void cirrus_reset(void *opaque)
     }
     s->vga.cr[0x27] = s->device_id;
 
-    /* Win2K seems to assume that the pattern buffer is at 0xff
-       initially ! */
-    memset(s->vga.vram_ptr, 0xff, s->real_vram_size);
-
     s->cirrus_hidden_dac_lockindex = 5;
     s->cirrus_hidden_dac_data = 0;
 }
-- 
1.7.2.5

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: jan.kiszka@siemens.com, xen-devel@lists.xensource.com,
	avi@redhat.com, anthony@codemonkey.ws,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH RESEND v5 1/6] cirrus_vga: do not reset videoram
Date: Tue, 28 Feb 2012 15:51:30 +0000	[thread overview]
Message-ID: <1330444295-8859-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1202281525110.23091@kaball-desktop>

There is no need to set the videoram to 0xff in cirrus_reset, because it
is the BIOS' job.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 hw/cirrus_vga.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 4edcb94..afedaa4 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2767,10 +2767,6 @@ static void cirrus_reset(void *opaque)
     }
     s->vga.cr[0x27] = s->device_id;
 
-    /* Win2K seems to assume that the pattern buffer is at 0xff
-       initially ! */
-    memset(s->vga.vram_ptr, 0xff, s->real_vram_size);
-
     s->cirrus_hidden_dac_lockindex = 5;
     s->cirrus_hidden_dac_data = 0;
 }
-- 
1.7.2.5

  reply	other threads:[~2012-02-28 15:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 15:50 [Qemu-devel] [PATCH RESEND v5 0/6] save/restore on Xen Stefano Stabellini
2012-02-28 15:50 ` Stefano Stabellini
2012-02-28 15:51 ` Stefano Stabellini [this message]
2012-02-28 15:51   ` [PATCH RESEND v5 1/6] cirrus_vga: do not reset videoram Stefano Stabellini
2012-02-28 18:35   ` [Qemu-devel] " Anthony PERARD
2012-03-12 12:43   ` Avi Kivity
2012-03-12 12:43     ` Avi Kivity
2012-03-12 13:18     ` [Qemu-devel] " Stefano Stabellini
2012-03-12 13:18       ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 2/6] Introduce "save_devices" Stefano Stabellini
2012-02-28 15:51   ` Stefano Stabellini
2012-02-28 18:58   ` [Qemu-devel] " Anthony PERARD
2012-02-28 18:58     ` Anthony PERARD
2012-03-12 18:33   ` [Qemu-devel] " Anthony Liguori
2012-03-12 18:33     ` Anthony Liguori
2012-03-13 11:51     ` [Qemu-devel] " Stefano Stabellini
2012-03-13 11:51       ` Stefano Stabellini
2012-03-13 19:26       ` [Qemu-devel] " Luiz Capitulino
2012-03-13 19:26         ` Luiz Capitulino
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 3/6] Set runstate to INMIGRATE earlier Stefano Stabellini
2012-02-28 15:51   ` Stefano Stabellini
2012-02-28 19:34   ` [Qemu-devel] " Anthony PERARD
2012-02-28 19:34     ` Anthony PERARD
2012-03-07 17:41   ` [Qemu-devel] " Luiz Capitulino
2012-03-07 17:41     ` Luiz Capitulino
2012-03-12 12:17     ` [Qemu-devel] " Stefano Stabellini
2012-03-12 12:17       ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 4/6] xen: record physmap changes to xenstore Stefano Stabellini
2012-02-28 15:51   ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 5/6] xen mapcache: check if memory region has moved Stefano Stabellini
2012-02-28 15:51   ` Stefano Stabellini
2012-02-28 15:51 ` [Qemu-devel] [PATCH RESEND v5 6/6] xen: do not allocate RAM during INMIGRATE runstate Stefano Stabellini
2012-02-28 15:51   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330444295-8859-1-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.