All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix 'Flash device refused suspend due to active operation' message
@ 2012-02-15 11:48 Russell King - ARM Linux
  2012-02-29  8:52 ` Artem Bityutskiy
  0 siblings, 1 reply; 2+ messages in thread
From: Russell King - ARM Linux @ 2012-02-15 11:48 UTC (permalink / raw)
  To: David Woodhouse, Artem Bityutskiy, linux-mtd

From: Russell King <rmk+kernel@arm.linux.org.uk>

While debugging on SA11x0, the following message was observed:

"Flash device refused suspend due to active operation (state 20)"

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
I'm afraid that it's been too long since I looked at this, and I no
longer remember the details behind this to write a proper commit log,
so maybe someone who understands the code can do that.  I seem to
remember dwmw2 said the current code was in error, so here's the
patch.

 drivers/mtd/chips/cfi_cmdset_0001.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index e1e122f..709a11f 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -2483,7 +2483,7 @@ static int cfi_intelext_suspend(struct mtd_info *mtd)
 			   allowed to. Or should we return -EAGAIN, because the upper layers
 			   ought to have already shut down anything which was using the device
 			   anyway? The latter for now. */
-			printk(KERN_NOTICE "Flash device refused suspend due to active operation (state %d)\n", chip->oldstate);
+			printk(KERN_NOTICE "Flash device refused suspend due to active operation (state %d)\n", chip->state);
 			ret = -EAGAIN;
 		case FL_PM_SUSPENDED:
 			break;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix 'Flash device refused suspend due to active operation' message
  2012-02-15 11:48 [PATCH] Fix 'Flash device refused suspend due to active operation' message Russell King - ARM Linux
@ 2012-02-29  8:52 ` Artem Bityutskiy
  0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2012-02-29  8:52 UTC (permalink / raw)
  To: Russell King - ARM Linux; +Cc: linux-mtd, David Woodhouse

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

On Wed, 2012-02-15 at 11:48 +0000, Russell King - ARM Linux wrote:
> From: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> While debugging on SA11x0, the following message was observed:
> 
> "Flash device refused suspend due to active operation (state 20)"
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Pushed to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-29  8:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-15 11:48 [PATCH] Fix 'Flash device refused suspend due to active operation' message Russell King - ARM Linux
2012-02-29  8:52 ` Artem Bityutskiy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.