Re: [PATCH] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2012-03-23 at 13:30 +0100, Martin Jansa wrote:
> On Fri, Mar 23, 2012 at 12:22:03PM +0000, Richard Purdie wrote:
> > On Fri, 2012-03-23 at 12:49 +0100, Martin Jansa wrote:
> > > On Fri, Mar 23, 2012 at 11:39:53AM +0000, Richard Purdie wrote:
> > > > On Fri, 2012-03-23 at 10:36 +0100, Martin Jansa wrote:
> > > > > On Fri, Mar 23, 2012 at 09:16:33AM +0000, Richard Purdie wrote:
> > > > > > On Fri, 2012-03-23 at 07:43 +0100, Martin Jansa wrote:
> > > > > > > * /etc/modules-load.d/foo.conf is used by systemd like /etc/modutils/foo was with sysvinit
> > > > > > > 
> > > > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > > > > ---
> > > > > > >  meta/classes/kernel.bbclass |   10 ++++++++--
> > > > > > >  1 files changed, 8 insertions(+), 2 deletions(-)
> > > > > > 
> > > > > > Since these look identical couldn't we symlink them? I'm not a big fan
> > > > > > of writing duplicate data to a package :/.
> > > > > 
> > > > > OK I'll change it in v2
> > > > 
> > > > Note that I'm wondering if we can just symlink the directory entirely
> > > > rather than the files themselves. There may be a reason that is a bad
> > > > idea but I don't know...
> > > 
> > > There are different filenames (notice .conf in the end) so I have patch
> > > doing symlinks for files not directories.
> > 
> > I'd seen the modprobe.d conf files and thought here was some similarity.
> 
> but that's for module options e.g.
> 
> SHR root@gjama ~ $ cat /etc/modprobe.d/g_ether.conf
> options g_ether dev_addr=00:1F:11:01:2C:9F host_addr=00:1F:11:01:2C:A0
> 
> not for module_autoload

Right, I understood that when I looked at the code in detail.

> > I have to admit I think systemd is nuts for requiring a copy of these
> > files when it could have used the existing layout. It looks like change
> > for the sake of change :(.
> 
> then why not patch 
> /usr/sbin/update-modules
> to read /etc/modules-load.d/*.conf instead of /etc/modutils/* as this is
> just simple script imported from debian to produce /etc/modules file
> which is IMHO all what we need for old init script
> (modutils-initscripts) to read.

I'd be open to that assuming we can have some kind of reasonable story
on compatibility.

Cheers,

Richard