Re: [PATCH] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too

[Koen Kooi <koen@dominion.thruhere.net>]

Op 23 mrt. 2012, om 13:22 heeft Richard Purdie het volgende geschreven:

> On Fri, 2012-03-23 at 12:49 +0100, Martin Jansa wrote:
>> On Fri, Mar 23, 2012 at 11:39:53AM +0000, Richard Purdie wrote:
>>> On Fri, 2012-03-23 at 10:36 +0100, Martin Jansa wrote:
>>>> On Fri, Mar 23, 2012 at 09:16:33AM +0000, Richard Purdie wrote:
>>>>> On Fri, 2012-03-23 at 07:43 +0100, Martin Jansa wrote:
>>>>>> * /etc/modules-load.d/foo.conf is used by systemd like /etc/modutils/foo was with sysvinit
>>>>>> 
>>>>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>>>>> ---
>>>>>> meta/classes/kernel.bbclass |   10 ++++++++--
>>>>>> 1 files changed, 8 insertions(+), 2 deletions(-)
>>>>> 
>>>>> Since these look identical couldn't we symlink them? I'm not a big fan
>>>>> of writing duplicate data to a package :/.
>>>> 
>>>> OK I'll change it in v2
>>> 
>>> Note that I'm wondering if we can just symlink the directory entirely
>>> rather than the files themselves. There may be a reason that is a bad
>>> idea but I don't know...
>> 
>> There are different filenames (notice .conf in the end) so I have patch
>> doing symlinks for files not directories.
> 
> I'd seen the modprobe.d conf files and thought here was some similarity.
> I have to admit I think systemd is nuts for requiring a copy of these
> files when it could have used the existing layout. It looks like change
> for the sake of change :(.
> 
> I'm nearly tempted to suggest we should just patch systemd to use the
> other filenames...

The point the systemd developers want to make is to use the same path across all distros out there. Patching it would defeat the purpose. Unless we want to fork and maintain our own init system and scripts, like we do with sysvinit currently.

regards,

Koen