All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its"
@ 2012-03-23 13:13 David Waitzman
  2012-03-23 13:27 ` Ben Walton
  0 siblings, 1 reply; 7+ messages in thread
From: David Waitzman @ 2012-03-23 13:13 UTC (permalink / raw)
  To: git, Jakub Narebski

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

This is a trivial patch to correct the english in the man page.

Signed-off-by: David Waitzman <djw@bbn.com>

---
 Documentation/gitweb.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
index 605a085..065c54e 100644
--- a/Documentation/gitweb.txt
+++ b/Documentation/gitweb.txt
@@ -14,7 +14,7 @@ gitweb.
 
 DESCRIPTION
 -----------
-Gitweb provides a web interface to git repositories.  It's features include:
+Gitweb provides a web interface to git repositories.  Its features include:
 
 * Viewing multiple Git repositories with common root.
 * Browsing every revision of the repository.
@@ -60,7 +60,7 @@ to gitweb.  The list of projects is generated by default by scanning the
 more exact; gitweb is not interested in a working area, and is best suited
 to showing "bare" repositories).
 
-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object
+The name of repository in gitweb is path to its `$GIT_DIR` (its object
 database) relative to `$projectroot`.  Therefore the repository $repo can be
 found at "$projectroot/$repo".
 
-- 
1.7.9.GIT


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 1192 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its"
  2012-03-23 13:13 [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its" David Waitzman
@ 2012-03-23 13:27 ` Ben Walton
  2012-03-23 14:49   ` [PATCH] gitweb(1) Fixed English issues David Waitzman
  0 siblings, 1 reply; 7+ messages in thread
From: Ben Walton @ 2012-03-23 13:27 UTC (permalink / raw)
  To: David Waitzman; +Cc: git, Jakub Narebski

Excerpts from David Waitzman's message of Fri Mar 23 09:13:44 -0400 2012:

Hi David,

> This is a trivial patch to correct the english in the man page.

Good catch!

> -The name of repository in gitweb is path to it's `$GIT_DIR` (it's object
> +The name of repository in gitweb is path to its `$GIT_DIR` (its object


Might I suggest that this be:

+The name of the repository in gitweb is the path to its `$GIT_DIR` (its object

Note the inserted _the_'s.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] gitweb(1) Fixed English issues
  2012-03-23 13:27 ` Ben Walton
@ 2012-03-23 14:49   ` David Waitzman
  2012-03-23 14:52     ` Ben Walton
  2012-03-23 15:02     ` D Waitzman
  0 siblings, 2 replies; 7+ messages in thread
From: David Waitzman @ 2012-03-23 14:49 UTC (permalink / raw)
  To: git, Ben Walton; +Cc: Jakub Narebski

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

This is a trivial patch to correct the english in the man page.  Ben Walton suggested an additional english fix which I have added and squashed with my change.

-----
Fixed improper use of "it's" when it should be "its".
Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca

    Signed-off-by: David Waitzman <djw@bbn.com>
---
 Documentation/gitweb.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
index 605a085..59bdc3e 100644
--- a/Documentation/gitweb.txt
+++ b/Documentation/gitweb.txt
@@ -14,7 +14,7 @@ gitweb.
 
 DESCRIPTION
 -----------
-Gitweb provides a web interface to git repositories.  It's features include:
+Gitweb provides a web interface to git repositories.  Its features include:
 
 * Viewing multiple Git repositories with common root.
 * Browsing every revision of the repository.
@@ -60,7 +60,7 @@ to gitweb.  The list of projects is generated by default by scanning the
 more exact; gitweb is not interested in a working area, and is best suited
 to showing "bare" repositories).
 
-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object
+The name of repository in gitweb is the path to its `$GIT_DIR` (its object
 database) relative to `$projectroot`.  Therefore the repository $repo can be
 found at "$projectroot/$repo".
 
-- 
1.7.9.GIT


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 1192 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gitweb(1) Fixed English issues
  2012-03-23 14:49   ` [PATCH] gitweb(1) Fixed English issues David Waitzman
@ 2012-03-23 14:52     ` Ben Walton
  2012-03-23 15:02     ` D Waitzman
  1 sibling, 0 replies; 7+ messages in thread
From: Ben Walton @ 2012-03-23 14:52 UTC (permalink / raw)
  To: David Waitzman; +Cc: git, Jakub Narebski

Excerpts from David Waitzman's message of Fri Mar 23 10:49:55 -0400 2012:

Hi David,

> +The name of repository in gitweb is the path to its `$GIT_DIR` (its object
>  database) relative to `$projectroot`.  Therefore the repository $repo can be
>  found at "$projectroot/$repo".

Two _the_'s were missing in the original.  This should read:

The name of _the_ repository in gitweb is _the_ path to its...

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] gitweb(1) Fixed English issues
  2012-03-23 14:49   ` [PATCH] gitweb(1) Fixed English issues David Waitzman
  2012-03-23 14:52     ` Ben Walton
@ 2012-03-23 15:02     ` D Waitzman
  2012-03-23 15:46       ` Thomas Rast
  1 sibling, 1 reply; 7+ messages in thread
From: D Waitzman @ 2012-03-23 15:02 UTC (permalink / raw)
  To: git; +Cc: Jakub Narebski, Ben Walton

This is a trivial patch to correct the english in the man page.  Ben Walton suggested an additional english fix which I have added and squashed with my change.  And then I added it again when he pointed out I missed something in his original email.

--

Fixed improper use of "it's" when it should be "its".
Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca

    Signed-off-by: David Waitzman <djw@bbn.com>
---
 Documentation/gitweb.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
index 605a085..168e8bf 100644
--- a/Documentation/gitweb.txt
+++ b/Documentation/gitweb.txt
@@ -14,7 +14,7 @@ gitweb.
 
 DESCRIPTION
 -----------
-Gitweb provides a web interface to git repositories.  It's features include:
+Gitweb provides a web interface to git repositories.  Its features include:
 
 * Viewing multiple Git repositories with common root.
 * Browsing every revision of the repository.
@@ -60,7 +60,7 @@ to gitweb.  The list of projects is generated by default by scanning the
 more exact; gitweb is not interested in a working area, and is best suited
 to showing "bare" repositories).
 
-The name of repository in gitweb is path to it's `$GIT_DIR` (it's object
+The name of the repository in gitweb is the path to its `$GIT_DIR` (its object
 database) relative to `$projectroot`.  Therefore the repository $repo can be
 found at "$projectroot/$repo".
 
-- 
1.7.9.GIT

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gitweb(1) Fixed English issues
  2012-03-23 15:02     ` D Waitzman
@ 2012-03-23 15:46       ` Thomas Rast
  2012-03-23 18:19         ` Junio C Hamano
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Rast @ 2012-03-23 15:46 UTC (permalink / raw)
  To: D Waitzman; +Cc: git, Jakub Narebski, Ben Walton

D Waitzman <djw@spamcop.net> writes:

> This is a trivial patch to correct the english in the man page.  Ben Walton suggested an additional english fix which I have added and squashed with my change.  And then I added it again when he pointed out I missed something in his original email.
>
> --
>
> Fixed improper use of "it's" when it should be "its".
> Added missing "the"; noted by Ben Walton bwalton@artsci.utoronto.ca
>
>     Signed-off-by: David Waitzman <djw@bbn.com>
> ---
>  Documentation/gitweb.txt |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
> index 605a085..168e8bf 100644
[snip patch]

Note that the correct way to put commentary in the patch mail that does
not go into the commit message is putting it after the --- marker.
Also, we write commit messages in the imperative.  The above should
probably look roughly like

  Subject: Documentation/gitweb: trivial English fixes

  Change "it's" to "its" where a possessive is intended.

  Also add two missing "the" that were noticed by Ben Walton
  <bwalton@artsci.utoronto.ca>.

  Signed-off-by: David Waitzman <djw@bbn.com>
  ---
  This is a trivial patch to correct the english in the man page.  Ben
  Walton suggested an additional english fix which I have added and
  squashed with my change.  And then I added it again when he pointed
  out I missed something in his original email.

   Documentation/gitweb.txt |    4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)

  diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
  index 605a085..168e8bf 100644

Note that I added "Subject:" here to make it an inline patch (though you
obviously need to remove my extra formatting indent).  If there's no
Subject pseudoheader, the patch gets the subject of your email, and
similarly for From and author.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gitweb(1) Fixed English issues
  2012-03-23 15:46       ` Thomas Rast
@ 2012-03-23 18:19         ` Junio C Hamano
  0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2012-03-23 18:19 UTC (permalink / raw)
  To: Thomas Rast; +Cc: D Waitzman, git, Jakub Narebski, Ben Walton

Thomas Rast <trast@student.ethz.ch> writes:

> Note that the correct way to put commentary in the patch mail that does
> not go into the commit message is putting it after the --- marker.
> Also, we write commit messages in the imperative.  The above should
> probably look roughly like
>
>   Subject: Documentation/gitweb: trivial English fixes
>
>   Change "it's" to "its" where a possessive is intended.
>
>   Also add two missing "the" that were noticed by Ben Walton
>   <bwalton@artsci.utoronto.ca>.
>
>   Signed-off-by: David Waitzman <djw@bbn.com>
>   ---
>   This is a trivial patch to correct the english in the man page.  Ben
>   Walton suggested an additional english fix which I have added and
>   squashed with my change.  And then I added it again when he pointed
>   out I missed something in his original email.
>
>    Documentation/gitweb.txt |    4 ++--
>    1 file changed, 2 insertions(+), 2 deletions(-)
>
>   diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
>   index 605a085..168e8bf 100644
>
> Note that I added "Subject:" here to make it an inline patch (though you
> obviously need to remove my extra formatting indent).  If there's no
> Subject pseudoheader, the patch gets the subject of your email, and
> similarly for From and author.

Thanks.  I'll use this with the patch text you are responding to.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-03-23 18:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-23 13:13 [PATCH] gitweb(1): Fixed improper use of "it's" when it should be "its" David Waitzman
2012-03-23 13:27 ` Ben Walton
2012-03-23 14:49   ` [PATCH] gitweb(1) Fixed English issues David Waitzman
2012-03-23 14:52     ` Ben Walton
2012-03-23 15:02     ` D Waitzman
2012-03-23 15:46       ` Thomas Rast
2012-03-23 18:19         ` Junio C Hamano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.