[PATCH] ia32-base.inc: Use '=' for IMAGE_FSTYPES

[PATCH] ia32-base.inc: Use '=' for IMAGE_FSTYPES

[Tom Rini]

As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019772.html
a machine conf file should use '=' to set IMAGE_FSTYPES.

Cc: Kishore Bodke <kishore.k.bodke@intel.com>
Cc: Tom Zanussi <tom.zanussi@intel.com>
Cc: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 conf/machine/include/ia32-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/machine/include/ia32-base.inc b/conf/machine/include/ia32-base.inc
index 9b2ef5a..74ab5a5 100644
--- a/conf/machine/include/ia32-base.inc
+++ b/conf/machine/include/ia32-base.inc
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
 MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
 
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES = "ext3 cpio.gz live"
 
 KERNEL_IMAGETYPE ?= "bzImage"
 
-- 
1.7.0.4

[meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Tom Rini]

As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020053.html
a machine conf file should use '=+' to set IMAGE_FSTYPES.

Cc: Kishore Bodke <kishore.k.bodke@intel.com>
Cc: Tom Zanussi <tom.zanussi@intel.com>
Cc: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 conf/machine/include/ia32-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/machine/include/ia32-base.inc b/conf/machine/include/ia32-base.inc
index 9b2ef5a..817ee2d 100644
--- a/conf/machine/include/ia32-base.inc
+++ b/conf/machine/include/ia32-base.inc
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
 MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
 
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"
 
 KERNEL_IMAGETYPE ?= "bzImage"
 
-- 
1.7.0.4

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Khem Raj]

On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
>
> -IMAGE_FSTYPES += "ext3 cpio.gz live"
> +IMAGE_FSTYPES =+ "ext3 cpio.gz live"

whats the difference ?

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Tom Rini]

On Wed, Mar 28, 2012 at 02:42:36PM -0700, Khem Raj wrote:
> On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
> >
> > -IMAGE_FSTYPES += "ext3 cpio.gz live"
> > +IMAGE_FSTYPES =+ "ext3 cpio.gz live"
> 
> whats the difference ?

Consistency.  Or blame Richard for saying "no, wait, =+" :)

-- 
Tom

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Darren Hart]

On 03/28/2012 03:06 PM, Tom Rini wrote:
> On Wed, Mar 28, 2012 at 02:42:36PM -0700, Khem Raj wrote:
>> On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
>>>
>>> -IMAGE_FSTYPES += "ext3 cpio.gz live"
>>> +IMAGE_FSTYPES =+ "ext3 cpio.gz live"
>>
>> whats the difference ?
> 
> Consistency.  Or blame Richard for saying "no, wait, =+" :)
> 

+= append
=+ prepend

Doesn't seem to me that it would impact the final output at all.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Khem Raj]

On Wed, Mar 28, 2012 at 4:53 PM, Darren Hart <dvhart@linux.intel.com> wrote:

> Doesn't seem to me that it would impact the final output at all.

exactly that was my point.

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

[Denys Dmytriyenko]

On Wed, Mar 28, 2012 at 05:50:30PM -0700, Khem Raj wrote:
> On Wed, Mar 28, 2012 at 4:53 PM, Darren Hart <dvhart@linux.intel.com> wrote:
> 
> > Doesn't seem to me that it would impact the final output at all.
> 
> exactly that was my point.

FYI,
http://thread.gmane.org/gmane.comp.handhelds.openembedded.core/17731/focus=18041

-- 
Denys