[PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

[PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

[Kenth Eriksson]

Commit b26e478f undid bug fix in commit c3e072f8, with the result that non TBI (e.g. MDIO) PHYs cannot be accessed.

Signed-off-by: Kenth Eriksson <kenth.eriksson@transmode.com>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 9eb8159..f7f0bf5 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -356,13 +356,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
 
 		if (prop)
 			tbiaddr = *prop;
-	}
 
-	if (tbiaddr == -1) {
-		err = -EBUSY;
-		goto err_free_irqs;
-	} else {
-		out_be32(tbipa, tbiaddr);
+		if (tbiaddr == -1) {
+			err = -EBUSY;
+			goto err_free_irqs;
+		} else {
+			out_be32(tbipa, tbiaddr);
+		}
 	}
 
 	err = of_mdiobus_register(new_bus, np);
-- 
1.7.3.4

Re: [PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

[David Miller]

From: Kenth Eriksson <kenth.eriksson@transmode.com>
Date: Wed, 28 Mar 2012 10:05:54 +0200

> Commit b26e478f undid bug fix in commit c3e072f8, with the result
> that non TBI (e.g. MDIO) PHYs cannot be accessed.
> 
> Signed-off-by: Kenth Eriksson <kenth.eriksson@transmode.com>

Applied and queued up for -stable.