* [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
@ 2012-03-28 10:17 Inderpal Singh
2012-05-14 8:15 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Inderpal Singh @ 2012-03-28 10:17 UTC (permalink / raw)
To: samsung, linux-samsung-soc; +Cc: patches, kgene.kim, Inderpal Singh
Upon wake-up, clear the sleep mode set in INFORM1 register.
Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
arch/arm/mach-exynos/pm.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
index f0bb467..16cba3f 100644
--- a/arch/arm/mach-exynos/pm.c
+++ b/arch/arm/mach-exynos/pm.c
@@ -381,6 +381,10 @@ static void exynos4_pm_resume(void)
#endif
early_wakeup:
+
+ /* Clear SLEEP mode set in INFORM1 */
+ __raw_writel(0x0, S5P_INFORM1);
+
return;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
2012-03-28 10:17 [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume Inderpal Singh
@ 2012-05-14 8:15 ` Kukjin Kim
2012-05-14 8:42 ` Inderpal Singh
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2012-05-14 8:15 UTC (permalink / raw)
To: 'Inderpal Singh', samsung, linux-samsung-soc; +Cc: patches
Inderpal Singh wrote:
>
> Upon wake-up, clear the sleep mode set in INFORM1 register.
>
Is this for wake-up or _really_ software reset? And is this available on all
of EXYNOS4 SoCs?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
> arch/arm/mach-exynos/pm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
> index f0bb467..16cba3f 100644
> --- a/arch/arm/mach-exynos/pm.c
> +++ b/arch/arm/mach-exynos/pm.c
> @@ -381,6 +381,10 @@ static void exynos4_pm_resume(void)
> #endif
>
> early_wakeup:
> +
> + /* Clear SLEEP mode set in INFORM1 */
> + __raw_writel(0x0, S5P_INFORM1);
> +
> return;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
2012-05-14 8:15 ` Kukjin Kim
@ 2012-05-14 8:42 ` Inderpal Singh
2012-05-14 13:43 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Inderpal Singh @ 2012-05-14 8:42 UTC (permalink / raw)
To: Kukjin Kim; +Cc: samsung, linux-samsung-soc, patches
Hi Kukjin,
On 14 May 2012 13:45, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Inderpal Singh wrote:
>>
>> Upon wake-up, clear the sleep mode set in INFORM1 register.
>>
> Is this for wake-up or _really_ software reset? And is this available on all
> of EXYNOS4 SoCs?
This is for soft reboot hang after one cycle of suspend/resume is complete.
And yes this is applicable for all exynos SOCs.
With Regards,
Inder
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
>> ---
>> arch/arm/mach-exynos/pm.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
>> index f0bb467..16cba3f 100644
>> --- a/arch/arm/mach-exynos/pm.c
>> +++ b/arch/arm/mach-exynos/pm.c
>> @@ -381,6 +381,10 @@ static void exynos4_pm_resume(void)
>> #endif
>>
>> early_wakeup:
>> +
>> + /* Clear SLEEP mode set in INFORM1 */
>> + __raw_writel(0x0, S5P_INFORM1);
>> +
>> return;
>> }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
2012-05-14 8:42 ` Inderpal Singh
@ 2012-05-14 13:43 ` Kukjin Kim
2012-05-15 4:31 ` Inderpal Singh
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2012-05-14 13:43 UTC (permalink / raw)
To: Inderpal Singh; +Cc: Kukjin Kim, samsung, linux-samsung-soc, patches
On 05/14/12 17:42, Inderpal Singh wrote:
> Hi Kukjin,
>
> On 14 May 2012 13:45, Kukjin Kim<kgene.kim@samsung.com> wrote:
>> Inderpal Singh wrote:
>>>
>>> Upon wake-up, clear the sleep mode set in INFORM1 register.
>>>
>> Is this for wake-up or _really_ software reset? And is this available on all
>> of EXYNOS4 SoCs?
>
> This is for soft reboot hang after one cycle of suspend/resume is complete.
> And yes this is applicable for all exynos SOCs.
>
Hi,
As I know, we don't need it for all of EXYNOS SoCs but let me check
about the situation you said with hardware engineer tomorrow. If any
updates, let you know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
2012-05-14 13:43 ` Kukjin Kim
@ 2012-05-15 4:31 ` Inderpal Singh
2012-09-14 5:14 ` Inderpal Singh
0 siblings, 1 reply; 6+ messages in thread
From: Inderpal Singh @ 2012-05-15 4:31 UTC (permalink / raw)
To: Kukjin Kim; +Cc: samsung, linux-samsung-soc, patches
Hi Kukjin,
On 14 May 2012 19:13, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 05/14/12 17:42, Inderpal Singh wrote:
>>
>> Hi Kukjin,
>>
>> On 14 May 2012 13:45, Kukjin Kim<kgene.kim@samsung.com> wrote:
>>>
>>> Inderpal Singh wrote:
>>>>
>>>>
>>>> Upon wake-up, clear the sleep mode set in INFORM1 register.
>>>>
>>> Is this for wake-up or _really_ software reset? And is this available on
>>> all
>>> of EXYNOS4 SoCs?
>>
>>
>> This is for soft reboot hang after one cycle of suspend/resume is
>> complete.
>> And yes this is applicable for all exynos SOCs.
>>
> Hi,
>
> As I know, we don't need it for all of EXYNOS SoCs but let me check about
> the situation you said with hardware engineer tomorrow. If any updates, let
> you know.
>
The issue happens because u-boot checks INFROM1 register to know if
its wake-up from sleep. Hence if INFORM1 is not cleared, the soft
reboot after one suspend/resume cycle will be understood by u-boot as
wake-up from sleep, so it will try to resume and will hang up.
I have faced this issue on Origen, Pegasus SMDK and 5250 SMDK.
Thanks,
Inder
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume
2012-05-15 4:31 ` Inderpal Singh
@ 2012-09-14 5:14 ` Inderpal Singh
0 siblings, 0 replies; 6+ messages in thread
From: Inderpal Singh @ 2012-09-14 5:14 UTC (permalink / raw)
To: Kukjin Kim; +Cc: samsung, linux-samsung-soc, patches
Hi Kukjin,
On 15 May 2012 10:01, Inderpal Singh <inderpal.singh@linaro.org> wrote:
> Hi Kukjin,
>
> On 14 May 2012 19:13, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> On 05/14/12 17:42, Inderpal Singh wrote:
>>>
>>> Hi Kukjin,
>>>
>>> On 14 May 2012 13:45, Kukjin Kim<kgene.kim@samsung.com> wrote:
>>>>
>>>> Inderpal Singh wrote:
>>>>>
>>>>>
>>>>> Upon wake-up, clear the sleep mode set in INFORM1 register.
>>>>>
>>>> Is this for wake-up or _really_ software reset? And is this available on
>>>> all
>>>> of EXYNOS4 SoCs?
>>>
>>>
>>> This is for soft reboot hang after one cycle of suspend/resume is
>>> complete.
>>> And yes this is applicable for all exynos SOCs.
>>>
>> Hi,
>>
>> As I know, we don't need it for all of EXYNOS SoCs but let me check about
>> the situation you said with hardware engineer tomorrow. If any updates, let
>> you know.
>>
>
Any updates on this ?
As i mentioned below, Its applicable for Origen, Pegasus and 5250 as well.
> The issue happens because u-boot checks INFROM1 register to know if
> its wake-up from sleep. Hence if INFORM1 is not cleared, the soft
> reboot after one suspend/resume cycle will be understood by u-boot as
> wake-up from sleep, so it will try to resume and will hang up.
>
> I have faced this issue on Origen, Pegasus SMDK and 5250 SMDK.
>
> Thanks,
> Inder
>
>>
>> Thanks.
>>
>> Best regards,
>> Kgene.
>> --
>> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
>> SW Solution Development Team, Samsung Electronics Co., Ltd.
With Regards,
Inder
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-14 5:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-28 10:17 [PATCH] ARM: EXYNOS4: Fix soft reboot hang after suspend/resume Inderpal Singh
2012-05-14 8:15 ` Kukjin Kim
2012-05-14 8:42 ` Inderpal Singh
2012-05-14 13:43 ` Kukjin Kim
2012-05-15 4:31 ` Inderpal Singh
2012-09-14 5:14 ` Inderpal Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.