* [PATCH] acpi_power_meter: fix lockdep spew due to non-static lock class
@ 2012-03-28 19:11 ` Kyle McMartin
0 siblings, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2012-03-28 19:11 UTC (permalink / raw)
To: linux-kernel; +Cc: khali, guenter.roeck, lm-sensors, djwong
Similar to a30dcb4f which fixed asus_atk0110.ko, I recently received a
bug report from someone hitting the same issue in acpi_power_meter.
[ 13.963168] power_meter ACPI000D:00: Found ACPI power meter.
[ 13.963900] BUG: key ffff8802161f3920 not in .data!
[ 13.963904] ------------[ cut here ]------------
[ 13.963915] WARNING: at kernel/lockdep.c:2986
lockdep_init_map+0x52f/0x560()
So let's fix that up for them by statically declaring the
lockdep_class_key.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -632,6 +632,7 @@ static int register_ro_attrs(struct acpi_power_meter_resource *resource,
sensors->dev_attr.show = ro->show;
sensors->index = ro->index;
+ sysfs_attr_init(&sensors->dev_attr.attr);
res = device_create_file(dev, &sensors->dev_attr);
if (res) {
sensors->dev_attr.attr.name = NULL;
@@ -661,6 +662,7 @@ static int register_rw_attrs(struct acpi_power_meter_resource *resource,
sensors->dev_attr.store = rw->set;
sensors->index = rw->index;
+ sysfs_attr_init(&sensors->dev_attr.attr);
res = device_create_file(dev, &sensors->dev_attr);
if (res) {
sensors->dev_attr.attr.name = NULL;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [lm-sensors] [PATCH] acpi_power_meter: fix lockdep spew due to non-static lock class
@ 2012-03-28 19:11 ` Kyle McMartin
0 siblings, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2012-03-28 19:11 UTC (permalink / raw)
To: linux-kernel; +Cc: khali, guenter.roeck, lm-sensors, djwong
Similar to a30dcb4f which fixed asus_atk0110.ko, I recently received a
bug report from someone hitting the same issue in acpi_power_meter.
[ 13.963168] power_meter ACPI000D:00: Found ACPI power meter.
[ 13.963900] BUG: key ffff8802161f3920 not in .data!
[ 13.963904] ------------[ cut here ]------------
[ 13.963915] WARNING: at kernel/lockdep.c:2986
lockdep_init_map+0x52f/0x560()
So let's fix that up for them by statically declaring the
lockdep_class_key.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/drivers/hwmon/acpi_power_meter.c
+++ b/drivers/hwmon/acpi_power_meter.c
@@ -632,6 +632,7 @@ static int register_ro_attrs(struct acpi_power_meter_resource *resource,
sensors->dev_attr.show = ro->show;
sensors->index = ro->index;
+ sysfs_attr_init(&sensors->dev_attr.attr);
res = device_create_file(dev, &sensors->dev_attr);
if (res) {
sensors->dev_attr.attr.name = NULL;
@@ -661,6 +662,7 @@ static int register_rw_attrs(struct acpi_power_meter_resource *resource,
sensors->dev_attr.store = rw->set;
sensors->index = rw->index;
+ sysfs_attr_init(&sensors->dev_attr.attr);
res = device_create_file(dev, &sensors->dev_attr);
if (res) {
sensors->dev_attr.attr.name = NULL;
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi_power_meter: fix lockdep spew due to non-static lock class
2012-03-28 19:11 ` [lm-sensors] " Kyle McMartin
@ 2012-03-28 19:55 ` Guenter Roeck
-1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-03-28 19:55 UTC (permalink / raw)
To: Kyle McMartin; +Cc: linux-kernel, khali, lm-sensors, djwong
On Wed, 2012-03-28 at 15:11 -0400, Kyle McMartin wrote:
> Similar to a30dcb4f which fixed asus_atk0110.ko, I recently received a
> bug report from someone hitting the same issue in acpi_power_meter.
>
> [ 13.963168] power_meter ACPI000D:00: Found ACPI power meter.
> [ 13.963900] BUG: key ffff8802161f3920 not in .data!
> [ 13.963904] ------------[ cut here ]------------
> [ 13.963915] WARNING: at kernel/lockdep.c:2986
> lockdep_init_map+0x52f/0x560()
>
> So let's fix that up for them by statically declaring the
> lockdep_class_key.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] acpi_power_meter: fix lockdep spew due to non-static lock class
@ 2012-03-28 19:55 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-03-28 19:55 UTC (permalink / raw)
To: Kyle McMartin; +Cc: linux-kernel, khali, lm-sensors, djwong
On Wed, 2012-03-28 at 15:11 -0400, Kyle McMartin wrote:
> Similar to a30dcb4f which fixed asus_atk0110.ko, I recently received a
> bug report from someone hitting the same issue in acpi_power_meter.
>
> [ 13.963168] power_meter ACPI000D:00: Found ACPI power meter.
> [ 13.963900] BUG: key ffff8802161f3920 not in .data!
> [ 13.963904] ------------[ cut here ]------------
> [ 13.963915] WARNING: at kernel/lockdep.c:2986
> lockdep_init_map+0x52f/0x560()
>
> So let's fix that up for them by statically declaring the
> lockdep_class_key.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-28 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-28 19:11 [PATCH] acpi_power_meter: fix lockdep spew due to non-static lock class Kyle McMartin
2012-03-28 19:11 ` [lm-sensors] " Kyle McMartin
2012-03-28 19:55 ` Guenter Roeck
2012-03-28 19:55 ` [lm-sensors] " Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.