* [PATCH 0/2] HID: wacom: 2 trivial patches
@ 2012-03-28 21:13 Przemo Firszt
2012-03-28 21:13 ` [PATCH 1/2] HID: wacom: Fix HID_WACOM self-dependency Przemo Firszt
2012-03-28 21:13 ` [PATCH 2/2] HID: wacom: Add module description Przemo Firszt
0 siblings, 2 replies; 5+ messages in thread
From: Przemo Firszt @ 2012-03-28 21:13 UTC (permalink / raw)
To: jkosina, pinglinux; +Cc: linuxwacom-devel, linux-input, Przemo Firszt
2 trivial patches:
- module self-dependency fix,
- add module description.
Przemo Firszt (2):
HID: wacom: Fix HID_WACOM self-dependency
HID: wacom: Add module description
drivers/hid/Kconfig | 1 -
drivers/hid/hid-wacom.c | 2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
--
1.7.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] HID: wacom: Fix HID_WACOM self-dependency
2012-03-28 21:13 [PATCH 0/2] HID: wacom: 2 trivial patches Przemo Firszt
@ 2012-03-28 21:13 ` Przemo Firszt
2012-03-28 21:13 ` [PATCH 2/2] HID: wacom: Add module description Przemo Firszt
1 sibling, 0 replies; 5+ messages in thread
From: Przemo Firszt @ 2012-03-28 21:13 UTC (permalink / raw)
To: jkosina, pinglinux; +Cc: linuxwacom-devel, linux-input, Przemo Firszt
This patch fixes a silly mistake: HID_WACOM was dependent on HID_WACOM, so
the option wasn't showing up after make menuconfig
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
drivers/hid/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 77daaf21..7f1c032 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -620,7 +620,6 @@ config THRUSTMASTER_FF
config HID_WACOM
tristate "Wacom Bluetooth devices support"
depends on BT_HIDP
- depends on HID_WACOM
select POWER_SUPPLY
---help---
Support for Wacom Graphire Bluetooth and Intuos4 WL tablets.
--
1.7.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] HID: wacom: Add module description
2012-03-28 21:13 [PATCH 0/2] HID: wacom: 2 trivial patches Przemo Firszt
2012-03-28 21:13 ` [PATCH 1/2] HID: wacom: Fix HID_WACOM self-dependency Przemo Firszt
@ 2012-03-28 21:13 ` Przemo Firszt
2012-03-29 14:46 ` Jiri Kosina
1 sibling, 1 reply; 5+ messages in thread
From: Przemo Firszt @ 2012-03-28 21:13 UTC (permalink / raw)
To: jkosina, pinglinux; +Cc: linuxwacom-devel, linux-input, Przemo Firszt
Add description for hid-wacom module: "Driver for Wacom Graphire Bluetooth
and Wacom Intuos4 WL"
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
drivers/hid/hid-wacom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
index f130f40..fb0fe16 100644
--- a/drivers/hid/hid-wacom.c
+++ b/drivers/hid/hid-wacom.c
@@ -687,5 +687,5 @@ static void __exit wacom_exit(void)
module_init(wacom_init);
module_exit(wacom_exit);
+MODULE_DESCRIPTION("Driver for Wacom Graphire Bluetooth and Wacom Intuos4 WL");
MODULE_LICENSE("GPL");
-
--
1.7.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] HID: wacom: Add module description
2012-03-28 21:13 ` [PATCH 2/2] HID: wacom: Add module description Przemo Firszt
@ 2012-03-29 14:46 ` Jiri Kosina
2012-03-29 15:08 ` Przemo Firszt
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2012-03-29 14:46 UTC (permalink / raw)
To: Przemo Firszt; +Cc: pinglinux, linuxwacom-devel, linux-input
On Wed, 28 Mar 2012, Przemo Firszt wrote:
> Add description for hid-wacom module: "Driver for Wacom Graphire Bluetooth
> and Wacom Intuos4 WL"
>
> Signed-off-by: Przemo Firszt <przemo@firszt.eu>
> ---
> drivers/hid/hid-wacom.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index f130f40..fb0fe16 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -687,5 +687,5 @@ static void __exit wacom_exit(void)
>
> module_init(wacom_init);
> module_exit(wacom_exit);
> +MODULE_DESCRIPTION("Driver for Wacom Graphire Bluetooth and Wacom Intuos4 WL");
I am a little bit unsure about having the information about supported
models duplicate in Kconfig and MODULE_DESCRIPTION() ... it's just adding
more places that we will forget to update once support for a new device
line is added.
Applied, but not fully convinced.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] HID: wacom: Add module description
2012-03-29 14:46 ` Jiri Kosina
@ 2012-03-29 15:08 ` Przemo Firszt
0 siblings, 0 replies; 5+ messages in thread
From: Przemo Firszt @ 2012-03-29 15:08 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Przemo Firszt, pinglinux, linuxwacom-devel, linux-input
Dnia 29 Marca 2012, 3:46 pm, Cz, Jiri Kosina napisał(a):
> On Wed, 28 Mar 2012, Przemo Firszt wrote:
>
>> Add description for hid-wacom module: "Driver for Wacom Graphire
>> Bluetooth
>> and Wacom Intuos4 WL"
>>
>> Signed-off-by: Przemo Firszt <przemo@firszt.eu>
>> ---
>> drivers/hid/hid-wacom.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
>> index f130f40..fb0fe16 100644
>> --- a/drivers/hid/hid-wacom.c
>> +++ b/drivers/hid/hid-wacom.c
>> @@ -687,5 +687,5 @@ static void __exit wacom_exit(void)
>>
>> module_init(wacom_init);
>> module_exit(wacom_exit);
>> +MODULE_DESCRIPTION("Driver for Wacom Graphire Bluetooth and Wacom
>> Intuos4 WL");
>
> I am a little bit unsure about having the information about supported
> models duplicate in Kconfig and MODULE_DESCRIPTION() ... it's just adding
> more places that we will forget to update once support for a new device
> line is added.
>
> Applied, but not fully convinced.
>
Hi Jiri,
Thanks! I'll come back to this issue later - I have to test an idea..
--
Regards,
Przemo Firszt
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-29 15:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-28 21:13 [PATCH 0/2] HID: wacom: 2 trivial patches Przemo Firszt
2012-03-28 21:13 ` [PATCH 1/2] HID: wacom: Fix HID_WACOM self-dependency Przemo Firszt
2012-03-28 21:13 ` [PATCH 2/2] HID: wacom: Add module description Przemo Firszt
2012-03-29 14:46 ` Jiri Kosina
2012-03-29 15:08 ` Przemo Firszt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.