* [PATCH] rtl8187: Fix sparse warnings
@ 2009-11-09 22:56 Larry Finger
2009-11-09 23:55 ` Hin-Tak Leung
2009-11-10 4:17 ` Herton Ronaldo Krzesinski
0 siblings, 2 replies; 3+ messages in thread
From: Larry Finger @ 2009-11-09 22:56 UTC (permalink / raw)
To: John W Linville; +Cc: Herton Ronaldo Krzesinski, Hin-Tak Leung, linux-wireless
Due to a missing header include, sparse generates the following warnings:
CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
warning: symbol 'rtl8187_rfkill_init' was not declared. Should it be static?
warning: symbol 'rtl8187_rfkill_poll' was not declared. Should it be static?
warning: symbol 'rtl8187_rfkill_exit' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This is 2.6.33 material.
Larry
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
@@ -18,6 +18,7 @@
#include <net/mac80211.h>
#include "rtl8187.h"
+#include "rtl8187_rfkill.h"
static bool rtl8187_is_radio_enabled(struct rtl8187_priv *priv)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8187: Fix sparse warnings
2009-11-09 22:56 [PATCH] rtl8187: Fix sparse warnings Larry Finger
@ 2009-11-09 23:55 ` Hin-Tak Leung
2009-11-10 4:17 ` Herton Ronaldo Krzesinski
1 sibling, 0 replies; 3+ messages in thread
From: Hin-Tak Leung @ 2009-11-09 23:55 UTC (permalink / raw)
To: John W Linville, Larry Finger; +Cc: Herton Ronaldo Krzesinski, linux-wireless
--- On Mon, 9/11/09, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Due to a missing header include,
> sparse generates the following warnings:
>
>
> CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> warning: symbol 'rtl8187_rfkill_init' was not declared.
> Should it be static?
> warning: symbol 'rtl8187_rfkill_poll' was not declared.
> Should it be static?
> warning: symbol 'rtl8187_rfkill_exit' was not declared.
> Should it be static?
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Looks straight-forward.
> ---
>
> John,
>
> This is 2.6.33 material.
>
> Larry
> ---
>
> Index:
> wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> ===================================================================
> ---
> wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> +++
> wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> @@ -18,6 +18,7 @@
> #include <net/mac80211.h>
>
> #include "rtl8187.h"
> +#include "rtl8187_rfkill.h"
>
> static bool rtl8187_is_radio_enabled(struct rtl8187_priv
> *priv)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8187: Fix sparse warnings
2009-11-09 22:56 [PATCH] rtl8187: Fix sparse warnings Larry Finger
2009-11-09 23:55 ` Hin-Tak Leung
@ 2009-11-10 4:17 ` Herton Ronaldo Krzesinski
1 sibling, 0 replies; 3+ messages in thread
From: Herton Ronaldo Krzesinski @ 2009-11-10 4:17 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, Hin-Tak Leung, linux-wireless
Em Seg 09 Nov 2009, às 20:56:06, Larry Finger escreveu:
> Due to a missing header include, sparse generates the following warnings:
>
> CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> warning: symbol 'rtl8187_rfkill_init' was not declared. Should it be static?
> warning: symbol 'rtl8187_rfkill_poll' was not declared. Should it be static?
> warning: symbol 'rtl8187_rfkill_exit' was not declared. Should it be static?
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
> ---
>
> John,
>
> This is 2.6.33 material.
>
> Larry
> ---
>
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> @@ -18,6 +18,7 @@
> #include <net/mac80211.h>
>
> #include "rtl8187.h"
> +#include "rtl8187_rfkill.h"
>
> static bool rtl8187_is_radio_enabled(struct rtl8187_priv *priv)
> {
>
--
[]'s
Herton
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-10 4:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-09 22:56 [PATCH] rtl8187: Fix sparse warnings Larry Finger
2009-11-09 23:55 ` Hin-Tak Leung
2009-11-10 4:17 ` Herton Ronaldo Krzesinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.