* [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9
@ 2012-04-08 4:18 Ben Hutchings
2012-04-11 1:29 ` Jason Cooper
2012-04-20 0:57 ` Ben Hutchings
0 siblings, 2 replies; 4+ messages in thread
From: Ben Hutchings @ 2012-04-08 4:18 UTC (permalink / raw)
To: linux-arm-kernel
Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
mpp code to use common orion platform mpp.') seems to have accidentally
inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
which uses MPP9 as a GPIO LED device, this results in the error:
[ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
Reported-by: Henry von Tresckow <hvontres@gmail.com>
References: http://bugs.debian.org/667446
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable at vger.kernel.org [v3.0+]
---
v2: Add subject of the earlier commit
Ben.
arch/arm/mach-orion5x/mpp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
index eac6897..db70e79 100644
--- a/arch/arm/mach-orion5x/mpp.h
+++ b/arch/arm/mach-orion5x/mpp.h
@@ -65,8 +65,8 @@
#define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)
#define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
-#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
-#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
+#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
+#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)
#define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
#define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9
2012-04-08 4:18 [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9 Ben Hutchings
@ 2012-04-11 1:29 ` Jason Cooper
2012-04-20 0:57 ` Ben Hutchings
1 sibling, 0 replies; 4+ messages in thread
From: Jason Cooper @ 2012-04-11 1:29 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Apr 08, 2012 at 05:18:53AM +0100, Ben Hutchings wrote:
> Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> mpp code to use common orion platform mpp.') seems to have accidentally
> inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
> which uses MPP9 as a GPIO LED device, this results in the error:
>
> [ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
>
> Reported-by: Henry von Tresckow <hvontres@gmail.com>
> References: http://bugs.debian.org/667446
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: stable at vger.kernel.org [v3.0+]
> ---
> v2: Add subject of the earlier commit
oops, replied to the earlier one before seeing this one. Playing
catchup after the holidays.
Please see my earlier post regarding possible breakage on other boards.
thx,
Jason.
> arch/arm/mach-orion5x/mpp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> index eac6897..db70e79 100644
> --- a/arch/arm/mach-orion5x/mpp.h
> +++ b/arch/arm/mach-orion5x/mpp.h
> @@ -65,8 +65,8 @@
> #define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
> +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
> +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
> #define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
> --
> 1.7.9.5
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9
2012-04-08 4:18 [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9 Ben Hutchings
2012-04-11 1:29 ` Jason Cooper
@ 2012-04-20 0:57 ` Ben Hutchings
2012-05-08 18:26 ` Jason Cooper
1 sibling, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2012-04-20 0:57 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 2012-04-08 at 05:18 +0100, Ben Hutchings wrote:
> Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> mpp code to use common orion platform mpp.') seems to have accidentally
> inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
> which uses MPP9 as a GPIO LED device, this results in the error:
>
> [ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
>
> Reported-by: Henry von Tresckow <hvontres@gmail.com>
Tested-by: Hans Henry von Tresckow <hvontres@gmail.com>
(on the mv2120, and applied to Debian's 3.2 tree)
> References: http://bugs.debian.org/667446
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: stable at vger.kernel.org [v3.0+]
> ---
> v2: Add subject of the earlier commit
>
> Ben.
>
> arch/arm/mach-orion5x/mpp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> index eac6897..db70e79 100644
> --- a/arch/arm/mach-orion5x/mpp.h
> +++ b/arch/arm/mach-orion5x/mpp.h
> @@ -65,8 +65,8 @@
> #define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
> -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
> +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
> +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)
>
> #define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
> #define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120420/945f26f1/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9
2012-04-20 0:57 ` Ben Hutchings
@ 2012-05-08 18:26 ` Jason Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Jason Cooper @ 2012-05-08 18:26 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 20, 2012 at 01:57:00AM +0100, Ben Hutchings wrote:
> On Sun, 2012-04-08 at 05:18 +0100, Ben Hutchings wrote:
> > Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor
> > mpp code to use common orion platform mpp.') seems to have accidentally
> > inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform
> > which uses MPP9 as a GPIO LED device, this results in the error:
> >
> > [ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
> >
> > Reported-by: Henry von Tresckow <hvontres@gmail.com>
>
> Tested-by: Hans Henry von Tresckow <hvontres@gmail.com>
I'm putting this towards fixes for v3.4, adding the above Tested-by:
thx,
Jason.
>
> (on the mv2120, and applied to Debian's 3.2 tree)
>
> > References: http://bugs.debian.org/667446
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: stable at vger.kernel.org [v3.0+]
> > ---
> > v2: Add subject of the earlier commit
> >
> > Ben.
> >
> > arch/arm/mach-orion5x/mpp.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-orion5x/mpp.h b/arch/arm/mach-orion5x/mpp.h
> > index eac6897..db70e79 100644
> > --- a/arch/arm/mach-orion5x/mpp.h
> > +++ b/arch/arm/mach-orion5x/mpp.h
> > @@ -65,8 +65,8 @@
> > #define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)
> >
> > #define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1)
> > -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1)
> > -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1)
> > +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1)
> > +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)
> >
> > #define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)
> > #define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
>
> --
> Ben Hutchings
> This sentence contradicts itself - no actually it doesn't.
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-08 18:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-08 4:18 [PATCHv2] ARM: orion5x: Fix GPIO enable bits for MPP9 Ben Hutchings
2012-04-11 1:29 ` Jason Cooper
2012-04-20 0:57 ` Ben Hutchings
2012-05-08 18:26 ` Jason Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.