[U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again

[U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again

[Fabio Estevam]

There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is 
already established.

Use gpio_set_value() for changing the GPIO output then.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6qsabrelite/mx6qsabrelite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
index 1d09a72..2155d87 100644
--- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
+++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
@@ -135,7 +135,7 @@ static void setup_iomux_enet(void)
 
 	/* Need delay 10ms according to KSZ9021 spec */
 	udelay(1000 * 10);
-	gpio_direction_output(87, 1);  /* GPIO 3-23 */
+	gpio_set_value(87, 1);  /* GPIO 3-23 */
 
 	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
 }
-- 
1.7.1

[U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again

[Dirk Behme]

On 11.04.2012 22:22, Fabio Estevam wrote:
> There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is
> already established.
>
> Use gpio_set_value() for changing the GPIO output then.
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 1d09a72..2155d87 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -135,7 +135,7 @@ static void setup_iomux_enet(void)
>
>   	/* Need delay 10ms according to KSZ9021 spec */
>   	udelay(1000 * 10);
> -	gpio_direction_output(87, 1);  /* GPIO 3-23 */
> +	gpio_set_value(87, 1);  /* GPIO 3-23 */
>
>   	imx_iomux_v3_setup_multiple_pads(enet_pads2, ARRAY_SIZE(enet_pads2));
>   }

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

Thanks

Dirk

[U-Boot] [PATCH] mx6qsabrelite: No need to set the direction for GPIO3_23 again

[Stefano Babic]

On 11/04/2012 22:22, Fabio Estevam wrote:
> There is a 'gpio_direction_output(87, 0);' call previously, so the GPIO direction is 
> already established.
> 
> Use gpio_set_value() for changing the GPIO output then.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---


Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================