* [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
@ 2012-04-12 7:16 Lukasz Majewski
2012-04-14 9:48 ` Marek Vasut
2012-04-14 13:47 ` Wolfgang Denk
0 siblings, 2 replies; 5+ messages in thread
From: Lukasz Majewski @ 2012-04-12 7:16 UTC (permalink / raw)
To: u-boot
This commit adds support for storing private data to Samsung's UDC
driver. This data is afterward used by usb gadget.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Vasut <marex@denx.de>
---
drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/s3c_udc_otg.c b/drivers/usb/gadget/s3c_udc_otg.c
index f7f7b54..cb4916c 100644
--- a/drivers/usb/gadget/s3c_udc_otg.c
+++ b/drivers/usb/gadget/s3c_udc_otg.c
@@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int status);
static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
static void s3c_udc_set_nak(struct s3c_ep *ep);
+void set_udc_gadget_private_data(void *p)
+{
+ printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
+ the_controller, p);
+ the_controller->gadget.dev.device_data = p;
+}
+
+void *get_udc_gadget_private_data(struct usb_gadget *gadget)
+{
+ return gadget->dev.device_data;
+}
+
static struct usb_ep_ops s3c_ep_ops = {
.enable = s3c_ep_enable,
.disable = s3c_ep_disable,
--
1.7.2.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
2012-04-12 7:16 [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
@ 2012-04-14 9:48 ` Marek Vasut
2012-04-16 9:33 ` Lukasz Majewski
2012-04-14 13:47 ` Wolfgang Denk
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2012-04-14 9:48 UTC (permalink / raw)
To: u-boot
Dear Lukasz Majewski,
> This commit adds support for storing private data to Samsung's UDC
> driver. This data is afterward used by usb gadget.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..cb4916c 100644
> --- a/drivers/usb/gadget/s3c_udc_otg.c
> +++ b/drivers/usb/gadget/s3c_udc_otg.c
> @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int status);
> static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
> static void s3c_udc_set_nak(struct s3c_ep *ep);
>
> +void set_udc_gadget_private_data(void *p)
> +{
> + printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> + the_controller, p);
> + the_controller->gadget.dev.device_data = p;
> +}
> +
> +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> +{
> + return gadget->dev.device_data;
> +}
> +
Is this part of some bigger patchset or are you simply adding dead code?
> static struct usb_ep_ops s3c_ep_ops = {
> .enable = s3c_ep_enable,
> .disable = s3c_ep_disable,
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
2012-04-12 7:16 [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
2012-04-14 9:48 ` Marek Vasut
@ 2012-04-14 13:47 ` Wolfgang Denk
1 sibling, 0 replies; 5+ messages in thread
From: Wolfgang Denk @ 2012-04-14 13:47 UTC (permalink / raw)
To: u-boot
Dear Lukasz Majewski,
In message <1334214969-19664-1-git-send-email-l.majewski@samsung.com> you wrote:
> This commit adds support for storing private data to Samsung's UDC
> driver. This data is afterward used by usb gadget.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
...
> +void set_udc_gadget_private_data(void *p)
> +{
> + printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
s/printf/debug/ ??
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
- Terry Pratchett, _Eric_
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
2012-04-14 9:48 ` Marek Vasut
@ 2012-04-16 9:33 ` Lukasz Majewski
2012-04-16 9:41 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2012-04-16 9:33 UTC (permalink / raw)
To: u-boot
Hi Marek Vasut,
> Dear Lukasz Majewski,
>
> > This commit adds support for storing private data to Samsung's UDC
> > driver. This data is afterward used by usb gadget.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Marek Vasut <marex@denx.de>
> > ---
> > drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++
> > 1 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> > b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..cb4916c 100644
> > --- a/drivers/usb/gadget/s3c_udc_otg.c
> > +++ b/drivers/usb/gadget/s3c_udc_otg.c
> > @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int
> > status); static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
> > static void s3c_udc_set_nak(struct s3c_ep *ep);
> >
> > +void set_udc_gadget_private_data(void *p)
> > +{
> > + printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> > + the_controller, p);
> > + the_controller->gadget.dev.device_data = p;
> > +}
> > +
> > +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> > +{
> > + return gadget->dev.device_data;
> > +}
> > +
>
> Is this part of some bigger patchset or are you simply adding dead
> code?
Yes, this is the part of a bigger patchset :-) - the composite gadget
(g_dnl) requires this change.
e.g.
http://patchwork.ozlabs.org/patch/151989/
>
> > static struct usb_ep_ops s3c_ep_ops = {
> > .enable = s3c_ep_enable,
> > .disable = s3c_ep_disable,
>
> Best regards,
> Marek Vasut
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center
Platform Group
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver
2012-04-16 9:33 ` Lukasz Majewski
@ 2012-04-16 9:41 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-04-16 9:41 UTC (permalink / raw)
To: u-boot
Dear Lukasz Majewski,
> Hi Marek Vasut,
>
> > Dear Lukasz Majewski,
> >
> > > This commit adds support for storing private data to Samsung's UDC
> > > driver. This data is afterward used by usb gadget.
> > >
> > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > Cc: Marek Vasut <marex@denx.de>
> > > ---
> > >
> > > drivers/usb/gadget/s3c_udc_otg.c | 12 ++++++++++++
> > > 1 files changed, 12 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> > > b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..cb4916c 100644
> > > --- a/drivers/usb/gadget/s3c_udc_otg.c
> > > +++ b/drivers/usb/gadget/s3c_udc_otg.c
> > > @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int
> > > status); static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
> > >
> > > static void s3c_udc_set_nak(struct s3c_ep *ep);
> > >
> > > +void set_udc_gadget_private_data(void *p)
> > > +{
> > > + printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> > > + the_controller, p);
> > > + the_controller->gadget.dev.device_data = p;
> > > +}
> > > +
> > > +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> > > +{
> > > + return gadget->dev.device_data;
> > > +}
> > > +
> >
> > Is this part of some bigger patchset or are you simply adding dead
> > code?
>
> Yes, this is the part of a bigger patchset :-) - the composite gadget
> (g_dnl) requires this change.
>
> e.g.
>
> http://patchwork.ozlabs.org/patch/151989/
Can you please make it into a patchset then? You know -- so we all know what
this is part of.
>
> > > static struct usb_ep_ops s3c_ep_ops = {
> > >
> > > .enable = s3c_ep_enable,
> > > .disable = s3c_ep_disable,
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-16 9:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 7:16 [U-Boot] [PATCH] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
2012-04-14 9:48 ` Marek Vasut
2012-04-16 9:33 ` Lukasz Majewski
2012-04-16 9:41 ` Marek Vasut
2012-04-14 13:47 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.