All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: arm@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	w.sang@pengutronix.de, srinivas.bakki@nxp.com,
	kevin.wells@nxp.com, gregkh@linuxfoundation.org,
	netdev@vger.kernel.org, rtc-linux@googlegroups.com,
	a.zummo@towertech.it, linux-watchdog@vger.kernel.org,
	wim@iguana.be, jonsmirl@gmail.com
Cc: Roland Stigge <stigge@antcom.de>, stable@vger.kernel.org
Subject: [PATCH RESEND v3 5/8] i2c-pnx.c: Fix suspend
Date: Sat, 14 Apr 2012 00:36:36 +0200	[thread overview]
Message-ID: <1334356600-20950-5-git-send-email-stigge@antcom.de> (raw)
In-Reply-To: <1334356600-20950-1-git-send-email-stigge@antcom.de>

In the driver's suspend function, clk_enable() was used instead of
clk_disable(). This is corrected with this patch.

Signed-off-by: Roland Stigge <stigge@antcom.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
CC: stable@vger.kernel.org

---

 Applies to v3.4-rc2

 drivers/i2c/busses/i2c-pnx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.orig/drivers/i2c/busses/i2c-pnx.c
+++ linux-2.6/drivers/i2c/busses/i2c-pnx.c
@@ -546,8 +546,7 @@ static int i2c_pnx_controller_suspend(st
 {
 	struct i2c_pnx_algo_data *alg_data = platform_get_drvdata(pdev);
 
-	/* FIXME: shouldn't this be clk_disable? */
-	clk_enable(alg_data->clk);
+	clk_disable(alg_data->clk);
 
 	return 0;
 }

WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v3 5/8] i2c-pnx.c: Fix suspend
Date: Sat, 14 Apr 2012 00:36:36 +0200	[thread overview]
Message-ID: <1334356600-20950-5-git-send-email-stigge@antcom.de> (raw)
In-Reply-To: <1334356600-20950-1-git-send-email-stigge@antcom.de>

In the driver's suspend function, clk_enable() was used instead of
clk_disable(). This is corrected with this patch.

Signed-off-by: Roland Stigge <stigge@antcom.de>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
CC: stable at vger.kernel.org

---

 Applies to v3.4-rc2

 drivers/i2c/busses/i2c-pnx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.orig/drivers/i2c/busses/i2c-pnx.c
+++ linux-2.6/drivers/i2c/busses/i2c-pnx.c
@@ -546,8 +546,7 @@ static int i2c_pnx_controller_suspend(st
 {
 	struct i2c_pnx_algo_data *alg_data = platform_get_drvdata(pdev);
 
-	/* FIXME: shouldn't this be clk_disable? */
-	clk_enable(alg_data->clk);
+	clk_disable(alg_data->clk);
 
 	return 0;
 }

  parent reply	other threads:[~2012-04-13 22:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 22:36 [PATCH RESEND v3 1/8] iio: Add device tree support to LPC32xx ADC Roland Stigge
2012-04-13 22:36 ` Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 2/8] rtc: Add device tree support for LPC32xx Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 3/8] net: Add device tree support to LPC32xx Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 4/8] wdt: Device tree support for pnx4008-wdt Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36 ` Roland Stigge [this message]
2012-04-13 22:36   ` [PATCH RESEND v3 5/8] i2c-pnx.c: Fix suspend Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 6/8] i2c-pnx.c: Use resources in platforms Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 7/8] i2c-pnx.c: Remove duplicated i2c.h Roland Stigge
2012-04-13 22:36   ` Roland Stigge
2012-04-13 22:36 ` [PATCH RESEND v3 8/8] i2c: Add device tree support to i2c-pnx.c Roland Stigge
2012-04-13 22:36   ` Roland Stigge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334356600-20950-5-git-send-email-stigge@antcom.de \
    --to=stigge@antcom.de \
    --cc=a.zummo@towertech.it \
    --cc=arm@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonsmirl@gmail.com \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=srinivas.bakki@nxp.com \
    --cc=stable@vger.kernel.org \
    --cc=w.sang@pengutronix.de \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.